Change internal constructor signatures.

Created "params" type to avoid positional arguments.
Personally it feels more explicit and reads better.
This commit is contained in:
Ken Hibino
2020-05-17 12:33:55 -07:00
parent 4e3e053989
commit 4492ed9255
11 changed files with 112 additions and 36 deletions

View File

@@ -27,13 +27,20 @@ type heartbeater struct {
interval time.Duration
}
func newHeartbeater(l *log.Logger, b base.Broker, ss *base.ServerState, interval time.Duration) *heartbeater {
type heartbeaterParams struct {
logger *log.Logger
broker base.Broker
serverState *base.ServerState
interval time.Duration
}
func newHeartbeater(params heartbeaterParams) *heartbeater {
return &heartbeater{
logger: l,
broker: b,
ss: ss,
logger: params.logger,
broker: params.broker,
ss: params.serverState,
done: make(chan struct{}),
interval: interval,
interval: params.interval,
}
}