mirror of
https://github.com/hibiken/asynq.git
synced 2025-10-24 22:46:11 +08:00
Refactor redis keys and store messages in protobuf
Changes:
- Task messages are stored under "asynq:{<qname>}:t:<task_id>" key in redis, value is a HASH type and message are stored under "msg" key in the hash. The hash also stores "deadline", "timeout".
- Redis LIST and ZSET stores task message IDs
- Task messages are serialized using protocol buffer
This commit is contained in:
@@ -6,6 +6,7 @@
|
||||
package base
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"fmt"
|
||||
"sync"
|
||||
@@ -174,10 +175,21 @@ type TaskMessage struct {
|
||||
func EncodeMessage(msg *TaskMessage) ([]byte, error) {
|
||||
if msg == nil {
|
||||
return nil, fmt.Errorf("cannot encode nil message")
|
||||
<<<<<<< HEAD
|
||||
}
|
||||
return proto.Marshal(&pb.TaskMessage{
|
||||
Type: msg.Type,
|
||||
Payload: msg.Payload,
|
||||
=======
|
||||
}
|
||||
payload, err := json.Marshal(msg.Payload)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return proto.Marshal(&pb.TaskMessage{
|
||||
Type: msg.Type,
|
||||
Payload: payload,
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
Id: msg.ID.String(),
|
||||
Queue: msg.Queue,
|
||||
Retry: int32(msg.Retry),
|
||||
@@ -193,11 +205,22 @@ func EncodeMessage(msg *TaskMessage) ([]byte, error) {
|
||||
func DecodeMessage(data []byte) (*TaskMessage, error) {
|
||||
var pbmsg pb.TaskMessage
|
||||
if err := proto.Unmarshal(data, &pbmsg); err != nil {
|
||||
<<<<<<< HEAD
|
||||
=======
|
||||
return nil, err
|
||||
}
|
||||
payload, err := decodePayload(pbmsg.GetPayload())
|
||||
if err != nil {
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
return nil, err
|
||||
}
|
||||
return &TaskMessage{
|
||||
Type: pbmsg.GetType(),
|
||||
<<<<<<< HEAD
|
||||
Payload: pbmsg.GetPayload(),
|
||||
=======
|
||||
Payload: payload,
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
ID: uuid.MustParse(pbmsg.GetId()),
|
||||
Queue: pbmsg.GetQueue(),
|
||||
Retry: int(pbmsg.GetRetry()),
|
||||
@@ -350,7 +373,11 @@ type WorkerInfo struct {
|
||||
ServerID string
|
||||
ID string
|
||||
Type string
|
||||
<<<<<<< HEAD
|
||||
Payload []byte
|
||||
=======
|
||||
Payload map[string]interface{}
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
Queue string
|
||||
Started time.Time
|
||||
Deadline time.Time
|
||||
@@ -361,6 +388,13 @@ func EncodeWorkerInfo(info *WorkerInfo) ([]byte, error) {
|
||||
if info == nil {
|
||||
return nil, fmt.Errorf("cannot encode nil worker info")
|
||||
}
|
||||
<<<<<<< HEAD
|
||||
=======
|
||||
payload, err := json.Marshal(info.Payload)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
startTime, err := ptypes.TimestampProto(info.Started)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
@@ -375,19 +409,43 @@ func EncodeWorkerInfo(info *WorkerInfo) ([]byte, error) {
|
||||
ServerId: info.ServerID,
|
||||
TaskId: info.ID,
|
||||
TaskType: info.Type,
|
||||
<<<<<<< HEAD
|
||||
TaskPayload: info.Payload,
|
||||
=======
|
||||
TaskPayload: payload,
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
Queue: info.Queue,
|
||||
StartTime: startTime,
|
||||
Deadline: deadline,
|
||||
})
|
||||
}
|
||||
|
||||
<<<<<<< HEAD
|
||||
=======
|
||||
func decodePayload(b []byte) (map[string]interface{}, error) {
|
||||
d := json.NewDecoder(bytes.NewReader(b))
|
||||
d.UseNumber()
|
||||
payload := make(map[string]interface{})
|
||||
if err := d.Decode(&payload); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return payload, nil
|
||||
}
|
||||
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
// DecodeWorkerInfo decodes the given bytes into WorkerInfo.
|
||||
func DecodeWorkerInfo(b []byte) (*WorkerInfo, error) {
|
||||
var pbmsg pb.WorkerInfo
|
||||
if err := proto.Unmarshal(b, &pbmsg); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
<<<<<<< HEAD
|
||||
=======
|
||||
payload, err := decodePayload(pbmsg.GetTaskPayload())
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
startTime, err := ptypes.Timestamp(pbmsg.GetStartTime())
|
||||
if err != nil {
|
||||
return nil, err
|
||||
@@ -402,7 +460,11 @@ func DecodeWorkerInfo(b []byte) (*WorkerInfo, error) {
|
||||
ServerID: pbmsg.GetServerId(),
|
||||
ID: pbmsg.GetTaskId(),
|
||||
Type: pbmsg.GetTaskType(),
|
||||
<<<<<<< HEAD
|
||||
Payload: pbmsg.GetTaskPayload(),
|
||||
=======
|
||||
Payload: payload,
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
Queue: pbmsg.GetQueue(),
|
||||
Started: startTime,
|
||||
Deadline: deadline,
|
||||
@@ -439,6 +501,13 @@ func EncodeSchedulerEntry(entry *SchedulerEntry) ([]byte, error) {
|
||||
if entry == nil {
|
||||
return nil, fmt.Errorf("cannot encode nil scheduler entry")
|
||||
}
|
||||
<<<<<<< HEAD
|
||||
=======
|
||||
payload, err := json.Marshal(entry.Payload)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
next, err := ptypes.TimestampProto(entry.Next)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
@@ -451,7 +520,11 @@ func EncodeSchedulerEntry(entry *SchedulerEntry) ([]byte, error) {
|
||||
Id: entry.ID,
|
||||
Spec: entry.Spec,
|
||||
TaskType: entry.Type,
|
||||
<<<<<<< HEAD
|
||||
TaskPayload: entry.Payload,
|
||||
=======
|
||||
TaskPayload: payload,
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
EnqueueOptions: entry.Opts,
|
||||
NextEnqueueTime: next,
|
||||
PrevEnqueueTime: prev,
|
||||
@@ -464,6 +537,13 @@ func DecodeSchedulerEntry(b []byte) (*SchedulerEntry, error) {
|
||||
if err := proto.Unmarshal(b, &pbmsg); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
<<<<<<< HEAD
|
||||
=======
|
||||
payload, err := decodePayload(pbmsg.GetTaskPayload())
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
next, err := ptypes.Timestamp(pbmsg.GetNextEnqueueTime())
|
||||
if err != nil {
|
||||
return nil, err
|
||||
@@ -476,7 +556,11 @@ func DecodeSchedulerEntry(b []byte) (*SchedulerEntry, error) {
|
||||
ID: pbmsg.GetId(),
|
||||
Spec: pbmsg.GetSpec(),
|
||||
Type: pbmsg.GetTaskType(),
|
||||
<<<<<<< HEAD
|
||||
Payload: pbmsg.GetTaskPayload(),
|
||||
=======
|
||||
Payload: payload,
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
Opts: pbmsg.GetEnqueueOptions(),
|
||||
Next: next,
|
||||
Prev: prev,
|
||||
|
||||
@@ -400,7 +400,11 @@ func TestServerInfoEncoding(t *testing.T) {
|
||||
Concurrency: 10,
|
||||
Queues: map[string]int{"default": 1, "critical": 2},
|
||||
StrictPriority: false,
|
||||
<<<<<<< HEAD
|
||||
Status: "active",
|
||||
=======
|
||||
Status: "running",
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
Started: time.Now().Add(-3 * time.Hour),
|
||||
ActiveWorkerCount: 8,
|
||||
},
|
||||
@@ -436,7 +440,11 @@ func TestWorkerInfoEncoding(t *testing.T) {
|
||||
ServerID: "abc123",
|
||||
ID: uuid.NewString(),
|
||||
Type: "taskA",
|
||||
<<<<<<< HEAD
|
||||
Payload: toBytes(map[string]interface{}{"foo": "bar"}),
|
||||
=======
|
||||
Payload: map[string]interface{}{"foo": "bar"},
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
Queue: "default",
|
||||
Started: time.Now().Add(-3 * time.Hour),
|
||||
Deadline: time.Now().Add(30 * time.Second),
|
||||
@@ -471,7 +479,11 @@ func TestSchedulerEntryEncoding(t *testing.T) {
|
||||
ID: uuid.NewString(),
|
||||
Spec: "* * * * *",
|
||||
Type: "task_A",
|
||||
<<<<<<< HEAD
|
||||
Payload: toBytes(map[string]interface{}{"foo": "bar"}),
|
||||
=======
|
||||
Payload: map[string]interface{}{"foo": "bar"},
|
||||
>>>>>>> 138bd7f... Refactor redis keys and store messages in protobuf
|
||||
Opts: []string{"Queue('email')"},
|
||||
Next: time.Now().Add(30 * time.Second).UTC(),
|
||||
Prev: time.Now().Add(-2 * time.Minute).UTC(),
|
||||
|
||||
Reference in New Issue
Block a user