go-pkg/cmux
2
0
Fork 0
mirror of https://github.com/soheilhy/cmux.git synced 2024-11-11 04:01:53 +08:00
Code Issues Projects Releases Wiki Activity

Do not write SETTINGS in response to ACKs.

Browse Source 
Reported-by talgendler in Issue #42
This commit is contained in:
Soheil Hassas Yeganeh 2018-01-29 10:44:55 -05:00 committed by Soheil Hassas Yeganeh
parent 444ce56efe
commit e09e9389d8
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
matchers.go
View File

@ -240,6 +240,11 @@ func matchHTTP2Field(w io.Writer, r io.Reader, name string, matches func(string)
switch f := f.(type) { switch f := f.(type) {
case *http2.SettingsFrame: case *http2.SettingsFrame:
// Sender acknoweldged the SETTINGS frame. No need to write
// SETTINGS again.
if f.IsAck() {
break
}
if err := framer.WriteSettings(); err != nil { if err := framer.WriteSettings(); err != nil {
return false return false
} }