From e496b358da71de6c478df0317625c8e41a773258 Mon Sep 17 00:00:00 2001 From: Soheil Hassas Yeganeh Date: Mon, 29 Jan 2018 10:44:55 -0500 Subject: [PATCH] Do not write SETTINGS in response to ACKs. Reported-by talgendler in Issue #42 --- matchers.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/matchers.go b/matchers.go index 652fd86..878ae98 100644 --- a/matchers.go +++ b/matchers.go @@ -240,6 +240,11 @@ func matchHTTP2Field(w io.Writer, r io.Reader, name string, matches func(string) switch f := f.(type) { case *http2.SettingsFrame: + // Sender acknoweldged the SETTINGS frame. No need to write + // SETTINGS again. + if f.IsAck() { + break + } if err := framer.WriteSettings(); err != nil { return false }