Compare commits
81 Commits
Author | SHA1 | Date | |
---|---|---|---|
|
ade6e61f51 | ||
|
a2abeedaa0 | ||
|
81bb52b08c | ||
|
bc2a7635a0 | ||
|
f65d408bf9 | ||
|
4749b4bbfc | ||
|
06c4a1c7f8 | ||
|
8af4cbad51 | ||
|
4e800a7f68 | ||
|
d6a5c84dc6 | ||
|
363cfedb49 | ||
|
4595bd41c3 | ||
|
e236d55477 | ||
|
a38f628f3b | ||
|
69ad583278 | ||
|
23f46dde52 | ||
|
39188fe930 | ||
|
4492ed9255 | ||
|
4e3e053989 | ||
|
aef0775c05 | ||
|
de146993d2 | ||
|
60cbf8dc5a | ||
|
fb38086590 | ||
|
cfcd19a222 | ||
|
24ee4b9693 | ||
|
7849b395bd | ||
|
fa3082e5bb | ||
|
d13f7e900f | ||
|
b63476ddc8 | ||
|
210b026b01 | ||
|
556b2103fe | ||
|
0289bc7a10 | ||
|
ae942c93e5 | ||
|
0faf97f146 | ||
|
711bfa371f | ||
|
73d62844e6 | ||
|
00b82904c6 | ||
|
a866369866 | ||
|
26b78136ba | ||
|
44aad7f037 | ||
|
9884d5f2fa | ||
|
826f1ecff4 | ||
|
24f2b64c6c | ||
|
1c1474c55c | ||
|
5161b9368a | ||
|
0c998a8e17 | ||
|
49160f2536 | ||
|
e33d297d8e | ||
|
eb8ced6bdd | ||
|
789a9fd711 | ||
|
5924cdac33 | ||
|
442c9275a0 | ||
|
a0865df33c | ||
|
431a96a1f7 | ||
|
74e5582cfc | ||
|
bf542a781c | ||
|
7c7f8e5f30 | ||
|
46ab4417dd | ||
|
f8a94fb839 | ||
|
42453280f4 | ||
|
4ec2dc9e47 | ||
|
45933eb6b0 | ||
|
4df372b369 | ||
|
c688b8f4f9 | ||
|
eef2f5f3cb | ||
|
239ef27a6e | ||
|
24da281aa7 | ||
|
b086e88a47 | ||
|
cf61911a49 | ||
|
aafd8a5b74 | ||
|
4f11e52558 | ||
|
b14c73809e | ||
|
779065c269 | ||
|
f9842ba914 | ||
|
022dc29701 | ||
|
40d1889ba0 | ||
|
7e96e893fe | ||
|
84b0c76c8b | ||
|
60b887b8e3 | ||
|
7864bea55c | ||
|
47220554ca |
6
.gitignore
vendored
@@ -15,7 +15,7 @@
|
|||||||
/examples
|
/examples
|
||||||
|
|
||||||
# Ignore command binary
|
# Ignore command binary
|
||||||
/tools/asynqmon/asynqmon
|
/tools/asynq/asynq
|
||||||
|
|
||||||
# Ignore asynqmon config file
|
# Ignore asynq config file
|
||||||
.asynqmon.*
|
.asynq.*
|
@@ -5,6 +5,7 @@ git:
|
|||||||
go: [1.13.x, 1.14.x]
|
go: [1.13.x, 1.14.x]
|
||||||
script:
|
script:
|
||||||
- go test -race -v -coverprofile=coverage.txt -covermode=atomic ./...
|
- go test -race -v -coverprofile=coverage.txt -covermode=atomic ./...
|
||||||
|
- go test -run=XXX -bench=. -loglevel=debug ./...
|
||||||
services:
|
services:
|
||||||
- redis-server
|
- redis-server
|
||||||
after_success:
|
after_success:
|
||||||
|
@@ -3,13 +3,16 @@ if [ "${TRAVIS_PULL_REQUEST_BRANCH:-$TRAVIS_BRANCH}" != "master" ]; then
|
|||||||
cd ${TRAVIS_BUILD_DIR}/.. && \
|
cd ${TRAVIS_BUILD_DIR}/.. && \
|
||||||
git clone ${REMOTE_URL} "${TRAVIS_REPO_SLUG}-bench" && \
|
git clone ${REMOTE_URL} "${TRAVIS_REPO_SLUG}-bench" && \
|
||||||
cd "${TRAVIS_REPO_SLUG}-bench" && \
|
cd "${TRAVIS_REPO_SLUG}-bench" && \
|
||||||
|
|
||||||
# Benchmark master
|
# Benchmark master
|
||||||
git checkout master && \
|
git checkout master && \
|
||||||
go test -run=XXX -bench=. ./... > master.txt && \
|
go test -run=XXX -bench=. ./... > master.txt && \
|
||||||
|
|
||||||
# Benchmark feature branch
|
# Benchmark feature branch
|
||||||
git checkout ${TRAVIS_COMMIT} && \
|
git checkout ${TRAVIS_COMMIT} && \
|
||||||
go test -run=XXX -bench=. ./... > feature.txt && \
|
go test -run=XXX -bench=. ./... > feature.txt && \
|
||||||
go get -u golang.org/x/tools/cmd/benchcmp && \
|
|
||||||
# compare two benchmarks
|
# compare two benchmarks
|
||||||
|
go get -u golang.org/x/tools/cmd/benchcmp && \
|
||||||
benchcmp master.txt feature.txt;
|
benchcmp master.txt feature.txt;
|
||||||
fi
|
fi
|
||||||
|
70
CHANGELOG.md
@@ -7,6 +7,76 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|||||||
|
|
||||||
## [Unreleased]
|
## [Unreleased]
|
||||||
|
|
||||||
|
## [0.9.3] - 2020-06-12
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
|
||||||
|
- Fixes the JSON number overflow issue (https://github.com/hibiken/asynq/issues/166).
|
||||||
|
|
||||||
|
|
||||||
|
## [0.9.2] - 2020-06-08
|
||||||
|
|
||||||
|
### Added
|
||||||
|
|
||||||
|
- The `pause` and `unpause` commands were added to the CLI. See README for the CLI for details.
|
||||||
|
|
||||||
|
## [0.9.1] - 2020-05-29
|
||||||
|
|
||||||
|
### Added
|
||||||
|
|
||||||
|
- `GetTaskID`, `GetRetryCount`, and `GetMaxRetry` functions were added to extract task metadata from context.
|
||||||
|
|
||||||
|
## [0.9.0] - 2020-05-16
|
||||||
|
|
||||||
|
### Changed
|
||||||
|
|
||||||
|
- `Logger` interface has changed. Please see the godoc for the new interface.
|
||||||
|
|
||||||
|
### Added
|
||||||
|
|
||||||
|
- `LogLevel` type is added. Server's log level can be specified through `LogLevel` field in `Config`.
|
||||||
|
|
||||||
|
## [0.8.3] - 2020-05-08
|
||||||
|
|
||||||
|
### Added
|
||||||
|
|
||||||
|
- `Close` method is added to `Client`.
|
||||||
|
|
||||||
|
## [0.8.2] - 2020-05-03
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
|
||||||
|
- [Fixed cancelfunc leak](https://github.com/hibiken/asynq/pull/145)
|
||||||
|
|
||||||
|
## [0.8.1] - 2020-04-27
|
||||||
|
|
||||||
|
### Added
|
||||||
|
|
||||||
|
- `ParseRedisURI` helper function is added to create a `RedisConnOpt` from a URI string.
|
||||||
|
- `SetDefaultOptions` method is added to `Client`.
|
||||||
|
|
||||||
|
## [0.8.0] - 2020-04-19
|
||||||
|
|
||||||
|
### Changed
|
||||||
|
|
||||||
|
- `Background` type is renamed to `Server`.
|
||||||
|
- To upgrade from the previous version, Update `NewBackground` to `NewServer` and pass `Config` by value.
|
||||||
|
- CLI is renamed to `asynq`.
|
||||||
|
- To upgrade the CLI to the latest version run `go get -u github.com/hibiken/tools/asynq`
|
||||||
|
- The `ps` command in CLI is renamed to `servers`
|
||||||
|
- `Concurrency` defaults to the number of CPUs when unset or set to a negative value.
|
||||||
|
|
||||||
|
### Added
|
||||||
|
|
||||||
|
- `ShutdownTimeout` field is added to `Config` to speicfy timeout duration used during graceful shutdown.
|
||||||
|
- New `Server` type exposes `Start`, `Stop`, and `Quiet` as well as `Run`.
|
||||||
|
|
||||||
|
## [0.7.1] - 2020-04-05
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
|
||||||
|
- Fixed signal handling for windows.
|
||||||
|
|
||||||
## [0.7.0] - 2020-03-22
|
## [0.7.0] - 2020-03-22
|
||||||
|
|
||||||
### Changed
|
### Changed
|
||||||
|
123
README.md
@@ -7,12 +7,42 @@
|
|||||||
[](https://gitter.im/go-asynq/community)
|
[](https://gitter.im/go-asynq/community)
|
||||||
[](https://codecov.io/gh/hibiken/asynq)
|
[](https://codecov.io/gh/hibiken/asynq)
|
||||||
|
|
||||||
Asynq is a simple Go library for queueing tasks and processing them in the background with workers.
|
## Overview
|
||||||
It is backed by Redis and it is designed to have a low barrier to entry. It should be integrated in your web stack easily.
|
|
||||||
|
|
||||||
**Important Note**: Current major version is zero (v0.x.x) to accomodate rapid development and fast iteration while getting early feedback from users. The public API could change without a major version update before v1.0.0 release.
|
Asynq is a Go library for queueing tasks and processing them in the background with workers. It is backed by Redis and it is designed to have a low barrier to entry. It should be integrated in your web stack easily.
|
||||||
|
|
||||||

|
Highlevel overview of how Asynq works:
|
||||||
|
|
||||||
|
- Client puts task on a queue
|
||||||
|
- Server pulls task off queues and starts a worker goroutine for each task
|
||||||
|
- Tasks are processed concurrently by multiple workers
|
||||||
|
|
||||||
|
Task queues are used as a mechanism to distribute work across multiple machines.
|
||||||
|
A system can consist of multiple worker servers and brokers, giving way to high availability and horizontal scaling.
|
||||||
|
|
||||||
|

|
||||||
|
|
||||||
|
## Stability and Compatibility
|
||||||
|
|
||||||
|
**Important Note**: Current major version is zero (v0.x.x) to accomodate rapid development and fast iteration while getting early feedback from users (Feedback on APIs are appreciated!). The public API could change without a major version update before v1.0.0 release.
|
||||||
|
|
||||||
|
**Status**: The library is currently undergoing heavy development with frequent, breaking API changes.
|
||||||
|
|
||||||
|
## Features
|
||||||
|
|
||||||
|
- Guaranteed [at least one execution](https://www.cloudcomputingpatterns.org/at_least_once_delivery/) of a task
|
||||||
|
- Scheduling of tasks
|
||||||
|
- Durability since tasks are written to Redis
|
||||||
|
- [Retries](https://github.com/hibiken/asynq/wiki/Task-Retry) of failed tasks
|
||||||
|
- [Weighted priority queues](https://github.com/hibiken/asynq/wiki/Priority-Queues#weighted-priority-queues)
|
||||||
|
- [Strict priority queues](https://github.com/hibiken/asynq/wiki/Priority-Queues#strict-priority-queues)
|
||||||
|
- Low latency to add a task since writes are fast in Redis
|
||||||
|
- De-duplication of tasks using [unique option](https://github.com/hibiken/asynq/wiki/Unique-Tasks)
|
||||||
|
- Allow [timeout and deadline per task](https://github.com/hibiken/asynq/wiki/Task-Timeout-and-Cancelation)
|
||||||
|
- [Flexible handler interface with support for middlewares](https://github.com/hibiken/asynq/wiki/Handler-Deep-Dive)
|
||||||
|
- [Ability to pause queue](/tools/asynq/README.md#pause) to stop processing tasks from the queue
|
||||||
|
- [Support Redis Sentinels](https://github.com/hibiken/asynq/wiki/Automatic-Failover) for HA
|
||||||
|
- [CLI](#command-line-tool) to inspect and remote-control queues and tasks
|
||||||
|
|
||||||
## Quickstart
|
## Quickstart
|
||||||
|
|
||||||
@@ -22,7 +52,7 @@ First, make sure you are running a Redis server locally.
|
|||||||
$ redis-server
|
$ redis-server
|
||||||
```
|
```
|
||||||
|
|
||||||
Next, write a package that encapslates task creation and task handling.
|
Next, write a package that encapsulates task creation and task handling.
|
||||||
|
|
||||||
```go
|
```go
|
||||||
package tasks
|
package tasks
|
||||||
@@ -33,13 +63,16 @@ import (
|
|||||||
"github.com/hibiken/asynq"
|
"github.com/hibiken/asynq"
|
||||||
)
|
)
|
||||||
|
|
||||||
// A list of background task types.
|
// A list of task types.
|
||||||
const (
|
const (
|
||||||
EmailDelivery = "email:deliver"
|
EmailDelivery = "email:deliver"
|
||||||
ImageProcessing = "image:process"
|
ImageProcessing = "image:process"
|
||||||
)
|
)
|
||||||
|
|
||||||
// Write function NewXXXTask to create a task.
|
//----------------------------------------------
|
||||||
|
// Write a function NewXXXTask to create a task.
|
||||||
|
// A task consists of a type and a payload.
|
||||||
|
//----------------------------------------------
|
||||||
|
|
||||||
func NewEmailDeliveryTask(userID int, tmplID string) *asynq.Task {
|
func NewEmailDeliveryTask(userID int, tmplID string) *asynq.Task {
|
||||||
payload := map[string]interface{}{"user_id": userID, "template_id": tmplID}
|
payload := map[string]interface{}{"user_id": userID, "template_id": tmplID}
|
||||||
@@ -51,8 +84,13 @@ func NewImageProcessingTask(src, dst string) *asynq.Task {
|
|||||||
return asynq.NewTask(ImageProcessing, payload)
|
return asynq.NewTask(ImageProcessing, payload)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Write function HandleXXXTask to handle the given task.
|
//---------------------------------------------------------------
|
||||||
// NOTE: It satisfies the asynq.HandlerFunc interface.
|
// Write a function HandleXXXTask to handle the input task.
|
||||||
|
// Note that it satisfies the asynq.HandlerFunc interface.
|
||||||
|
//
|
||||||
|
// Handler doesn't need to be a function. You can define a type
|
||||||
|
// that satisfies asynq.Handler interface. See examples below.
|
||||||
|
//---------------------------------------------------------------
|
||||||
|
|
||||||
func HandleEmailDeliveryTask(ctx context.Context, t *asynq.Task) error {
|
func HandleEmailDeliveryTask(ctx context.Context, t *asynq.Task) error {
|
||||||
userID, err := t.Payload.GetInt("user_id")
|
userID, err := t.Payload.GetInt("user_id")
|
||||||
@@ -68,7 +106,12 @@ func HandleEmailDeliveryTask(ctx context.Context, t *asynq.Task) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func HandleImageProcessingTask(ctx context.Context, t *asynq.Task) error {
|
// ImageProcessor implements asynq.Handler interface.
|
||||||
|
type ImageProcesser struct {
|
||||||
|
// ... fields for struct
|
||||||
|
}
|
||||||
|
|
||||||
|
func (p *ImageProcessor) ProcessTask(ctx context.Context, t *asynq.Task) error {
|
||||||
src, err := t.Payload.GetString("src")
|
src, err := t.Payload.GetString("src")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
@@ -81,10 +124,14 @@ func HandleImageProcessingTask(ctx context.Context, t *asynq.Task) error {
|
|||||||
// Image processing logic ...
|
// Image processing logic ...
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func NewImageProcessor() *ImageProcessor {
|
||||||
|
// ... return an instance
|
||||||
|
}
|
||||||
```
|
```
|
||||||
|
|
||||||
In your web application code, import the above package and use [`Client`](https://pkg.go.dev/github.com/hibiken/asynq?tab=doc#Client) to enqueue tasks to the task queue.
|
In your web application code, import the above package and use [`Client`](https://pkg.go.dev/github.com/hibiken/asynq?tab=doc#Client) to put tasks on the queue.
|
||||||
A task will be processed by a background worker as soon as the task gets enqueued.
|
A task will be processed asynchronously by a background worker as soon as the task gets enqueued.
|
||||||
Scheduled tasks will be stored in Redis and will be enqueued at the specified time.
|
Scheduled tasks will be stored in Redis and will be enqueued at the specified time.
|
||||||
|
|
||||||
```go
|
```go
|
||||||
@@ -100,10 +147,14 @@ import (
|
|||||||
const redisAddr = "127.0.0.1:6379"
|
const redisAddr = "127.0.0.1:6379"
|
||||||
|
|
||||||
func main() {
|
func main() {
|
||||||
r := &asynq.RedisClientOpt{Addr: redisAddr}
|
r := asynq.RedisClientOpt{Addr: redisAddr}
|
||||||
c := asynq.NewClient(r)
|
c := asynq.NewClient(r)
|
||||||
|
defer c.Close()
|
||||||
|
|
||||||
|
// ------------------------------------------------------
|
||||||
// Example 1: Enqueue task to be processed immediately.
|
// Example 1: Enqueue task to be processed immediately.
|
||||||
|
// Use (*Client).Enqueue method.
|
||||||
|
// ------------------------------------------------------
|
||||||
|
|
||||||
t := tasks.NewEmailDeliveryTask(42, "some:template:id")
|
t := tasks.NewEmailDeliveryTask(42, "some:template:id")
|
||||||
err := c.Enqueue(t)
|
err := c.Enqueue(t)
|
||||||
@@ -112,7 +163,10 @@ func main() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
// ------------------------------------------------------------
|
||||||
// Example 2: Schedule task to be processed in the future.
|
// Example 2: Schedule task to be processed in the future.
|
||||||
|
// Use (*Client).EnqueueIn or (*Client).EnqueueAt.
|
||||||
|
// ------------------------------------------------------------
|
||||||
|
|
||||||
t = tasks.NewEmailDeliveryTask(42, "other:template:id")
|
t = tasks.NewEmailDeliveryTask(42, "other:template:id")
|
||||||
err = c.EnqueueIn(24*time.Hour, t)
|
err = c.EnqueueIn(24*time.Hour, t)
|
||||||
@@ -121,19 +175,34 @@ func main() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
// Example 3: Pass options to tune task processing behavior.
|
// ----------------------------------------------------------------------------
|
||||||
// Options include MaxRetry, Queue, Timeout, Deadline, etc.
|
// Example 3: Set options to tune task processing behavior.
|
||||||
|
// Options include MaxRetry, Queue, Timeout, Deadline, Unique etc.
|
||||||
|
// ----------------------------------------------------------------------------
|
||||||
|
|
||||||
|
c.SetDefaultOptions(tasks.ImageProcessing, asynq.MaxRetry(10), asynq.Timeout(time.Minute))
|
||||||
|
|
||||||
t = tasks.NewImageProcessingTask("some/blobstore/url", "other/blobstore/url")
|
t = tasks.NewImageProcessingTask("some/blobstore/url", "other/blobstore/url")
|
||||||
err = c.Enqueue(t, asynq.MaxRetry(10), asynq.Queue("critical"), asynq.Timeout(time.Minute))
|
err = c.Enqueue(t)
|
||||||
|
if err != nil {
|
||||||
|
log.Fatal("could not enqueue task: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
// Example 4: Pass options to tune task processing behavior at enqueue time.
|
||||||
|
// Options passed at enqueue time override default ones, if any.
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
t = tasks.NewImageProcessingTask("some/blobstore/url", "other/blobstore/url")
|
||||||
|
err = c.Enqueue(t, asynq.Queue("critical"), asynq.Timeout(30*time.Second))
|
||||||
if err != nil {
|
if err != nil {
|
||||||
log.Fatal("could not enqueue task: %v", err)
|
log.Fatal("could not enqueue task: %v", err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
```
|
```
|
||||||
|
|
||||||
Next, create a binary to process these tasks in the background.
|
Next, create a worker server to process these tasks in the background.
|
||||||
To start the background workers, use [`Background`](https://pkg.go.dev/github.com/hibiken/asynq?tab=doc#Background) and provide your [`Handler`](https://pkg.go.dev/github.com/hibiken/asynq?tab=doc#Handler) to process the tasks.
|
To start the background workers, use [`Server`](https://pkg.go.dev/github.com/hibiken/asynq?tab=doc#Server) and provide your [`Handler`](https://pkg.go.dev/github.com/hibiken/asynq?tab=doc#Handler) to process the tasks.
|
||||||
|
|
||||||
You can optionally use [`ServeMux`](https://pkg.go.dev/github.com/hibiken/asynq?tab=doc#ServeMux) to create a handler, just as you would with [`"net/http"`](https://golang.org/pkg/net/http/) Handler.
|
You can optionally use [`ServeMux`](https://pkg.go.dev/github.com/hibiken/asynq?tab=doc#ServeMux) to create a handler, just as you would with [`"net/http"`](https://golang.org/pkg/net/http/) Handler.
|
||||||
|
|
||||||
@@ -141,6 +210,8 @@ You can optionally use [`ServeMux`](https://pkg.go.dev/github.com/hibiken/asynq?
|
|||||||
package main
|
package main
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"log"
|
||||||
|
|
||||||
"github.com/hibiken/asynq"
|
"github.com/hibiken/asynq"
|
||||||
"your/app/package/tasks"
|
"your/app/package/tasks"
|
||||||
)
|
)
|
||||||
@@ -148,9 +219,9 @@ import (
|
|||||||
const redisAddr = "127.0.0.1:6379"
|
const redisAddr = "127.0.0.1:6379"
|
||||||
|
|
||||||
func main() {
|
func main() {
|
||||||
r := &asynq.RedisClientOpt{Addr: redisAddr}
|
r := asynq.RedisClientOpt{Addr: redisAddr}
|
||||||
|
|
||||||
bg := asynq.NewBackground(r, &asynq.Config{
|
srv := asynq.NewServer(r, asynq.Config{
|
||||||
// Specify how many concurrent workers to use
|
// Specify how many concurrent workers to use
|
||||||
Concurrency: 10,
|
Concurrency: 10,
|
||||||
// Optionally specify multiple queues with different priority.
|
// Optionally specify multiple queues with different priority.
|
||||||
@@ -165,10 +236,12 @@ func main() {
|
|||||||
// mux maps a type to a handler
|
// mux maps a type to a handler
|
||||||
mux := asynq.NewServeMux()
|
mux := asynq.NewServeMux()
|
||||||
mux.HandleFunc(tasks.EmailDelivery, tasks.HandleEmailDeliveryTask)
|
mux.HandleFunc(tasks.EmailDelivery, tasks.HandleEmailDeliveryTask)
|
||||||
mux.HandleFunc(tasks.ImageProcessing, tasks.HandleImageProcessingTask)
|
mux.Handle(tasks.ImageProcessing, tasks.NewImageProcessor())
|
||||||
// ...register other handlers...
|
// ...register other handlers...
|
||||||
|
|
||||||
bg.Run(mux)
|
if err := srv.Run(mux); err != nil {
|
||||||
|
log.Fatalf("could not run server: %v", err)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
```
|
```
|
||||||
|
|
||||||
@@ -184,7 +257,7 @@ Here's an example of running the `stats` command.
|
|||||||
|
|
||||||

|

|
||||||
|
|
||||||
For details on how to use the tool, refer to the tool's [README](/tools/asynqmon/README.md).
|
For details on how to use the tool, refer to the tool's [README](/tools/asynq/README.md).
|
||||||
|
|
||||||
## Installation
|
## Installation
|
||||||
|
|
||||||
@@ -197,7 +270,7 @@ go get -u github.com/hibiken/asynq
|
|||||||
To install the CLI tool, run the following command:
|
To install the CLI tool, run the following command:
|
||||||
|
|
||||||
```sh
|
```sh
|
||||||
go get -u github.com/hibiken/asynq/tools/asynqmon
|
go get -u github.com/hibiken/asynq/tools/asynq
|
||||||
```
|
```
|
||||||
|
|
||||||
## Requirements
|
## Requirements
|
||||||
@@ -216,7 +289,7 @@ Please see the [Contribution Guide](/CONTRIBUTING.md) before contributing.
|
|||||||
|
|
||||||
- [Sidekiq](https://github.com/mperham/sidekiq) : Many of the design ideas are taken from sidekiq and its Web UI
|
- [Sidekiq](https://github.com/mperham/sidekiq) : Many of the design ideas are taken from sidekiq and its Web UI
|
||||||
- [RQ](https://github.com/rq/rq) : Client APIs are inspired by rq library.
|
- [RQ](https://github.com/rq/rq) : Client APIs are inspired by rq library.
|
||||||
- [Cobra](https://github.com/spf13/cobra) : Asynqmon CLI is built with cobra
|
- [Cobra](https://github.com/spf13/cobra) : Asynq CLI is built with cobra
|
||||||
|
|
||||||
## License
|
## License
|
||||||
|
|
||||||
|
76
asynq.go
@@ -7,6 +7,9 @@ package asynq
|
|||||||
import (
|
import (
|
||||||
"crypto/tls"
|
"crypto/tls"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"net/url"
|
||||||
|
"strconv"
|
||||||
|
"strings"
|
||||||
|
|
||||||
"github.com/go-redis/redis/v7"
|
"github.com/go-redis/redis/v7"
|
||||||
)
|
)
|
||||||
@@ -94,6 +97,79 @@ type RedisFailoverClientOpt struct {
|
|||||||
TLSConfig *tls.Config
|
TLSConfig *tls.Config
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ParseRedisURI parses redis uri string and returns RedisConnOpt if uri is valid.
|
||||||
|
// It returns a non-nil error if uri cannot be parsed.
|
||||||
|
//
|
||||||
|
// Three URI schemes are supported, which are redis:, redis-socket:, and redis-sentinel:.
|
||||||
|
// Supported formats are:
|
||||||
|
// redis://[:password@]host[:port][/dbnumber]
|
||||||
|
// redis-socket://[:password@]path[?db=dbnumber]
|
||||||
|
// redis-sentinel://[:password@]host1[:port][,host2:[:port]][,hostN:[:port]][?master=masterName]
|
||||||
|
func ParseRedisURI(uri string) (RedisConnOpt, error) {
|
||||||
|
u, err := url.Parse(uri)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("asynq: could not parse redis uri: %v", err)
|
||||||
|
}
|
||||||
|
switch u.Scheme {
|
||||||
|
case "redis":
|
||||||
|
return parseRedisURI(u)
|
||||||
|
case "redis-socket":
|
||||||
|
return parseRedisSocketURI(u)
|
||||||
|
case "redis-sentinel":
|
||||||
|
return parseRedisSentinelURI(u)
|
||||||
|
default:
|
||||||
|
return nil, fmt.Errorf("asynq: unsupported uri scheme: %q", u.Scheme)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func parseRedisURI(u *url.URL) (RedisConnOpt, error) {
|
||||||
|
var db int
|
||||||
|
var err error
|
||||||
|
if len(u.Path) > 0 {
|
||||||
|
xs := strings.Split(strings.Trim(u.Path, "/"), "/")
|
||||||
|
db, err = strconv.Atoi(xs[0])
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("asynq: could not parse redis uri: database number should be the first segment of the path")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
var password string
|
||||||
|
if v, ok := u.User.Password(); ok {
|
||||||
|
password = v
|
||||||
|
}
|
||||||
|
return RedisClientOpt{Addr: u.Host, DB: db, Password: password}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func parseRedisSocketURI(u *url.URL) (RedisConnOpt, error) {
|
||||||
|
const errPrefix = "asynq: could not parse redis socket uri"
|
||||||
|
if len(u.Path) == 0 {
|
||||||
|
return nil, fmt.Errorf("%s: path does not exist", errPrefix)
|
||||||
|
}
|
||||||
|
q := u.Query()
|
||||||
|
var db int
|
||||||
|
var err error
|
||||||
|
if n := q.Get("db"); n != "" {
|
||||||
|
db, err = strconv.Atoi(n)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("%s: query param `db` should be a number", errPrefix)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
var password string
|
||||||
|
if v, ok := u.User.Password(); ok {
|
||||||
|
password = v
|
||||||
|
}
|
||||||
|
return RedisClientOpt{Network: "unix", Addr: u.Path, DB: db, Password: password}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func parseRedisSentinelURI(u *url.URL) (RedisConnOpt, error) {
|
||||||
|
addrs := strings.Split(u.Host, ",")
|
||||||
|
master := u.Query().Get("master")
|
||||||
|
var password string
|
||||||
|
if v, ok := u.User.Password(); ok {
|
||||||
|
password = v
|
||||||
|
}
|
||||||
|
return RedisFailoverClientOpt{MasterName: master, SentinelAddrs: addrs, Password: password}, nil
|
||||||
|
}
|
||||||
|
|
||||||
// createRedisClient returns a redis client given a redis connection configuration.
|
// createRedisClient returns a redis client given a redis connection configuration.
|
||||||
//
|
//
|
||||||
// Passing an unexpected type as a RedisConnOpt argument will cause panic.
|
// Passing an unexpected type as a RedisConnOpt argument will cause panic.
|
||||||
|
131
asynq_test.go
@@ -5,7 +5,7 @@
|
|||||||
package asynq
|
package asynq
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"os"
|
"flag"
|
||||||
"sort"
|
"sort"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
@@ -15,16 +15,28 @@ import (
|
|||||||
"github.com/hibiken/asynq/internal/log"
|
"github.com/hibiken/asynq/internal/log"
|
||||||
)
|
)
|
||||||
|
|
||||||
// This file defines test helper functions used by
|
//============================================================================
|
||||||
// other test files.
|
// This file defines helper functions and variables used in other test files.
|
||||||
|
//============================================================================
|
||||||
|
|
||||||
// redis used for package testing.
|
// variables used for package testing.
|
||||||
const (
|
var (
|
||||||
redisAddr = "localhost:6379"
|
redisAddr string
|
||||||
redisDB = 14
|
redisDB int
|
||||||
|
|
||||||
|
testLogLevel = FatalLevel
|
||||||
)
|
)
|
||||||
|
|
||||||
var testLogger = log.NewLogger(os.Stderr)
|
var testLogger *log.Logger
|
||||||
|
|
||||||
|
func init() {
|
||||||
|
flag.StringVar(&redisAddr, "redis_addr", "localhost:6379", "redis address to use in testing")
|
||||||
|
flag.IntVar(&redisDB, "redis_db", 14, "redis db number to use in testing")
|
||||||
|
flag.Var(&testLogLevel, "loglevel", "log level to use in testing")
|
||||||
|
|
||||||
|
testLogger = log.NewLogger(nil)
|
||||||
|
testLogger.SetLevel(toInternalLogLevel(testLogLevel))
|
||||||
|
}
|
||||||
|
|
||||||
func setup(tb testing.TB) *redis.Client {
|
func setup(tb testing.TB) *redis.Client {
|
||||||
tb.Helper()
|
tb.Helper()
|
||||||
@@ -44,3 +56,106 @@ var sortTaskOpt = cmp.Transformer("SortMsg", func(in []*Task) []*Task {
|
|||||||
})
|
})
|
||||||
return out
|
return out
|
||||||
})
|
})
|
||||||
|
|
||||||
|
func TestParseRedisURI(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
uri string
|
||||||
|
want RedisConnOpt
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
"redis://localhost:6379",
|
||||||
|
RedisClientOpt{Addr: "localhost:6379"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"redis://localhost:6379/3",
|
||||||
|
RedisClientOpt{Addr: "localhost:6379", DB: 3},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"redis://:mypassword@localhost:6379",
|
||||||
|
RedisClientOpt{Addr: "localhost:6379", Password: "mypassword"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"redis://:mypassword@127.0.0.1:6379/11",
|
||||||
|
RedisClientOpt{Addr: "127.0.0.1:6379", Password: "mypassword", DB: 11},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"redis-socket:///var/run/redis/redis.sock",
|
||||||
|
RedisClientOpt{Network: "unix", Addr: "/var/run/redis/redis.sock"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"redis-socket://:mypassword@/var/run/redis/redis.sock",
|
||||||
|
RedisClientOpt{Network: "unix", Addr: "/var/run/redis/redis.sock", Password: "mypassword"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"redis-socket:///var/run/redis/redis.sock?db=7",
|
||||||
|
RedisClientOpt{Network: "unix", Addr: "/var/run/redis/redis.sock", DB: 7},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"redis-socket://:mypassword@/var/run/redis/redis.sock?db=12",
|
||||||
|
RedisClientOpt{Network: "unix", Addr: "/var/run/redis/redis.sock", Password: "mypassword", DB: 12},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"redis-sentinel://localhost:5000,localhost:5001,localhost:5002?master=mymaster",
|
||||||
|
RedisFailoverClientOpt{
|
||||||
|
MasterName: "mymaster",
|
||||||
|
SentinelAddrs: []string{"localhost:5000", "localhost:5001", "localhost:5002"},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"redis-sentinel://:mypassword@localhost:5000,localhost:5001,localhost:5002?master=mymaster",
|
||||||
|
RedisFailoverClientOpt{
|
||||||
|
MasterName: "mymaster",
|
||||||
|
SentinelAddrs: []string{"localhost:5000", "localhost:5001", "localhost:5002"},
|
||||||
|
Password: "mypassword",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
got, err := ParseRedisURI(tc.uri)
|
||||||
|
if err != nil {
|
||||||
|
t.Errorf("ParseRedisURI(%q) returned an error: %v", tc.uri, err)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
if diff := cmp.Diff(tc.want, got); diff != "" {
|
||||||
|
t.Errorf("ParseRedisURI(%q) = %+v, want %+v\n(-want,+got)\n%s", tc.uri, got, tc.want, diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestParseRedisURIErrors(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
desc string
|
||||||
|
uri string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
"unsupported scheme",
|
||||||
|
"rdb://localhost:6379",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"missing scheme",
|
||||||
|
"localhost:6379",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"multiple db numbers",
|
||||||
|
"redis://localhost:6379/1,2,3",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"missing path for socket connection",
|
||||||
|
"redis-socket://?db=one",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"non integer for db numbers for socket",
|
||||||
|
"redis-socket:///some/path/to/redis?db=one",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
_, err := ParseRedisURI(tc.uri)
|
||||||
|
if err == nil {
|
||||||
|
t.Errorf("%s: ParseRedisURI(%q) succeeded for malformed input, want error",
|
||||||
|
tc.desc, tc.uri)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
313
background.go
@@ -1,313 +0,0 @@
|
|||||||
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
|
||||||
// Use of this source code is governed by a MIT license
|
|
||||||
// that can be found in the LICENSE file.
|
|
||||||
|
|
||||||
package asynq
|
|
||||||
|
|
||||||
import (
|
|
||||||
"context"
|
|
||||||
"fmt"
|
|
||||||
"math"
|
|
||||||
"math/rand"
|
|
||||||
"os"
|
|
||||||
"os/signal"
|
|
||||||
"sync"
|
|
||||||
"syscall"
|
|
||||||
"time"
|
|
||||||
|
|
||||||
"github.com/hibiken/asynq/internal/base"
|
|
||||||
"github.com/hibiken/asynq/internal/log"
|
|
||||||
"github.com/hibiken/asynq/internal/rdb"
|
|
||||||
)
|
|
||||||
|
|
||||||
// Background is responsible for managing the background-task processing.
|
|
||||||
//
|
|
||||||
// Background manages task queues to process tasks.
|
|
||||||
// If the processing of a task is unsuccessful, background will
|
|
||||||
// schedule it for a retry until either the task gets processed successfully
|
|
||||||
// or it exhausts its max retry count.
|
|
||||||
//
|
|
||||||
// Once a task exhausts its retries, it will be moved to the "dead" queue and
|
|
||||||
// will be kept in the queue for some time until a certain condition is met
|
|
||||||
// (e.g., queue size reaches a certain limit, or the task has been in the
|
|
||||||
// queue for a certain amount of time).
|
|
||||||
type Background struct {
|
|
||||||
mu sync.Mutex
|
|
||||||
running bool
|
|
||||||
|
|
||||||
ps *base.ProcessState
|
|
||||||
|
|
||||||
// wait group to wait for all goroutines to finish.
|
|
||||||
wg sync.WaitGroup
|
|
||||||
|
|
||||||
logger Logger
|
|
||||||
|
|
||||||
rdb *rdb.RDB
|
|
||||||
scheduler *scheduler
|
|
||||||
processor *processor
|
|
||||||
syncer *syncer
|
|
||||||
heartbeater *heartbeater
|
|
||||||
subscriber *subscriber
|
|
||||||
}
|
|
||||||
|
|
||||||
// Config specifies the background-task processing behavior.
|
|
||||||
type Config struct {
|
|
||||||
// Maximum number of concurrent processing of tasks.
|
|
||||||
//
|
|
||||||
// If set to a zero or negative value, NewBackground will overwrite the value to one.
|
|
||||||
Concurrency int
|
|
||||||
|
|
||||||
// Function to calculate retry delay for a failed task.
|
|
||||||
//
|
|
||||||
// By default, it uses exponential backoff algorithm to calculate the delay.
|
|
||||||
//
|
|
||||||
// n is the number of times the task has been retried.
|
|
||||||
// e is the error returned by the task handler.
|
|
||||||
// t is the task in question.
|
|
||||||
RetryDelayFunc func(n int, e error, t *Task) time.Duration
|
|
||||||
|
|
||||||
// List of queues to process with given priority value. Keys are the names of the
|
|
||||||
// queues and values are associated priority value.
|
|
||||||
//
|
|
||||||
// If set to nil or not specified, the background will process only the "default" queue.
|
|
||||||
//
|
|
||||||
// Priority is treated as follows to avoid starving low priority queues.
|
|
||||||
//
|
|
||||||
// Example:
|
|
||||||
// Queues: map[string]int{
|
|
||||||
// "critical": 6,
|
|
||||||
// "default": 3,
|
|
||||||
// "low": 1,
|
|
||||||
// }
|
|
||||||
// With the above config and given that all queues are not empty, the tasks
|
|
||||||
// in "critical", "default", "low" should be processed 60%, 30%, 10% of
|
|
||||||
// the time respectively.
|
|
||||||
//
|
|
||||||
// If a queue has a zero or negative priority value, the queue will be ignored.
|
|
||||||
Queues map[string]int
|
|
||||||
|
|
||||||
// StrictPriority indicates whether the queue priority should be treated strictly.
|
|
||||||
//
|
|
||||||
// If set to true, tasks in the queue with the highest priority is processed first.
|
|
||||||
// The tasks in lower priority queues are processed only when those queues with
|
|
||||||
// higher priorities are empty.
|
|
||||||
StrictPriority bool
|
|
||||||
|
|
||||||
// ErrorHandler handles errors returned by the task handler.
|
|
||||||
//
|
|
||||||
// HandleError is invoked only if the task handler returns a non-nil error.
|
|
||||||
//
|
|
||||||
// Example:
|
|
||||||
// func reportError(task *asynq.Task, err error, retried, maxRetry int) {
|
|
||||||
// if retried >= maxRetry {
|
|
||||||
// err = fmt.Errorf("retry exhausted for task %s: %w", task.Type, err)
|
|
||||||
// }
|
|
||||||
// errorReportingService.Notify(err)
|
|
||||||
// })
|
|
||||||
//
|
|
||||||
// ErrorHandler: asynq.ErrorHandlerFunc(reportError)
|
|
||||||
ErrorHandler ErrorHandler
|
|
||||||
|
|
||||||
// Logger specifies the logger used by the background instance.
|
|
||||||
//
|
|
||||||
// If unset, default logger is used.
|
|
||||||
Logger Logger
|
|
||||||
}
|
|
||||||
|
|
||||||
// An ErrorHandler handles errors returned by the task handler.
|
|
||||||
type ErrorHandler interface {
|
|
||||||
HandleError(task *Task, err error, retried, maxRetry int)
|
|
||||||
}
|
|
||||||
|
|
||||||
// The ErrorHandlerFunc type is an adapter to allow the use of ordinary functions as a ErrorHandler.
|
|
||||||
// If f is a function with the appropriate signature, ErrorHandlerFunc(f) is a ErrorHandler that calls f.
|
|
||||||
type ErrorHandlerFunc func(task *Task, err error, retried, maxRetry int)
|
|
||||||
|
|
||||||
// HandleError calls fn(task, err, retried, maxRetry)
|
|
||||||
func (fn ErrorHandlerFunc) HandleError(task *Task, err error, retried, maxRetry int) {
|
|
||||||
fn(task, err, retried, maxRetry)
|
|
||||||
}
|
|
||||||
|
|
||||||
// Logger implements logging with various log levels.
|
|
||||||
type Logger interface {
|
|
||||||
// Debug logs a message at Debug level.
|
|
||||||
Debug(format string, args ...interface{})
|
|
||||||
|
|
||||||
// Info logs a message at Info level.
|
|
||||||
Info(format string, args ...interface{})
|
|
||||||
|
|
||||||
// Warn logs a message at Warning level.
|
|
||||||
Warn(format string, args ...interface{})
|
|
||||||
|
|
||||||
// Error logs a message at Error level.
|
|
||||||
Error(format string, args ...interface{})
|
|
||||||
|
|
||||||
// Fatal logs a message at Fatal level
|
|
||||||
// and process will exit with status set to 1.
|
|
||||||
Fatal(format string, args ...interface{})
|
|
||||||
}
|
|
||||||
|
|
||||||
// Formula taken from https://github.com/mperham/sidekiq.
|
|
||||||
func defaultDelayFunc(n int, e error, t *Task) time.Duration {
|
|
||||||
r := rand.New(rand.NewSource(time.Now().UnixNano()))
|
|
||||||
s := int(math.Pow(float64(n), 4)) + 15 + (r.Intn(30) * (n + 1))
|
|
||||||
return time.Duration(s) * time.Second
|
|
||||||
}
|
|
||||||
|
|
||||||
var defaultQueueConfig = map[string]int{
|
|
||||||
base.DefaultQueueName: 1,
|
|
||||||
}
|
|
||||||
|
|
||||||
// NewBackground returns a new Background given a redis connection option
|
|
||||||
// and background processing configuration.
|
|
||||||
func NewBackground(r RedisConnOpt, cfg *Config) *Background {
|
|
||||||
n := cfg.Concurrency
|
|
||||||
if n < 1 {
|
|
||||||
n = 1
|
|
||||||
}
|
|
||||||
delayFunc := cfg.RetryDelayFunc
|
|
||||||
if delayFunc == nil {
|
|
||||||
delayFunc = defaultDelayFunc
|
|
||||||
}
|
|
||||||
queues := make(map[string]int)
|
|
||||||
for qname, p := range cfg.Queues {
|
|
||||||
if p > 0 {
|
|
||||||
queues[qname] = p
|
|
||||||
}
|
|
||||||
}
|
|
||||||
if len(queues) == 0 {
|
|
||||||
queues = defaultQueueConfig
|
|
||||||
}
|
|
||||||
logger := cfg.Logger
|
|
||||||
if logger == nil {
|
|
||||||
logger = log.NewLogger(os.Stderr)
|
|
||||||
}
|
|
||||||
|
|
||||||
host, err := os.Hostname()
|
|
||||||
if err != nil {
|
|
||||||
host = "unknown-host"
|
|
||||||
}
|
|
||||||
pid := os.Getpid()
|
|
||||||
|
|
||||||
rdb := rdb.NewRDB(createRedisClient(r))
|
|
||||||
ps := base.NewProcessState(host, pid, n, queues, cfg.StrictPriority)
|
|
||||||
syncCh := make(chan *syncRequest)
|
|
||||||
cancels := base.NewCancelations()
|
|
||||||
syncer := newSyncer(logger, syncCh, 5*time.Second)
|
|
||||||
heartbeater := newHeartbeater(logger, rdb, ps, 5*time.Second)
|
|
||||||
scheduler := newScheduler(logger, rdb, 5*time.Second, queues)
|
|
||||||
processor := newProcessor(logger, rdb, ps, delayFunc, syncCh, cancels, cfg.ErrorHandler)
|
|
||||||
subscriber := newSubscriber(logger, rdb, cancels)
|
|
||||||
return &Background{
|
|
||||||
logger: logger,
|
|
||||||
rdb: rdb,
|
|
||||||
ps: ps,
|
|
||||||
scheduler: scheduler,
|
|
||||||
processor: processor,
|
|
||||||
syncer: syncer,
|
|
||||||
heartbeater: heartbeater,
|
|
||||||
subscriber: subscriber,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// A Handler processes tasks.
|
|
||||||
//
|
|
||||||
// ProcessTask should return nil if the processing of a task
|
|
||||||
// is successful.
|
|
||||||
//
|
|
||||||
// If ProcessTask return a non-nil error or panics, the task
|
|
||||||
// will be retried after delay.
|
|
||||||
type Handler interface {
|
|
||||||
ProcessTask(context.Context, *Task) error
|
|
||||||
}
|
|
||||||
|
|
||||||
// The HandlerFunc type is an adapter to allow the use of
|
|
||||||
// ordinary functions as a Handler. If f is a function
|
|
||||||
// with the appropriate signature, HandlerFunc(f) is a
|
|
||||||
// Handler that calls f.
|
|
||||||
type HandlerFunc func(context.Context, *Task) error
|
|
||||||
|
|
||||||
// ProcessTask calls fn(ctx, task)
|
|
||||||
func (fn HandlerFunc) ProcessTask(ctx context.Context, task *Task) error {
|
|
||||||
return fn(ctx, task)
|
|
||||||
}
|
|
||||||
|
|
||||||
// Run starts the background-task processing and blocks until
|
|
||||||
// an os signal to exit the program is received. Once it receives
|
|
||||||
// a signal, it gracefully shuts down all pending workers and other
|
|
||||||
// goroutines to process the tasks.
|
|
||||||
func (bg *Background) Run(handler Handler) {
|
|
||||||
type prefixLogger interface {
|
|
||||||
SetPrefix(prefix string)
|
|
||||||
}
|
|
||||||
// If logger supports setting prefix, then set prefix for log output.
|
|
||||||
if l, ok := bg.logger.(prefixLogger); ok {
|
|
||||||
l.SetPrefix(fmt.Sprintf("asynq: pid=%d ", os.Getpid()))
|
|
||||||
}
|
|
||||||
bg.logger.Info("Starting processing")
|
|
||||||
|
|
||||||
bg.start(handler)
|
|
||||||
defer bg.stop()
|
|
||||||
|
|
||||||
bg.logger.Info("Send signal TSTP to stop processing new tasks")
|
|
||||||
bg.logger.Info("Send signal TERM or INT to terminate the process")
|
|
||||||
|
|
||||||
// Wait for a signal to terminate.
|
|
||||||
sigs := make(chan os.Signal, 1)
|
|
||||||
signal.Notify(sigs, syscall.SIGTERM, syscall.SIGINT, syscall.SIGTSTP)
|
|
||||||
for {
|
|
||||||
sig := <-sigs
|
|
||||||
if sig == syscall.SIGTSTP {
|
|
||||||
bg.processor.stop()
|
|
||||||
bg.ps.SetStatus(base.StatusStopped)
|
|
||||||
continue
|
|
||||||
}
|
|
||||||
break
|
|
||||||
}
|
|
||||||
fmt.Println()
|
|
||||||
bg.logger.Info("Starting graceful shutdown")
|
|
||||||
}
|
|
||||||
|
|
||||||
// starts the background-task processing.
|
|
||||||
func (bg *Background) start(handler Handler) {
|
|
||||||
bg.mu.Lock()
|
|
||||||
defer bg.mu.Unlock()
|
|
||||||
if bg.running {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
bg.running = true
|
|
||||||
bg.processor.handler = handler
|
|
||||||
|
|
||||||
bg.heartbeater.start(&bg.wg)
|
|
||||||
bg.subscriber.start(&bg.wg)
|
|
||||||
bg.syncer.start(&bg.wg)
|
|
||||||
bg.scheduler.start(&bg.wg)
|
|
||||||
bg.processor.start(&bg.wg)
|
|
||||||
}
|
|
||||||
|
|
||||||
// stops the background-task processing.
|
|
||||||
func (bg *Background) stop() {
|
|
||||||
bg.mu.Lock()
|
|
||||||
defer bg.mu.Unlock()
|
|
||||||
if !bg.running {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
// Note: The order of termination is important.
|
|
||||||
// Sender goroutines should be terminated before the receiver goroutines.
|
|
||||||
//
|
|
||||||
// processor -> syncer (via syncCh)
|
|
||||||
bg.scheduler.terminate()
|
|
||||||
bg.processor.terminate()
|
|
||||||
bg.syncer.terminate()
|
|
||||||
bg.subscriber.terminate()
|
|
||||||
bg.heartbeater.terminate()
|
|
||||||
|
|
||||||
bg.wg.Wait()
|
|
||||||
|
|
||||||
bg.rdb.Close()
|
|
||||||
bg.running = false
|
|
||||||
|
|
||||||
bg.logger.Info("Bye!")
|
|
||||||
}
|
|
@@ -1,128 +0,0 @@
|
|||||||
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
|
||||||
// Use of this source code is governed by a MIT license
|
|
||||||
// that can be found in the LICENSE file.
|
|
||||||
|
|
||||||
package asynq
|
|
||||||
|
|
||||||
import (
|
|
||||||
"context"
|
|
||||||
"testing"
|
|
||||||
"time"
|
|
||||||
|
|
||||||
"github.com/google/go-cmp/cmp"
|
|
||||||
"go.uber.org/goleak"
|
|
||||||
)
|
|
||||||
|
|
||||||
func TestBackground(t *testing.T) {
|
|
||||||
// https://github.com/go-redis/redis/issues/1029
|
|
||||||
ignoreOpt := goleak.IgnoreTopFunction("github.com/go-redis/redis/v7/internal/pool.(*ConnPool).reaper")
|
|
||||||
defer goleak.VerifyNoLeaks(t, ignoreOpt)
|
|
||||||
|
|
||||||
r := &RedisClientOpt{
|
|
||||||
Addr: "localhost:6379",
|
|
||||||
DB: 15,
|
|
||||||
}
|
|
||||||
client := NewClient(r)
|
|
||||||
bg := NewBackground(r, &Config{
|
|
||||||
Concurrency: 10,
|
|
||||||
})
|
|
||||||
|
|
||||||
// no-op handler
|
|
||||||
h := func(ctx context.Context, task *Task) error {
|
|
||||||
return nil
|
|
||||||
}
|
|
||||||
|
|
||||||
bg.start(HandlerFunc(h))
|
|
||||||
|
|
||||||
err := client.Enqueue(NewTask("send_email", map[string]interface{}{"recipient_id": 123}))
|
|
||||||
if err != nil {
|
|
||||||
t.Errorf("could not enqueue a task: %v", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
err = client.EnqueueAt(time.Now().Add(time.Hour), NewTask("send_email", map[string]interface{}{"recipient_id": 456}))
|
|
||||||
if err != nil {
|
|
||||||
t.Errorf("could not enqueue a task: %v", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
bg.stop()
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestGCD(t *testing.T) {
|
|
||||||
tests := []struct {
|
|
||||||
input []int
|
|
||||||
want int
|
|
||||||
}{
|
|
||||||
{[]int{6, 2, 12}, 2},
|
|
||||||
{[]int{3, 3, 3}, 3},
|
|
||||||
{[]int{6, 3, 1}, 1},
|
|
||||||
{[]int{1}, 1},
|
|
||||||
{[]int{1, 0, 2}, 1},
|
|
||||||
{[]int{8, 0, 4}, 4},
|
|
||||||
{[]int{9, 12, 18, 30}, 3},
|
|
||||||
}
|
|
||||||
|
|
||||||
for _, tc := range tests {
|
|
||||||
got := gcd(tc.input...)
|
|
||||||
if got != tc.want {
|
|
||||||
t.Errorf("gcd(%v) = %d, want %d", tc.input, got, tc.want)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestNormalizeQueueCfg(t *testing.T) {
|
|
||||||
tests := []struct {
|
|
||||||
input map[string]int
|
|
||||||
want map[string]int
|
|
||||||
}{
|
|
||||||
{
|
|
||||||
input: map[string]int{
|
|
||||||
"high": 100,
|
|
||||||
"default": 20,
|
|
||||||
"low": 5,
|
|
||||||
},
|
|
||||||
want: map[string]int{
|
|
||||||
"high": 20,
|
|
||||||
"default": 4,
|
|
||||||
"low": 1,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
{
|
|
||||||
input: map[string]int{
|
|
||||||
"default": 10,
|
|
||||||
},
|
|
||||||
want: map[string]int{
|
|
||||||
"default": 1,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
{
|
|
||||||
input: map[string]int{
|
|
||||||
"critical": 5,
|
|
||||||
"default": 1,
|
|
||||||
},
|
|
||||||
want: map[string]int{
|
|
||||||
"critical": 5,
|
|
||||||
"default": 1,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
{
|
|
||||||
input: map[string]int{
|
|
||||||
"critical": 6,
|
|
||||||
"default": 3,
|
|
||||||
"low": 0,
|
|
||||||
},
|
|
||||||
want: map[string]int{
|
|
||||||
"critical": 2,
|
|
||||||
"default": 1,
|
|
||||||
"low": 0,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
for _, tc := range tests {
|
|
||||||
got := normalizeQueueCfg(tc.input)
|
|
||||||
if diff := cmp.Diff(tc.want, got); diff != "" {
|
|
||||||
t.Errorf("normalizeQueueCfg(%v) = %v, want %v; (-want, +got):\n%s",
|
|
||||||
tc.input, got, tc.want, diff)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
@@ -7,7 +7,6 @@ package asynq
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"fmt"
|
"fmt"
|
||||||
"math/rand"
|
|
||||||
"sync"
|
"sync"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
@@ -24,11 +23,12 @@ func BenchmarkEndToEndSimple(b *testing.B) {
|
|||||||
DB: redisDB,
|
DB: redisDB,
|
||||||
}
|
}
|
||||||
client := NewClient(redis)
|
client := NewClient(redis)
|
||||||
bg := NewBackground(redis, &Config{
|
srv := NewServer(redis, Config{
|
||||||
Concurrency: 10,
|
Concurrency: 10,
|
||||||
RetryDelayFunc: func(n int, err error, t *Task) time.Duration {
|
RetryDelayFunc: func(n int, err error, t *Task) time.Duration {
|
||||||
return time.Second
|
return time.Second
|
||||||
},
|
},
|
||||||
|
LogLevel: testLogLevel,
|
||||||
})
|
})
|
||||||
// Create a bunch of tasks
|
// Create a bunch of tasks
|
||||||
for i := 0; i < count; i++ {
|
for i := 0; i < count; i++ {
|
||||||
@@ -46,11 +46,11 @@ func BenchmarkEndToEndSimple(b *testing.B) {
|
|||||||
}
|
}
|
||||||
b.StartTimer() // end setup
|
b.StartTimer() // end setup
|
||||||
|
|
||||||
bg.start(HandlerFunc(handler))
|
srv.Start(HandlerFunc(handler))
|
||||||
wg.Wait()
|
wg.Wait()
|
||||||
|
|
||||||
b.StopTimer() // begin teardown
|
b.StopTimer() // begin teardown
|
||||||
bg.stop()
|
srv.Stop()
|
||||||
b.StartTimer() // end teardown
|
b.StartTimer() // end teardown
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -60,18 +60,18 @@ func BenchmarkEndToEnd(b *testing.B) {
|
|||||||
const count = 100000
|
const count = 100000
|
||||||
for n := 0; n < b.N; n++ {
|
for n := 0; n < b.N; n++ {
|
||||||
b.StopTimer() // begin setup
|
b.StopTimer() // begin setup
|
||||||
rand.Seed(time.Now().UnixNano())
|
|
||||||
setup(b)
|
setup(b)
|
||||||
redis := &RedisClientOpt{
|
redis := &RedisClientOpt{
|
||||||
Addr: redisAddr,
|
Addr: redisAddr,
|
||||||
DB: redisDB,
|
DB: redisDB,
|
||||||
}
|
}
|
||||||
client := NewClient(redis)
|
client := NewClient(redis)
|
||||||
bg := NewBackground(redis, &Config{
|
srv := NewServer(redis, Config{
|
||||||
Concurrency: 10,
|
Concurrency: 10,
|
||||||
RetryDelayFunc: func(n int, err error, t *Task) time.Duration {
|
RetryDelayFunc: func(n int, err error, t *Task) time.Duration {
|
||||||
return time.Second
|
return time.Second
|
||||||
},
|
},
|
||||||
|
LogLevel: testLogLevel,
|
||||||
})
|
})
|
||||||
// Create a bunch of tasks
|
// Create a bunch of tasks
|
||||||
for i := 0; i < count; i++ {
|
for i := 0; i < count; i++ {
|
||||||
@@ -90,8 +90,16 @@ func BenchmarkEndToEnd(b *testing.B) {
|
|||||||
var wg sync.WaitGroup
|
var wg sync.WaitGroup
|
||||||
wg.Add(count * 2)
|
wg.Add(count * 2)
|
||||||
handler := func(ctx context.Context, t *Task) error {
|
handler := func(ctx context.Context, t *Task) error {
|
||||||
// randomly fail 1% of tasks
|
n, err := t.Payload.GetInt("data")
|
||||||
if rand.Intn(100) == 1 {
|
if err != nil {
|
||||||
|
b.Logf("internal error: %v", err)
|
||||||
|
}
|
||||||
|
retried, ok := GetRetryCount(ctx)
|
||||||
|
if !ok {
|
||||||
|
b.Logf("internal error: %v", err)
|
||||||
|
}
|
||||||
|
// Fail 1% of tasks for the first attempt.
|
||||||
|
if retried == 0 && n%100 == 0 {
|
||||||
return fmt.Errorf(":(")
|
return fmt.Errorf(":(")
|
||||||
}
|
}
|
||||||
wg.Done()
|
wg.Done()
|
||||||
@@ -99,11 +107,11 @@ func BenchmarkEndToEnd(b *testing.B) {
|
|||||||
}
|
}
|
||||||
b.StartTimer() // end setup
|
b.StartTimer() // end setup
|
||||||
|
|
||||||
bg.start(HandlerFunc(handler))
|
srv.Start(HandlerFunc(handler))
|
||||||
wg.Wait()
|
wg.Wait()
|
||||||
|
|
||||||
b.StopTimer() // begin teardown
|
b.StopTimer() // begin teardown
|
||||||
bg.stop()
|
srv.Stop()
|
||||||
b.StartTimer() // end teardown
|
b.StartTimer() // end teardown
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -124,13 +132,14 @@ func BenchmarkEndToEndMultipleQueues(b *testing.B) {
|
|||||||
DB: redisDB,
|
DB: redisDB,
|
||||||
}
|
}
|
||||||
client := NewClient(redis)
|
client := NewClient(redis)
|
||||||
bg := NewBackground(redis, &Config{
|
srv := NewServer(redis, Config{
|
||||||
Concurrency: 10,
|
Concurrency: 10,
|
||||||
Queues: map[string]int{
|
Queues: map[string]int{
|
||||||
"high": 6,
|
"high": 6,
|
||||||
"default": 3,
|
"default": 3,
|
||||||
"low": 1,
|
"low": 1,
|
||||||
},
|
},
|
||||||
|
LogLevel: testLogLevel,
|
||||||
})
|
})
|
||||||
// Create a bunch of tasks
|
// Create a bunch of tasks
|
||||||
for i := 0; i < highCount; i++ {
|
for i := 0; i < highCount; i++ {
|
||||||
@@ -160,11 +169,70 @@ func BenchmarkEndToEndMultipleQueues(b *testing.B) {
|
|||||||
}
|
}
|
||||||
b.StartTimer() // end setup
|
b.StartTimer() // end setup
|
||||||
|
|
||||||
bg.start(HandlerFunc(handler))
|
srv.Start(HandlerFunc(handler))
|
||||||
wg.Wait()
|
wg.Wait()
|
||||||
|
|
||||||
b.StopTimer() // begin teardown
|
b.StopTimer() // begin teardown
|
||||||
bg.stop()
|
srv.Stop()
|
||||||
|
b.StartTimer() // end teardown
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// E2E benchmark to check client enqueue operation performs correctly,
|
||||||
|
// while server is busy processing tasks.
|
||||||
|
func BenchmarkClientWhileServerRunning(b *testing.B) {
|
||||||
|
const count = 10000
|
||||||
|
for n := 0; n < b.N; n++ {
|
||||||
|
b.StopTimer() // begin setup
|
||||||
|
setup(b)
|
||||||
|
redis := &RedisClientOpt{
|
||||||
|
Addr: redisAddr,
|
||||||
|
DB: redisDB,
|
||||||
|
}
|
||||||
|
client := NewClient(redis)
|
||||||
|
srv := NewServer(redis, Config{
|
||||||
|
Concurrency: 10,
|
||||||
|
RetryDelayFunc: func(n int, err error, t *Task) time.Duration {
|
||||||
|
return time.Second
|
||||||
|
},
|
||||||
|
LogLevel: testLogLevel,
|
||||||
|
})
|
||||||
|
// Enqueue 10,000 tasks.
|
||||||
|
for i := 0; i < count; i++ {
|
||||||
|
t := NewTask(fmt.Sprintf("task%d", i), map[string]interface{}{"data": i})
|
||||||
|
if err := client.Enqueue(t); err != nil {
|
||||||
|
b.Fatalf("could not enqueue a task: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// Schedule 10,000 tasks.
|
||||||
|
for i := 0; i < count; i++ {
|
||||||
|
t := NewTask(fmt.Sprintf("scheduled%d", i), map[string]interface{}{"data": i})
|
||||||
|
if err := client.EnqueueAt(time.Now().Add(time.Second), t); err != nil {
|
||||||
|
b.Fatalf("could not enqueue a task: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
handler := func(ctx context.Context, t *Task) error {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
srv.Start(HandlerFunc(handler))
|
||||||
|
|
||||||
|
b.StartTimer() // end setup
|
||||||
|
|
||||||
|
b.Log("Starting enqueueing")
|
||||||
|
enqueued := 0
|
||||||
|
for enqueued < 100000 {
|
||||||
|
t := NewTask(fmt.Sprintf("enqueued%d", enqueued), map[string]interface{}{"data": enqueued})
|
||||||
|
if err := client.Enqueue(t); err != nil {
|
||||||
|
b.Logf("could not enqueue task %d: %v", enqueued, err)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
enqueued++
|
||||||
|
}
|
||||||
|
b.Logf("Finished enqueueing %d tasks", enqueued)
|
||||||
|
|
||||||
|
b.StopTimer() // begin teardown
|
||||||
|
srv.Stop()
|
||||||
b.StartTimer() // end teardown
|
b.StartTimer() // end teardown
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
81
client.go
@@ -9,6 +9,7 @@ import (
|
|||||||
"fmt"
|
"fmt"
|
||||||
"sort"
|
"sort"
|
||||||
"strings"
|
"strings"
|
||||||
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/hibiken/asynq/internal/base"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
@@ -23,13 +24,18 @@ import (
|
|||||||
//
|
//
|
||||||
// Clients are safe for concurrent use by multiple goroutines.
|
// Clients are safe for concurrent use by multiple goroutines.
|
||||||
type Client struct {
|
type Client struct {
|
||||||
rdb *rdb.RDB
|
mu sync.Mutex
|
||||||
|
opts map[string][]Option
|
||||||
|
rdb *rdb.RDB
|
||||||
}
|
}
|
||||||
|
|
||||||
// NewClient and returns a new Client given a redis connection option.
|
// NewClient and returns a new Client given a redis connection option.
|
||||||
func NewClient(r RedisConnOpt) *Client {
|
func NewClient(r RedisConnOpt) *Client {
|
||||||
rdb := rdb.NewRDB(createRedisClient(r))
|
rdb := rdb.NewRDB(createRedisClient(r))
|
||||||
return &Client{rdb}
|
return &Client{
|
||||||
|
opts: make(map[string][]Option),
|
||||||
|
rdb: rdb,
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Option specifies the task processing behavior.
|
// Option specifies the task processing behavior.
|
||||||
@@ -159,10 +165,19 @@ func serializePayload(payload map[string]interface{}) string {
|
|||||||
return b.String()
|
return b.String()
|
||||||
}
|
}
|
||||||
|
|
||||||
const (
|
// Default max retry count used if nothing is specified.
|
||||||
// Max retry count by default
|
const defaultMaxRetry = 25
|
||||||
defaultMaxRetry = 25
|
|
||||||
)
|
// SetDefaultOptions sets options to be used for a given task type.
|
||||||
|
// The argument opts specifies the behavior of task processing.
|
||||||
|
// If there are conflicting Option values the last one overrides others.
|
||||||
|
//
|
||||||
|
// Default options can be overridden by options passed at enqueue time.
|
||||||
|
func (c *Client) SetDefaultOptions(taskType string, opts ...Option) {
|
||||||
|
c.mu.Lock()
|
||||||
|
defer c.mu.Unlock()
|
||||||
|
c.opts[taskType] = opts
|
||||||
|
}
|
||||||
|
|
||||||
// EnqueueAt schedules task to be enqueued at the specified time.
|
// EnqueueAt schedules task to be enqueued at the specified time.
|
||||||
//
|
//
|
||||||
@@ -171,6 +186,40 @@ const (
|
|||||||
// The argument opts specifies the behavior of task processing.
|
// The argument opts specifies the behavior of task processing.
|
||||||
// If there are conflicting Option values the last one overrides others.
|
// If there are conflicting Option values the last one overrides others.
|
||||||
func (c *Client) EnqueueAt(t time.Time, task *Task, opts ...Option) error {
|
func (c *Client) EnqueueAt(t time.Time, task *Task, opts ...Option) error {
|
||||||
|
return c.enqueueAt(t, task, opts...)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Enqueue enqueues task to be processed immediately.
|
||||||
|
//
|
||||||
|
// Enqueue returns nil if the task is enqueued successfully, otherwise returns a non-nil error.
|
||||||
|
//
|
||||||
|
// The argument opts specifies the behavior of task processing.
|
||||||
|
// If there are conflicting Option values the last one overrides others.
|
||||||
|
func (c *Client) Enqueue(task *Task, opts ...Option) error {
|
||||||
|
return c.enqueueAt(time.Now(), task, opts...)
|
||||||
|
}
|
||||||
|
|
||||||
|
// EnqueueIn schedules task to be enqueued after the specified delay.
|
||||||
|
//
|
||||||
|
// EnqueueIn returns nil if the task is scheduled successfully, otherwise returns a non-nil error.
|
||||||
|
//
|
||||||
|
// The argument opts specifies the behavior of task processing.
|
||||||
|
// If there are conflicting Option values the last one overrides others.
|
||||||
|
func (c *Client) EnqueueIn(d time.Duration, task *Task, opts ...Option) error {
|
||||||
|
return c.enqueueAt(time.Now().Add(d), task, opts...)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Close closes the connection with redis server.
|
||||||
|
func (c *Client) Close() error {
|
||||||
|
return c.rdb.Close()
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *Client) enqueueAt(t time.Time, task *Task, opts ...Option) error {
|
||||||
|
c.mu.Lock()
|
||||||
|
defer c.mu.Unlock()
|
||||||
|
if defaults, ok := c.opts[task.Type]; ok {
|
||||||
|
opts = append(defaults, opts...)
|
||||||
|
}
|
||||||
opt := composeOptions(opts...)
|
opt := composeOptions(opts...)
|
||||||
msg := &base.TaskMessage{
|
msg := &base.TaskMessage{
|
||||||
ID: xid.New(),
|
ID: xid.New(),
|
||||||
@@ -194,26 +243,6 @@ func (c *Client) EnqueueAt(t time.Time, task *Task, opts ...Option) error {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
// Enqueue enqueues task to be processed immediately.
|
|
||||||
//
|
|
||||||
// Enqueue returns nil if the task is enqueued successfully, otherwise returns a non-nil error.
|
|
||||||
//
|
|
||||||
// The argument opts specifies the behavior of task processing.
|
|
||||||
// If there are conflicting Option values the last one overrides others.
|
|
||||||
func (c *Client) Enqueue(task *Task, opts ...Option) error {
|
|
||||||
return c.EnqueueAt(time.Now(), task, opts...)
|
|
||||||
}
|
|
||||||
|
|
||||||
// EnqueueIn schedules task to be enqueued after the specified delay.
|
|
||||||
//
|
|
||||||
// EnqueueIn returns nil if the task is scheduled successfully, otherwise returns a non-nil error.
|
|
||||||
//
|
|
||||||
// The argument opts specifies the behavior of task processing.
|
|
||||||
// If there are conflicting Option values the last one overrides others.
|
|
||||||
func (c *Client) EnqueueIn(d time.Duration, task *Task, opts ...Option) error {
|
|
||||||
return c.EnqueueAt(time.Now().Add(d), task, opts...)
|
|
||||||
}
|
|
||||||
|
|
||||||
func (c *Client) enqueue(msg *base.TaskMessage, uniqueTTL time.Duration) error {
|
func (c *Client) enqueue(msg *base.TaskMessage, uniqueTTL time.Duration) error {
|
||||||
if uniqueTTL > 0 {
|
if uniqueTTL > 0 {
|
||||||
return c.rdb.EnqueueUnique(msg, uniqueTTL)
|
return c.rdb.EnqueueUnique(msg, uniqueTTL)
|
||||||
|
@@ -15,6 +15,11 @@ import (
|
|||||||
"github.com/hibiken/asynq/internal/base"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
var (
|
||||||
|
noTimeout = time.Duration(0).String()
|
||||||
|
noDeadline = time.Time{}.Format(time.RFC3339)
|
||||||
|
)
|
||||||
|
|
||||||
func TestClientEnqueueAt(t *testing.T) {
|
func TestClientEnqueueAt(t *testing.T) {
|
||||||
r := setup(t)
|
r := setup(t)
|
||||||
client := NewClient(RedisClientOpt{
|
client := NewClient(RedisClientOpt{
|
||||||
@@ -27,9 +32,6 @@ func TestClientEnqueueAt(t *testing.T) {
|
|||||||
var (
|
var (
|
||||||
now = time.Now()
|
now = time.Now()
|
||||||
oneHourLater = now.Add(time.Hour)
|
oneHourLater = now.Add(time.Hour)
|
||||||
|
|
||||||
noTimeout = time.Duration(0).String()
|
|
||||||
noDeadline = time.Time{}.Format(time.RFC3339)
|
|
||||||
)
|
)
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
@@ -113,11 +115,6 @@ func TestClientEnqueue(t *testing.T) {
|
|||||||
|
|
||||||
task := NewTask("send_email", map[string]interface{}{"to": "customer@gmail.com", "from": "merchant@example.com"})
|
task := NewTask("send_email", map[string]interface{}{"to": "customer@gmail.com", "from": "merchant@example.com"})
|
||||||
|
|
||||||
var (
|
|
||||||
noTimeout = time.Duration(0).String()
|
|
||||||
noDeadline = time.Time{}.Format(time.RFC3339)
|
|
||||||
)
|
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
desc string
|
desc string
|
||||||
task *Task
|
task *Task
|
||||||
@@ -287,11 +284,6 @@ func TestClientEnqueueIn(t *testing.T) {
|
|||||||
|
|
||||||
task := NewTask("send_email", map[string]interface{}{"to": "customer@gmail.com", "from": "merchant@example.com"})
|
task := NewTask("send_email", map[string]interface{}{"to": "customer@gmail.com", "from": "merchant@example.com"})
|
||||||
|
|
||||||
var (
|
|
||||||
noTimeout = time.Duration(0).String()
|
|
||||||
noDeadline = time.Time{}.Format(time.RFC3339)
|
|
||||||
)
|
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
desc string
|
desc string
|
||||||
task *Task
|
task *Task
|
||||||
@@ -364,6 +356,86 @@ func TestClientEnqueueIn(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestClientDefaultOptions(t *testing.T) {
|
||||||
|
r := setup(t)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
desc string
|
||||||
|
defaultOpts []Option // options set at the client level.
|
||||||
|
opts []Option // options used at enqueue time.
|
||||||
|
task *Task
|
||||||
|
queue string // queue that the message should go into.
|
||||||
|
want *base.TaskMessage
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
desc: "With queue routing option",
|
||||||
|
defaultOpts: []Option{Queue("feed")},
|
||||||
|
opts: []Option{},
|
||||||
|
task: NewTask("feed:import", nil),
|
||||||
|
queue: "feed",
|
||||||
|
want: &base.TaskMessage{
|
||||||
|
Type: "feed:import",
|
||||||
|
Payload: nil,
|
||||||
|
Retry: defaultMaxRetry,
|
||||||
|
Queue: "feed",
|
||||||
|
Timeout: noTimeout,
|
||||||
|
Deadline: noDeadline,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "With multiple options",
|
||||||
|
defaultOpts: []Option{Queue("feed"), MaxRetry(5)},
|
||||||
|
opts: []Option{},
|
||||||
|
task: NewTask("feed:import", nil),
|
||||||
|
queue: "feed",
|
||||||
|
want: &base.TaskMessage{
|
||||||
|
Type: "feed:import",
|
||||||
|
Payload: nil,
|
||||||
|
Retry: 5,
|
||||||
|
Queue: "feed",
|
||||||
|
Timeout: noTimeout,
|
||||||
|
Deadline: noDeadline,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "With overriding options at enqueue time",
|
||||||
|
defaultOpts: []Option{Queue("feed"), MaxRetry(5)},
|
||||||
|
opts: []Option{Queue("critical")},
|
||||||
|
task: NewTask("feed:import", nil),
|
||||||
|
queue: "critical",
|
||||||
|
want: &base.TaskMessage{
|
||||||
|
Type: "feed:import",
|
||||||
|
Payload: nil,
|
||||||
|
Retry: 5,
|
||||||
|
Queue: "critical",
|
||||||
|
Timeout: noTimeout,
|
||||||
|
Deadline: noDeadline,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
h.FlushDB(t, r)
|
||||||
|
c := NewClient(RedisClientOpt{Addr: redisAddr, DB: redisDB})
|
||||||
|
c.SetDefaultOptions(tc.task.Type, tc.defaultOpts...)
|
||||||
|
err := c.Enqueue(tc.task, tc.opts...)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
enqueued := h.GetEnqueuedMessages(t, r, tc.queue)
|
||||||
|
if len(enqueued) != 1 {
|
||||||
|
t.Errorf("%s;\nexpected queue %q to have one message; got %d messages in the queue.",
|
||||||
|
tc.desc, tc.queue, len(enqueued))
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
got := enqueued[0]
|
||||||
|
if diff := cmp.Diff(tc.want, got, h.IgnoreIDOpt); diff != "" {
|
||||||
|
t.Errorf("%s;\nmismatch found in enqueued task message; (-want,+got)\n%s",
|
||||||
|
tc.desc, diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestUniqueKey(t *testing.T) {
|
func TestUniqueKey(t *testing.T) {
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
desc string
|
desc string
|
||||||
|
85
context.go
Normal file
@@ -0,0 +1,85 @@
|
|||||||
|
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
||||||
|
// Use of this source code is governed by a MIT license
|
||||||
|
// that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package asynq
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/hibiken/asynq/internal/base"
|
||||||
|
)
|
||||||
|
|
||||||
|
// A taskMetadata holds task scoped data to put in context.
|
||||||
|
type taskMetadata struct {
|
||||||
|
id string
|
||||||
|
maxRetry int
|
||||||
|
retryCount int
|
||||||
|
}
|
||||||
|
|
||||||
|
// ctxKey type is unexported to prevent collisions with context keys defined in
|
||||||
|
// other packages.
|
||||||
|
type ctxKey int
|
||||||
|
|
||||||
|
// metadataCtxKey is the context key for the task metadata.
|
||||||
|
// Its value of zero is arbitrary.
|
||||||
|
const metadataCtxKey ctxKey = 0
|
||||||
|
|
||||||
|
// createContext returns a context and cancel function for a given task message.
|
||||||
|
func createContext(msg *base.TaskMessage) (ctx context.Context, cancel context.CancelFunc) {
|
||||||
|
metadata := taskMetadata{
|
||||||
|
id: msg.ID.String(),
|
||||||
|
maxRetry: msg.Retry,
|
||||||
|
retryCount: msg.Retried,
|
||||||
|
}
|
||||||
|
ctx = context.WithValue(context.Background(), metadataCtxKey, metadata)
|
||||||
|
timeout, err := time.ParseDuration(msg.Timeout)
|
||||||
|
if err == nil && timeout != 0 {
|
||||||
|
ctx, cancel = context.WithTimeout(ctx, timeout)
|
||||||
|
}
|
||||||
|
deadline, err := time.Parse(time.RFC3339, msg.Deadline)
|
||||||
|
if err == nil && !deadline.IsZero() {
|
||||||
|
ctx, cancel = context.WithDeadline(ctx, deadline)
|
||||||
|
}
|
||||||
|
if cancel == nil {
|
||||||
|
ctx, cancel = context.WithCancel(ctx)
|
||||||
|
}
|
||||||
|
return ctx, cancel
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetTaskID extracts a task ID from a context, if any.
|
||||||
|
//
|
||||||
|
// ID of a task is guaranteed to be unique.
|
||||||
|
// ID of a task doesn't change if the task is being retried.
|
||||||
|
func GetTaskID(ctx context.Context) (id string, ok bool) {
|
||||||
|
metadata, ok := ctx.Value(metadataCtxKey).(taskMetadata)
|
||||||
|
if !ok {
|
||||||
|
return "", false
|
||||||
|
}
|
||||||
|
return metadata.id, true
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetRetryCount extracts retry count from a context, if any.
|
||||||
|
//
|
||||||
|
// Return value n indicates the number of times associated task has been
|
||||||
|
// retried so far.
|
||||||
|
func GetRetryCount(ctx context.Context) (n int, ok bool) {
|
||||||
|
metadata, ok := ctx.Value(metadataCtxKey).(taskMetadata)
|
||||||
|
if !ok {
|
||||||
|
return 0, false
|
||||||
|
}
|
||||||
|
return metadata.retryCount, true
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetMaxRetry extracts maximum retry from a context, if any.
|
||||||
|
//
|
||||||
|
// Return value n indicates the maximum number of times the assoicated task
|
||||||
|
// can be retried if ProcessTask returns a non-nil error.
|
||||||
|
func GetMaxRetry(ctx context.Context) (n int, ok bool) {
|
||||||
|
metadata, ok := ctx.Value(metadataCtxKey).(taskMetadata)
|
||||||
|
if !ok {
|
||||||
|
return 0, false
|
||||||
|
}
|
||||||
|
return metadata.maxRetry, true
|
||||||
|
}
|
157
context_test.go
Normal file
@@ -0,0 +1,157 @@
|
|||||||
|
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
||||||
|
// Use of this source code is governed by a MIT license
|
||||||
|
// that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package asynq
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/google/go-cmp/cmp"
|
||||||
|
"github.com/google/go-cmp/cmp/cmpopts"
|
||||||
|
"github.com/hibiken/asynq/internal/base"
|
||||||
|
"github.com/rs/xid"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestCreateContextWithTimeRestrictions(t *testing.T) {
|
||||||
|
var (
|
||||||
|
noTimeout = time.Duration(0)
|
||||||
|
noDeadline = time.Time{}
|
||||||
|
)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
desc string
|
||||||
|
timeout time.Duration
|
||||||
|
deadline time.Time
|
||||||
|
wantDeadline time.Time
|
||||||
|
}{
|
||||||
|
{"only with timeout", 10 * time.Second, noDeadline, time.Now().Add(10 * time.Second)},
|
||||||
|
{"only with deadline", noTimeout, time.Now().Add(time.Hour), time.Now().Add(time.Hour)},
|
||||||
|
{"with timeout and deadline (timeout < deadline)", 10 * time.Second, time.Now().Add(time.Hour), time.Now().Add(10 * time.Second)},
|
||||||
|
{"with timeout and deadline (timeout > deadline)", 10 * time.Minute, time.Now().Add(30 * time.Second), time.Now().Add(30 * time.Second)},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
msg := &base.TaskMessage{
|
||||||
|
Type: "something",
|
||||||
|
ID: xid.New(),
|
||||||
|
Timeout: tc.timeout.String(),
|
||||||
|
Deadline: tc.deadline.Format(time.RFC3339),
|
||||||
|
}
|
||||||
|
|
||||||
|
ctx, cancel := createContext(msg)
|
||||||
|
|
||||||
|
select {
|
||||||
|
case x := <-ctx.Done():
|
||||||
|
t.Errorf("%s: <-ctx.Done() == %v, want nothing (it should block)", tc.desc, x)
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
|
||||||
|
got, ok := ctx.Deadline()
|
||||||
|
if !ok {
|
||||||
|
t.Errorf("%s: ctx.Deadline() returned false, want deadline to be set", tc.desc)
|
||||||
|
}
|
||||||
|
if !cmp.Equal(tc.wantDeadline, got, cmpopts.EquateApproxTime(time.Second)) {
|
||||||
|
t.Errorf("%s: ctx.Deadline() returned %v, want %v", tc.desc, got, tc.wantDeadline)
|
||||||
|
}
|
||||||
|
|
||||||
|
cancel()
|
||||||
|
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
default:
|
||||||
|
t.Errorf("ctx.Done() blocked, want it to be non-blocking")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestCreateContextWithoutTimeRestrictions(t *testing.T) {
|
||||||
|
msg := &base.TaskMessage{
|
||||||
|
Type: "something",
|
||||||
|
ID: xid.New(),
|
||||||
|
Timeout: time.Duration(0).String(), // zero value to indicate no timeout
|
||||||
|
Deadline: time.Time{}.Format(time.RFC3339), // zero value to indicate no deadline
|
||||||
|
}
|
||||||
|
|
||||||
|
ctx, cancel := createContext(msg)
|
||||||
|
|
||||||
|
select {
|
||||||
|
case x := <-ctx.Done():
|
||||||
|
t.Errorf("<-ctx.Done() == %v, want nothing (it should block)", x)
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
|
||||||
|
_, ok := ctx.Deadline()
|
||||||
|
if ok {
|
||||||
|
t.Error("ctx.Deadline() returned true, want deadline to not be set")
|
||||||
|
}
|
||||||
|
|
||||||
|
cancel()
|
||||||
|
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
default:
|
||||||
|
t.Error("ctx.Done() blocked, want it to be non-blocking")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestGetTaskMetadataFromContext(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
desc string
|
||||||
|
msg *base.TaskMessage
|
||||||
|
}{
|
||||||
|
{"with zero retried message", &base.TaskMessage{Type: "something", ID: xid.New(), Retry: 25, Retried: 0}},
|
||||||
|
{"with non-zero retried message", &base.TaskMessage{Type: "something", ID: xid.New(), Retry: 10, Retried: 5}},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
ctx, _ := createContext(tc.msg)
|
||||||
|
|
||||||
|
id, ok := GetTaskID(ctx)
|
||||||
|
if !ok {
|
||||||
|
t.Errorf("%s: GetTaskID(ctx) returned ok == false", tc.desc)
|
||||||
|
}
|
||||||
|
if ok && id != tc.msg.ID.String() {
|
||||||
|
t.Errorf("%s: GetTaskID(ctx) returned id == %q, want %q", tc.desc, id, tc.msg.ID.String())
|
||||||
|
}
|
||||||
|
|
||||||
|
retried, ok := GetRetryCount(ctx)
|
||||||
|
if !ok {
|
||||||
|
t.Errorf("%s: GetRetryCount(ctx) returned ok == false", tc.desc)
|
||||||
|
}
|
||||||
|
if ok && retried != tc.msg.Retried {
|
||||||
|
t.Errorf("%s: GetRetryCount(ctx) returned n == %d want %d", tc.desc, retried, tc.msg.Retried)
|
||||||
|
}
|
||||||
|
|
||||||
|
maxRetry, ok := GetMaxRetry(ctx)
|
||||||
|
if !ok {
|
||||||
|
t.Errorf("%s: GetMaxRetry(ctx) returned ok == false", tc.desc)
|
||||||
|
}
|
||||||
|
if ok && maxRetry != tc.msg.Retry {
|
||||||
|
t.Errorf("%s: GetMaxRetry(ctx) returned n == %d want %d", tc.desc, maxRetry, tc.msg.Retry)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestGetTaskMetadataFromContextError(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
desc string
|
||||||
|
ctx context.Context
|
||||||
|
}{
|
||||||
|
{"with background context", context.Background()},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
if _, ok := GetTaskID(tc.ctx); ok {
|
||||||
|
t.Errorf("%s: GetTaskID(ctx) returned ok == true", tc.desc)
|
||||||
|
}
|
||||||
|
if _, ok := GetRetryCount(tc.ctx); ok {
|
||||||
|
t.Errorf("%s: GetRetryCount(ctx) returned ok == true", tc.desc)
|
||||||
|
}
|
||||||
|
if _, ok := GetMaxRetry(tc.ctx); ok {
|
||||||
|
t.Errorf("%s: GetMaxRetry(ctx) returned ok == true", tc.desc)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
12
doc.go
@@ -14,7 +14,7 @@ specify the options using one of RedisConnOpt types.
|
|||||||
DB: 3,
|
DB: 3,
|
||||||
}
|
}
|
||||||
|
|
||||||
The Client is used to register a task to be processed at the specified time.
|
The Client is used to enqueue a task to be processed at the specified time.
|
||||||
|
|
||||||
Task is created with two parameters: its type and payload.
|
Task is created with two parameters: its type and payload.
|
||||||
|
|
||||||
@@ -27,18 +27,18 @@ Task is created with two parameters: its type and payload.
|
|||||||
// Enqueue the task to be processed immediately.
|
// Enqueue the task to be processed immediately.
|
||||||
err := client.Enqueue(t)
|
err := client.Enqueue(t)
|
||||||
|
|
||||||
// Schedule the task to be processed in one minute.
|
// Schedule the task to be processed after one minute.
|
||||||
err = client.EnqueueIn(time.Minute, t)
|
err = client.EnqueueIn(time.Minute, t)
|
||||||
|
|
||||||
The Background is used to run the background task processing with a given
|
The Server is used to run the background task processing with a given
|
||||||
handler.
|
handler.
|
||||||
bg := asynq.NewBackground(redis, &asynq.Config{
|
srv := asynq.NewServer(redis, asynq.Config{
|
||||||
Concurrency: 10,
|
Concurrency: 10,
|
||||||
})
|
})
|
||||||
|
|
||||||
bg.Run(handler)
|
srv.Run(handler)
|
||||||
|
|
||||||
Handler is an interface with one method ProcessTask which
|
Handler is an interface type with a method which
|
||||||
takes a task and returns an error. Handler should return nil if
|
takes a task and returns an error. Handler should return nil if
|
||||||
the processing is successful, otherwise return a non-nil error.
|
the processing is successful, otherwise return a non-nil error.
|
||||||
If handler panics or returns a non-nil error, the task will be retried in the future.
|
If handler panics or returns a non-nil error, the task will be retried in the future.
|
||||||
|
Before Width: | Height: | Size: 1.5 MiB After Width: | Height: | Size: 1.5 MiB |
Before Width: | Height: | Size: 582 KiB After Width: | Height: | Size: 582 KiB |
Before Width: | Height: | Size: 1.5 MiB After Width: | Height: | Size: 1.5 MiB |
BIN
docs/assets/overview.png
Normal file
After Width: | Height: | Size: 63 KiB |
95
example_test.go
Normal file
@@ -0,0 +1,95 @@
|
|||||||
|
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
||||||
|
// Use of this source code is governed by a MIT license
|
||||||
|
// that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package asynq_test
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"log"
|
||||||
|
"os"
|
||||||
|
"os/signal"
|
||||||
|
|
||||||
|
"github.com/hibiken/asynq"
|
||||||
|
"golang.org/x/sys/unix"
|
||||||
|
)
|
||||||
|
|
||||||
|
func ExampleServer_Run() {
|
||||||
|
srv := asynq.NewServer(
|
||||||
|
asynq.RedisClientOpt{Addr: ":6379"},
|
||||||
|
asynq.Config{Concurrency: 20},
|
||||||
|
)
|
||||||
|
|
||||||
|
h := asynq.NewServeMux()
|
||||||
|
// ... Register handlers
|
||||||
|
|
||||||
|
// Run blocks and waits for os signal to terminate the program.
|
||||||
|
if err := srv.Run(h); err != nil {
|
||||||
|
log.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func ExampleServer_Stop() {
|
||||||
|
srv := asynq.NewServer(
|
||||||
|
asynq.RedisClientOpt{Addr: ":6379"},
|
||||||
|
asynq.Config{Concurrency: 20},
|
||||||
|
)
|
||||||
|
|
||||||
|
h := asynq.NewServeMux()
|
||||||
|
// ... Register handlers
|
||||||
|
|
||||||
|
if err := srv.Start(h); err != nil {
|
||||||
|
log.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
sigs := make(chan os.Signal, 1)
|
||||||
|
signal.Notify(sigs, unix.SIGTERM, unix.SIGINT)
|
||||||
|
<-sigs // wait for termination signal
|
||||||
|
|
||||||
|
srv.Stop()
|
||||||
|
}
|
||||||
|
|
||||||
|
func ExampleServer_Quiet() {
|
||||||
|
srv := asynq.NewServer(
|
||||||
|
asynq.RedisClientOpt{Addr: ":6379"},
|
||||||
|
asynq.Config{Concurrency: 20},
|
||||||
|
)
|
||||||
|
|
||||||
|
h := asynq.NewServeMux()
|
||||||
|
// ... Register handlers
|
||||||
|
|
||||||
|
if err := srv.Start(h); err != nil {
|
||||||
|
log.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
sigs := make(chan os.Signal, 1)
|
||||||
|
signal.Notify(sigs, unix.SIGTERM, unix.SIGINT, unix.SIGTSTP)
|
||||||
|
// Handle SIGTERM, SIGINT to exit the program.
|
||||||
|
// Handle SIGTSTP to stop processing new tasks.
|
||||||
|
for {
|
||||||
|
s := <-sigs
|
||||||
|
if s == unix.SIGTSTP {
|
||||||
|
srv.Quiet() // stop processing new tasks
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
break
|
||||||
|
}
|
||||||
|
|
||||||
|
srv.Stop()
|
||||||
|
}
|
||||||
|
|
||||||
|
func ExampleParseRedisURI() {
|
||||||
|
rconn, err := asynq.ParseRedisURI("redis://localhost:6379/10")
|
||||||
|
if err != nil {
|
||||||
|
log.Fatal(err)
|
||||||
|
}
|
||||||
|
r, ok := rconn.(asynq.RedisClientOpt)
|
||||||
|
if !ok {
|
||||||
|
log.Fatal("unexpected type")
|
||||||
|
}
|
||||||
|
fmt.Println(r.Addr)
|
||||||
|
fmt.Println(r.DB)
|
||||||
|
// Output:
|
||||||
|
// localhost:6379
|
||||||
|
// 10
|
||||||
|
}
|
2
go.mod
@@ -8,7 +8,7 @@ require (
|
|||||||
github.com/rs/xid v1.2.1
|
github.com/rs/xid v1.2.1
|
||||||
github.com/spf13/cast v1.3.1
|
github.com/spf13/cast v1.3.1
|
||||||
go.uber.org/goleak v0.10.0
|
go.uber.org/goleak v0.10.0
|
||||||
golang.org/x/sys v0.0.0-20191204072324-ce4227a45e2e // indirect
|
golang.org/x/sys v0.0.0-20191204072324-ce4227a45e2e
|
||||||
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
|
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
|
||||||
gopkg.in/yaml.v2 v2.2.7 // indirect
|
gopkg.in/yaml.v2 v2.2.7 // indirect
|
||||||
)
|
)
|
||||||
|
130
heartbeat.go
@@ -5,69 +5,161 @@
|
|||||||
package asynq
|
package asynq
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"os"
|
||||||
"sync"
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/hibiken/asynq/internal/base"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
"github.com/hibiken/asynq/internal/rdb"
|
"github.com/hibiken/asynq/internal/log"
|
||||||
|
"github.com/rs/xid"
|
||||||
)
|
)
|
||||||
|
|
||||||
// heartbeater is responsible for writing process info to redis periodically to
|
// heartbeater is responsible for writing process info to redis periodically to
|
||||||
// indicate that the background worker process is up.
|
// indicate that the background worker process is up.
|
||||||
type heartbeater struct {
|
type heartbeater struct {
|
||||||
logger Logger
|
logger *log.Logger
|
||||||
rdb *rdb.RDB
|
broker base.Broker
|
||||||
|
|
||||||
ps *base.ProcessState
|
|
||||||
|
|
||||||
// channel to communicate back to the long running "heartbeater" goroutine.
|
// channel to communicate back to the long running "heartbeater" goroutine.
|
||||||
done chan struct{}
|
done chan struct{}
|
||||||
|
|
||||||
// interval between heartbeats.
|
// interval between heartbeats.
|
||||||
interval time.Duration
|
interval time.Duration
|
||||||
|
|
||||||
|
// following fields are initialized at construction time and are immutable.
|
||||||
|
host string
|
||||||
|
pid int
|
||||||
|
serverID string
|
||||||
|
concurrency int
|
||||||
|
queues map[string]int
|
||||||
|
strictPriority bool
|
||||||
|
|
||||||
|
// following fields are mutable and should be accessed only by the
|
||||||
|
// heartbeater goroutine. In other words, confine these variables
|
||||||
|
// to this goroutine only.
|
||||||
|
started time.Time
|
||||||
|
workers map[string]workerStat
|
||||||
|
|
||||||
|
// status is shared with other goroutine but is concurrency safe.
|
||||||
|
status *base.ServerStatus
|
||||||
|
|
||||||
|
// channels to receive updates on active workers.
|
||||||
|
starting <-chan *base.TaskMessage
|
||||||
|
finished <-chan *base.TaskMessage
|
||||||
}
|
}
|
||||||
|
|
||||||
func newHeartbeater(l Logger, rdb *rdb.RDB, ps *base.ProcessState, interval time.Duration) *heartbeater {
|
type heartbeaterParams struct {
|
||||||
|
logger *log.Logger
|
||||||
|
broker base.Broker
|
||||||
|
interval time.Duration
|
||||||
|
concurrency int
|
||||||
|
queues map[string]int
|
||||||
|
strictPriority bool
|
||||||
|
status *base.ServerStatus
|
||||||
|
starting <-chan *base.TaskMessage
|
||||||
|
finished <-chan *base.TaskMessage
|
||||||
|
}
|
||||||
|
|
||||||
|
func newHeartbeater(params heartbeaterParams) *heartbeater {
|
||||||
|
host, err := os.Hostname()
|
||||||
|
if err != nil {
|
||||||
|
host = "unknown-host"
|
||||||
|
}
|
||||||
|
|
||||||
return &heartbeater{
|
return &heartbeater{
|
||||||
logger: l,
|
logger: params.logger,
|
||||||
rdb: rdb,
|
broker: params.broker,
|
||||||
ps: ps,
|
|
||||||
done: make(chan struct{}),
|
done: make(chan struct{}),
|
||||||
interval: interval,
|
interval: params.interval,
|
||||||
|
|
||||||
|
host: host,
|
||||||
|
pid: os.Getpid(),
|
||||||
|
serverID: xid.New().String(),
|
||||||
|
concurrency: params.concurrency,
|
||||||
|
queues: params.queues,
|
||||||
|
strictPriority: params.strictPriority,
|
||||||
|
|
||||||
|
status: params.status,
|
||||||
|
workers: make(map[string]workerStat),
|
||||||
|
starting: params.starting,
|
||||||
|
finished: params.finished,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (h *heartbeater) terminate() {
|
func (h *heartbeater) terminate() {
|
||||||
h.logger.Info("Heartbeater shutting down...")
|
h.logger.Debug("Heartbeater shutting down...")
|
||||||
// Signal the heartbeater goroutine to stop.
|
// Signal the heartbeater goroutine to stop.
|
||||||
h.done <- struct{}{}
|
h.done <- struct{}{}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// A workerStat records the message a worker is working on
|
||||||
|
// and the time the worker has started processing the message.
|
||||||
|
type workerStat struct {
|
||||||
|
started time.Time
|
||||||
|
msg *base.TaskMessage
|
||||||
|
}
|
||||||
|
|
||||||
func (h *heartbeater) start(wg *sync.WaitGroup) {
|
func (h *heartbeater) start(wg *sync.WaitGroup) {
|
||||||
h.ps.SetStarted(time.Now())
|
|
||||||
h.ps.SetStatus(base.StatusRunning)
|
|
||||||
wg.Add(1)
|
wg.Add(1)
|
||||||
go func() {
|
go func() {
|
||||||
defer wg.Done()
|
defer wg.Done()
|
||||||
|
|
||||||
|
h.started = time.Now()
|
||||||
|
|
||||||
h.beat()
|
h.beat()
|
||||||
|
|
||||||
|
timer := time.NewTimer(h.interval)
|
||||||
for {
|
for {
|
||||||
select {
|
select {
|
||||||
case <-h.done:
|
case <-h.done:
|
||||||
h.rdb.ClearProcessState(h.ps)
|
h.broker.ClearServerState(h.host, h.pid, h.serverID)
|
||||||
h.logger.Info("Heartbeater done")
|
h.logger.Debug("Heartbeater done")
|
||||||
|
timer.Stop()
|
||||||
return
|
return
|
||||||
case <-time.After(h.interval):
|
|
||||||
|
case <-timer.C:
|
||||||
h.beat()
|
h.beat()
|
||||||
|
timer.Reset(h.interval)
|
||||||
|
|
||||||
|
case msg := <-h.starting:
|
||||||
|
h.workers[msg.ID.String()] = workerStat{time.Now(), msg}
|
||||||
|
|
||||||
|
case msg := <-h.finished:
|
||||||
|
delete(h.workers, msg.ID.String())
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}()
|
}()
|
||||||
}
|
}
|
||||||
|
|
||||||
func (h *heartbeater) beat() {
|
func (h *heartbeater) beat() {
|
||||||
|
info := base.ServerInfo{
|
||||||
|
Host: h.host,
|
||||||
|
PID: h.pid,
|
||||||
|
ServerID: h.serverID,
|
||||||
|
Concurrency: h.concurrency,
|
||||||
|
Queues: h.queues,
|
||||||
|
StrictPriority: h.strictPriority,
|
||||||
|
Status: h.status.String(),
|
||||||
|
Started: h.started,
|
||||||
|
ActiveWorkerCount: len(h.workers),
|
||||||
|
}
|
||||||
|
|
||||||
|
var ws []*base.WorkerInfo
|
||||||
|
for id, stat := range h.workers {
|
||||||
|
ws = append(ws, &base.WorkerInfo{
|
||||||
|
Host: h.host,
|
||||||
|
PID: h.pid,
|
||||||
|
ID: id,
|
||||||
|
Type: stat.msg.Type,
|
||||||
|
Queue: stat.msg.Queue,
|
||||||
|
Payload: stat.msg.Payload,
|
||||||
|
Started: stat.started,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
// Note: Set TTL to be long enough so that it won't expire before we write again
|
// Note: Set TTL to be long enough so that it won't expire before we write again
|
||||||
// and short enough to expire quickly once the process is shut down or killed.
|
// and short enough to expire quickly once the process is shut down or killed.
|
||||||
err := h.rdb.WriteProcessState(h.ps, h.interval*2)
|
if err := h.broker.WriteServerState(&info, ws, h.interval*2); err != nil {
|
||||||
if err != nil {
|
h.logger.Errorf("could not write server state data: %v", err)
|
||||||
h.logger.Error("could not write heartbeat data: %v", err)
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@@ -14,6 +14,7 @@ import (
|
|||||||
h "github.com/hibiken/asynq/internal/asynqtest"
|
h "github.com/hibiken/asynq/internal/asynqtest"
|
||||||
"github.com/hibiken/asynq/internal/base"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
"github.com/hibiken/asynq/internal/rdb"
|
"github.com/hibiken/asynq/internal/rdb"
|
||||||
|
"github.com/hibiken/asynq/internal/testbroker"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestHeartbeater(t *testing.T) {
|
func TestHeartbeater(t *testing.T) {
|
||||||
@@ -31,17 +32,33 @@ func TestHeartbeater(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
timeCmpOpt := cmpopts.EquateApproxTime(10 * time.Millisecond)
|
timeCmpOpt := cmpopts.EquateApproxTime(10 * time.Millisecond)
|
||||||
ignoreOpt := cmpopts.IgnoreUnexported(base.ProcessInfo{})
|
ignoreOpt := cmpopts.IgnoreUnexported(base.ServerInfo{})
|
||||||
|
ignoreFieldOpt := cmpopts.IgnoreFields(base.ServerInfo{}, "ServerID")
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
h.FlushDB(t, r)
|
h.FlushDB(t, r)
|
||||||
|
|
||||||
state := base.NewProcessState(tc.host, tc.pid, tc.concurrency, tc.queues, false)
|
status := base.NewServerStatus(base.StatusIdle)
|
||||||
hb := newHeartbeater(testLogger, rdbClient, state, tc.interval)
|
hb := newHeartbeater(heartbeaterParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: rdbClient,
|
||||||
|
interval: tc.interval,
|
||||||
|
concurrency: tc.concurrency,
|
||||||
|
queues: tc.queues,
|
||||||
|
strictPriority: false,
|
||||||
|
status: status,
|
||||||
|
starting: make(chan *base.TaskMessage),
|
||||||
|
finished: make(chan *base.TaskMessage),
|
||||||
|
})
|
||||||
|
|
||||||
|
// Change host and pid fields for testing purpose.
|
||||||
|
hb.host = tc.host
|
||||||
|
hb.pid = tc.pid
|
||||||
|
|
||||||
|
status.Set(base.StatusRunning)
|
||||||
var wg sync.WaitGroup
|
var wg sync.WaitGroup
|
||||||
hb.start(&wg)
|
hb.start(&wg)
|
||||||
|
|
||||||
want := &base.ProcessInfo{
|
want := &base.ServerInfo{
|
||||||
Host: tc.host,
|
Host: tc.host,
|
||||||
PID: tc.pid,
|
PID: tc.pid,
|
||||||
Queues: tc.queues,
|
Queues: tc.queues,
|
||||||
@@ -53,47 +70,47 @@ func TestHeartbeater(t *testing.T) {
|
|||||||
// allow for heartbeater to write to redis
|
// allow for heartbeater to write to redis
|
||||||
time.Sleep(tc.interval * 2)
|
time.Sleep(tc.interval * 2)
|
||||||
|
|
||||||
ps, err := rdbClient.ListProcesses()
|
ss, err := rdbClient.ListServers()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Errorf("could not read process status from redis: %v", err)
|
t.Errorf("could not read server info from redis: %v", err)
|
||||||
hb.terminate()
|
hb.terminate()
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
if len(ps) != 1 {
|
if len(ss) != 1 {
|
||||||
t.Errorf("(*RDB).ListProcesses returned %d process info, want 1", len(ps))
|
t.Errorf("(*RDB).ListServers returned %d process info, want 1", len(ss))
|
||||||
hb.terminate()
|
hb.terminate()
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
if diff := cmp.Diff(want, ps[0], timeCmpOpt, ignoreOpt); diff != "" {
|
if diff := cmp.Diff(want, ss[0], timeCmpOpt, ignoreOpt, ignoreFieldOpt); diff != "" {
|
||||||
t.Errorf("redis stored process status %+v, want %+v; (-want, +got)\n%s", ps[0], want, diff)
|
t.Errorf("redis stored process status %+v, want %+v; (-want, +got)\n%s", ss[0], want, diff)
|
||||||
hb.terminate()
|
hb.terminate()
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
// status change
|
// status change
|
||||||
state.SetStatus(base.StatusStopped)
|
status.Set(base.StatusStopped)
|
||||||
|
|
||||||
// allow for heartbeater to write to redis
|
// allow for heartbeater to write to redis
|
||||||
time.Sleep(tc.interval * 2)
|
time.Sleep(tc.interval * 2)
|
||||||
|
|
||||||
want.Status = "stopped"
|
want.Status = "stopped"
|
||||||
ps, err = rdbClient.ListProcesses()
|
ss, err = rdbClient.ListServers()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Errorf("could not read process status from redis: %v", err)
|
t.Errorf("could not read process status from redis: %v", err)
|
||||||
hb.terminate()
|
hb.terminate()
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
if len(ps) != 1 {
|
if len(ss) != 1 {
|
||||||
t.Errorf("(*RDB).ListProcesses returned %d process info, want 1", len(ps))
|
t.Errorf("(*RDB).ListProcesses returned %d process info, want 1", len(ss))
|
||||||
hb.terminate()
|
hb.terminate()
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
if diff := cmp.Diff(want, ps[0], timeCmpOpt, ignoreOpt); diff != "" {
|
if diff := cmp.Diff(want, ss[0], timeCmpOpt, ignoreOpt, ignoreFieldOpt); diff != "" {
|
||||||
t.Errorf("redis stored process status %+v, want %+v; (-want, +got)\n%s", ps[0], want, diff)
|
t.Errorf("redis stored process status %+v, want %+v; (-want, +got)\n%s", ss[0], want, diff)
|
||||||
hb.terminate()
|
hb.terminate()
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
@@ -101,3 +118,35 @@ func TestHeartbeater(t *testing.T) {
|
|||||||
hb.terminate()
|
hb.terminate()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestHeartbeaterWithRedisDown(t *testing.T) {
|
||||||
|
// Make sure that heartbeater goroutine doesn't panic
|
||||||
|
// if it cannot connect to redis.
|
||||||
|
defer func() {
|
||||||
|
if r := recover(); r != nil {
|
||||||
|
t.Errorf("panic occurred: %v", r)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
r := rdb.NewRDB(setup(t))
|
||||||
|
testBroker := testbroker.NewTestBroker(r)
|
||||||
|
hb := newHeartbeater(heartbeaterParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: testBroker,
|
||||||
|
interval: time.Second,
|
||||||
|
concurrency: 10,
|
||||||
|
queues: map[string]int{"default": 1},
|
||||||
|
strictPriority: false,
|
||||||
|
status: base.NewServerStatus(base.StatusRunning),
|
||||||
|
starting: make(chan *base.TaskMessage),
|
||||||
|
finished: make(chan *base.TaskMessage),
|
||||||
|
})
|
||||||
|
|
||||||
|
testBroker.Sleep()
|
||||||
|
var wg sync.WaitGroup
|
||||||
|
hb.start(&wg)
|
||||||
|
|
||||||
|
// wait for heartbeater to try writing data to redis
|
||||||
|
time.Sleep(2 * time.Second)
|
||||||
|
|
||||||
|
hb.terminate()
|
||||||
|
}
|
||||||
|
@@ -41,9 +41,9 @@ var SortZSetEntryOpt = cmp.Transformer("SortZSetEntries", func(in []ZSetEntry) [
|
|||||||
return out
|
return out
|
||||||
})
|
})
|
||||||
|
|
||||||
// SortProcessInfoOpt is a cmp.Option to sort base.ProcessInfo for comparing slice of process info.
|
// SortServerInfoOpt is a cmp.Option to sort base.ServerInfo for comparing slice of process info.
|
||||||
var SortProcessInfoOpt = cmp.Transformer("SortProcessInfo", func(in []*base.ProcessInfo) []*base.ProcessInfo {
|
var SortServerInfoOpt = cmp.Transformer("SortServerInfo", func(in []*base.ServerInfo) []*base.ServerInfo {
|
||||||
out := append([]*base.ProcessInfo(nil), in...) // Copy input to avoid mutating it
|
out := append([]*base.ServerInfo(nil), in...) // Copy input to avoid mutating it
|
||||||
sort.Slice(out, func(i, j int) bool {
|
sort.Slice(out, func(i, j int) bool {
|
||||||
if out[i].Host != out[j].Host {
|
if out[i].Host != out[j].Host {
|
||||||
return out[i].Host < out[j].Host
|
return out[i].Host < out[j].Host
|
||||||
@@ -57,7 +57,7 @@ var SortProcessInfoOpt = cmp.Transformer("SortProcessInfo", func(in []*base.Proc
|
|||||||
var SortWorkerInfoOpt = cmp.Transformer("SortWorkerInfo", func(in []*base.WorkerInfo) []*base.WorkerInfo {
|
var SortWorkerInfoOpt = cmp.Transformer("SortWorkerInfo", func(in []*base.WorkerInfo) []*base.WorkerInfo {
|
||||||
out := append([]*base.WorkerInfo(nil), in...) // Copy input to avoid mutating it
|
out := append([]*base.WorkerInfo(nil), in...) // Copy input to avoid mutating it
|
||||||
sort.Slice(out, func(i, j int) bool {
|
sort.Slice(out, func(i, j int) bool {
|
||||||
return out[i].ID.String() < out[j].ID.String()
|
return out[i].ID < out[j].ID
|
||||||
})
|
})
|
||||||
return out
|
return out
|
||||||
})
|
})
|
||||||
|
@@ -7,11 +7,13 @@ package base
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
|
"encoding/json"
|
||||||
"fmt"
|
"fmt"
|
||||||
"strings"
|
"strings"
|
||||||
"sync"
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
|
"github.com/go-redis/redis/v7"
|
||||||
"github.com/rs/xid"
|
"github.com/rs/xid"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -20,10 +22,10 @@ const DefaultQueueName = "default"
|
|||||||
|
|
||||||
// Redis keys
|
// Redis keys
|
||||||
const (
|
const (
|
||||||
AllProcesses = "asynq:ps" // ZSET
|
AllServers = "asynq:servers" // ZSET
|
||||||
psPrefix = "asynq:ps:" // STRING - asynq:ps:<host>:<pid>
|
serversPrefix = "asynq:servers:" // STRING - asynq:ps:<host>:<pid>:<serverid>
|
||||||
AllWorkers = "asynq:workers" // ZSET
|
AllWorkers = "asynq:workers" // ZSET
|
||||||
workersPrefix = "asynq:workers:" // HASH - asynq:workers:<host:<pid>
|
workersPrefix = "asynq:workers:" // HASH - asynq:workers:<host:<pid>:<serverid>
|
||||||
processedPrefix = "asynq:processed:" // STRING - asynq:processed:<yyyy-mm-dd>
|
processedPrefix = "asynq:processed:" // STRING - asynq:processed:<yyyy-mm-dd>
|
||||||
failurePrefix = "asynq:failure:" // STRING - asynq:failure:<yyyy-mm-dd>
|
failurePrefix = "asynq:failure:" // STRING - asynq:failure:<yyyy-mm-dd>
|
||||||
QueuePrefix = "asynq:queues:" // LIST - asynq:queues:<qname>
|
QueuePrefix = "asynq:queues:" // LIST - asynq:queues:<qname>
|
||||||
@@ -33,6 +35,7 @@ const (
|
|||||||
RetryQueue = "asynq:retry" // ZSET
|
RetryQueue = "asynq:retry" // ZSET
|
||||||
DeadQueue = "asynq:dead" // ZSET
|
DeadQueue = "asynq:dead" // ZSET
|
||||||
InProgressQueue = "asynq:in_progress" // LIST
|
InProgressQueue = "asynq:in_progress" // LIST
|
||||||
|
PausedQueues = "asynq:paused" // SET
|
||||||
CancelChannel = "asynq:cancel" // PubSub channel
|
CancelChannel = "asynq:cancel" // PubSub channel
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -51,14 +54,14 @@ func FailureKey(t time.Time) string {
|
|||||||
return failurePrefix + t.UTC().Format("2006-01-02")
|
return failurePrefix + t.UTC().Format("2006-01-02")
|
||||||
}
|
}
|
||||||
|
|
||||||
// ProcessInfoKey returns a redis key for process info.
|
// ServerInfoKey returns a redis key for process info.
|
||||||
func ProcessInfoKey(hostname string, pid int) string {
|
func ServerInfoKey(hostname string, pid int, sid string) string {
|
||||||
return fmt.Sprintf("%s%s:%d", psPrefix, hostname, pid)
|
return fmt.Sprintf("%s%s:%d:%s", serversPrefix, hostname, pid, sid)
|
||||||
}
|
}
|
||||||
|
|
||||||
// WorkersKey returns a redis key for the workers given hostname and pid.
|
// WorkersKey returns a redis key for the workers given hostname, pid, and server ID.
|
||||||
func WorkersKey(hostname string, pid int) string {
|
func WorkersKey(hostname string, pid int, sid string) string {
|
||||||
return fmt.Sprintf("%s%s:%d", workersPrefix, hostname, pid)
|
return fmt.Sprintf("%s%s:%d:%s", workersPrefix, hostname, pid, sid)
|
||||||
}
|
}
|
||||||
|
|
||||||
// TaskMessage is the internal representation of a task with additional metadata fields.
|
// TaskMessage is the internal representation of a task with additional metadata fields.
|
||||||
@@ -104,149 +107,90 @@ type TaskMessage struct {
|
|||||||
UniqueKey string
|
UniqueKey string
|
||||||
}
|
}
|
||||||
|
|
||||||
// ProcessState holds process level information.
|
// EncodeMessage marshals the given task message in JSON and returns an encoded string.
|
||||||
//
|
func EncodeMessage(msg *TaskMessage) (string, error) {
|
||||||
// ProcessStates are safe for concurrent use by multiple goroutines.
|
b, err := json.Marshal(msg)
|
||||||
type ProcessState struct {
|
if err != nil {
|
||||||
mu sync.Mutex // guards all data fields
|
return "", err
|
||||||
concurrency int
|
}
|
||||||
queues map[string]int
|
return string(b), nil
|
||||||
strictPriority bool
|
|
||||||
pid int
|
|
||||||
host string
|
|
||||||
status PStatus
|
|
||||||
started time.Time
|
|
||||||
workers map[string]*workerStats
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// PStatus represents status of a process.
|
// DecodeMessage unmarshals the given encoded string and returns a decoded task message.
|
||||||
type PStatus int
|
func DecodeMessage(s string) (*TaskMessage, error) {
|
||||||
|
d := json.NewDecoder(strings.NewReader(s))
|
||||||
|
d.UseNumber()
|
||||||
|
var msg TaskMessage
|
||||||
|
if err := d.Decode(&msg); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
return &msg, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// ServerStatus represents status of a server.
|
||||||
|
// ServerStatus methods are concurrency safe.
|
||||||
|
type ServerStatus struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
val ServerStatusValue
|
||||||
|
}
|
||||||
|
|
||||||
|
// NewServerStatus returns a new status instance given an initial value.
|
||||||
|
func NewServerStatus(v ServerStatusValue) *ServerStatus {
|
||||||
|
return &ServerStatus{val: v}
|
||||||
|
}
|
||||||
|
|
||||||
|
type ServerStatusValue int
|
||||||
|
|
||||||
const (
|
const (
|
||||||
// StatusIdle indicates process is in idle state.
|
// StatusIdle indicates the server is in idle state.
|
||||||
StatusIdle PStatus = iota
|
StatusIdle ServerStatusValue = iota
|
||||||
|
|
||||||
// StatusRunning indicates process is up and processing tasks.
|
// StatusRunning indicates the servier is up and processing tasks.
|
||||||
StatusRunning
|
StatusRunning
|
||||||
|
|
||||||
// StatusStopped indicates process is up but not processing new tasks.
|
// StatusQuiet indicates the server is up but not processing new tasks.
|
||||||
|
StatusQuiet
|
||||||
|
|
||||||
|
// StatusStopped indicates the server server has been stopped.
|
||||||
StatusStopped
|
StatusStopped
|
||||||
)
|
)
|
||||||
|
|
||||||
var statuses = []string{
|
var statuses = []string{
|
||||||
"idle",
|
"idle",
|
||||||
"running",
|
"running",
|
||||||
|
"quiet",
|
||||||
"stopped",
|
"stopped",
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s PStatus) String() string {
|
func (s *ServerStatus) String() string {
|
||||||
if StatusIdle <= s && s <= StatusStopped {
|
s.mu.Lock()
|
||||||
return statuses[s]
|
defer s.mu.Unlock()
|
||||||
|
if StatusIdle <= s.val && s.val <= StatusStopped {
|
||||||
|
return statuses[s.val]
|
||||||
}
|
}
|
||||||
return "unknown status"
|
return "unknown status"
|
||||||
}
|
}
|
||||||
|
|
||||||
type workerStats struct {
|
// Get returns the status value.
|
||||||
msg *TaskMessage
|
func (s *ServerStatus) Get() ServerStatusValue {
|
||||||
started time.Time
|
s.mu.Lock()
|
||||||
|
v := s.val
|
||||||
|
s.mu.Unlock()
|
||||||
|
return v
|
||||||
}
|
}
|
||||||
|
|
||||||
// NewProcessState returns a new instance of ProcessState.
|
// Set sets the status value.
|
||||||
func NewProcessState(host string, pid, concurrency int, queues map[string]int, strict bool) *ProcessState {
|
func (s *ServerStatus) Set(v ServerStatusValue) {
|
||||||
return &ProcessState{
|
s.mu.Lock()
|
||||||
host: host,
|
s.val = v
|
||||||
pid: pid,
|
s.mu.Unlock()
|
||||||
concurrency: concurrency,
|
|
||||||
queues: cloneQueueConfig(queues),
|
|
||||||
strictPriority: strict,
|
|
||||||
status: StatusIdle,
|
|
||||||
workers: make(map[string]*workerStats),
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// SetStatus updates the state of process.
|
// ServerInfo holds information about a running server.
|
||||||
func (ps *ProcessState) SetStatus(status PStatus) {
|
type ServerInfo struct {
|
||||||
ps.mu.Lock()
|
|
||||||
defer ps.mu.Unlock()
|
|
||||||
ps.status = status
|
|
||||||
}
|
|
||||||
|
|
||||||
// SetStarted records when the process started processing.
|
|
||||||
func (ps *ProcessState) SetStarted(t time.Time) {
|
|
||||||
ps.mu.Lock()
|
|
||||||
defer ps.mu.Unlock()
|
|
||||||
ps.started = t
|
|
||||||
}
|
|
||||||
|
|
||||||
// AddWorkerStats records when a worker started and which task it's processing.
|
|
||||||
func (ps *ProcessState) AddWorkerStats(msg *TaskMessage, started time.Time) {
|
|
||||||
ps.mu.Lock()
|
|
||||||
defer ps.mu.Unlock()
|
|
||||||
ps.workers[msg.ID.String()] = &workerStats{msg, started}
|
|
||||||
}
|
|
||||||
|
|
||||||
// DeleteWorkerStats removes a worker's entry from the process state.
|
|
||||||
func (ps *ProcessState) DeleteWorkerStats(msg *TaskMessage) {
|
|
||||||
ps.mu.Lock()
|
|
||||||
defer ps.mu.Unlock()
|
|
||||||
delete(ps.workers, msg.ID.String())
|
|
||||||
}
|
|
||||||
|
|
||||||
// Get returns current state of process as a ProcessInfo.
|
|
||||||
func (ps *ProcessState) Get() *ProcessInfo {
|
|
||||||
ps.mu.Lock()
|
|
||||||
defer ps.mu.Unlock()
|
|
||||||
return &ProcessInfo{
|
|
||||||
Host: ps.host,
|
|
||||||
PID: ps.pid,
|
|
||||||
Concurrency: ps.concurrency,
|
|
||||||
Queues: cloneQueueConfig(ps.queues),
|
|
||||||
StrictPriority: ps.strictPriority,
|
|
||||||
Status: ps.status.String(),
|
|
||||||
Started: ps.started,
|
|
||||||
ActiveWorkerCount: len(ps.workers),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// GetWorkers returns a list of currently running workers' info.
|
|
||||||
func (ps *ProcessState) GetWorkers() []*WorkerInfo {
|
|
||||||
ps.mu.Lock()
|
|
||||||
defer ps.mu.Unlock()
|
|
||||||
var res []*WorkerInfo
|
|
||||||
for _, w := range ps.workers {
|
|
||||||
res = append(res, &WorkerInfo{
|
|
||||||
Host: ps.host,
|
|
||||||
PID: ps.pid,
|
|
||||||
ID: w.msg.ID,
|
|
||||||
Type: w.msg.Type,
|
|
||||||
Queue: w.msg.Queue,
|
|
||||||
Payload: clonePayload(w.msg.Payload),
|
|
||||||
Started: w.started,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
return res
|
|
||||||
}
|
|
||||||
|
|
||||||
func cloneQueueConfig(qcfg map[string]int) map[string]int {
|
|
||||||
res := make(map[string]int)
|
|
||||||
for qname, n := range qcfg {
|
|
||||||
res[qname] = n
|
|
||||||
}
|
|
||||||
return res
|
|
||||||
}
|
|
||||||
|
|
||||||
func clonePayload(payload map[string]interface{}) map[string]interface{} {
|
|
||||||
res := make(map[string]interface{})
|
|
||||||
for k, v := range payload {
|
|
||||||
res[k] = v
|
|
||||||
}
|
|
||||||
return res
|
|
||||||
}
|
|
||||||
|
|
||||||
// ProcessInfo holds information about a running background worker process.
|
|
||||||
type ProcessInfo struct {
|
|
||||||
Host string
|
Host string
|
||||||
PID int
|
PID int
|
||||||
|
ServerID string
|
||||||
Concurrency int
|
Concurrency int
|
||||||
Queues map[string]int
|
Queues map[string]int
|
||||||
StrictPriority bool
|
StrictPriority bool
|
||||||
@@ -259,7 +203,7 @@ type ProcessInfo struct {
|
|||||||
type WorkerInfo struct {
|
type WorkerInfo struct {
|
||||||
Host string
|
Host string
|
||||||
PID int
|
PID int
|
||||||
ID xid.ID
|
ID string
|
||||||
Type string
|
Type string
|
||||||
Queue string
|
Queue string
|
||||||
Payload map[string]interface{}
|
Payload map[string]interface{}
|
||||||
@@ -313,3 +257,25 @@ func (c *Cancelations) GetAll() []context.CancelFunc {
|
|||||||
}
|
}
|
||||||
return res
|
return res
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Broker is a message broker that supports operations to manage task queues.
|
||||||
|
//
|
||||||
|
// See rdb.RDB as a reference implementation.
|
||||||
|
type Broker interface {
|
||||||
|
Enqueue(msg *TaskMessage) error
|
||||||
|
EnqueueUnique(msg *TaskMessage, ttl time.Duration) error
|
||||||
|
Dequeue(qnames ...string) (*TaskMessage, error)
|
||||||
|
Done(msg *TaskMessage) error
|
||||||
|
Requeue(msg *TaskMessage) error
|
||||||
|
Schedule(msg *TaskMessage, processAt time.Time) error
|
||||||
|
ScheduleUnique(msg *TaskMessage, processAt time.Time, ttl time.Duration) error
|
||||||
|
Retry(msg *TaskMessage, processAt time.Time, errMsg string) error
|
||||||
|
Kill(msg *TaskMessage, errMsg string) error
|
||||||
|
RequeueAll() (int64, error)
|
||||||
|
CheckAndEnqueue() error
|
||||||
|
WriteServerState(info *ServerInfo, workers []*WorkerInfo, ttl time.Duration) error
|
||||||
|
ClearServerState(host string, pid int, serverID string) error
|
||||||
|
CancelationPubSub() (*redis.PubSub, error) // TODO: Need to decouple from redis to support other brokers
|
||||||
|
PublishCancelation(id string) error
|
||||||
|
Close() error
|
||||||
|
}
|
||||||
|
@@ -6,7 +6,7 @@ package base
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"math/rand"
|
"encoding/json"
|
||||||
"sync"
|
"sync"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
@@ -67,20 +67,22 @@ func TestFailureKey(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestProcessInfoKey(t *testing.T) {
|
func TestServerInfoKey(t *testing.T) {
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
hostname string
|
hostname string
|
||||||
pid int
|
pid int
|
||||||
|
sid string
|
||||||
want string
|
want string
|
||||||
}{
|
}{
|
||||||
{"localhost", 9876, "asynq:ps:localhost:9876"},
|
{"localhost", 9876, "server123", "asynq:servers:localhost:9876:server123"},
|
||||||
{"127.0.0.1", 1234, "asynq:ps:127.0.0.1:1234"},
|
{"127.0.0.1", 1234, "server987", "asynq:servers:127.0.0.1:1234:server987"},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
got := ProcessInfoKey(tc.hostname, tc.pid)
|
got := ServerInfoKey(tc.hostname, tc.pid, tc.sid)
|
||||||
if got != tc.want {
|
if got != tc.want {
|
||||||
t.Errorf("ProcessInfoKey(%q, %d) = %q, want %q", tc.hostname, tc.pid, got, tc.want)
|
t.Errorf("ServerInfoKey(%q, %d, %q) = %q, want %q",
|
||||||
|
tc.hostname, tc.pid, tc.sid, got, tc.want)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -89,80 +91,90 @@ func TestWorkersKey(t *testing.T) {
|
|||||||
tests := []struct {
|
tests := []struct {
|
||||||
hostname string
|
hostname string
|
||||||
pid int
|
pid int
|
||||||
|
sid string
|
||||||
want string
|
want string
|
||||||
}{
|
}{
|
||||||
{"localhost", 9876, "asynq:workers:localhost:9876"},
|
{"localhost", 9876, "server1", "asynq:workers:localhost:9876:server1"},
|
||||||
{"127.0.0.1", 1234, "asynq:workers:127.0.0.1:1234"},
|
{"127.0.0.1", 1234, "server2", "asynq:workers:127.0.0.1:1234:server2"},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
got := WorkersKey(tc.hostname, tc.pid)
|
got := WorkersKey(tc.hostname, tc.pid, tc.sid)
|
||||||
if got != tc.want {
|
if got != tc.want {
|
||||||
t.Errorf("WorkersKey(%q, %d) = %q, want = %q", tc.hostname, tc.pid, got, tc.want)
|
t.Errorf("WorkersKey(%q, %d, %q) = %q, want = %q",
|
||||||
|
tc.hostname, tc.pid, tc.sid, got, tc.want)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Test for process state being accessed by multiple goroutines.
|
func TestMessageEncoding(t *testing.T) {
|
||||||
// Run with -race flag to check for data race.
|
id := xid.New()
|
||||||
func TestProcessStateConcurrentAccess(t *testing.T) {
|
tests := []struct {
|
||||||
ps := NewProcessState("127.0.0.1", 1234, 10, map[string]int{"default": 1}, false)
|
in *TaskMessage
|
||||||
var wg sync.WaitGroup
|
out *TaskMessage
|
||||||
started := time.Now()
|
}{
|
||||||
msgs := []*TaskMessage{
|
{
|
||||||
{ID: xid.New(), Type: "type1", Payload: map[string]interface{}{"user_id": 42}},
|
in: &TaskMessage{
|
||||||
{ID: xid.New(), Type: "type2"},
|
Type: "task1",
|
||||||
{ID: xid.New(), Type: "type3"},
|
Payload: map[string]interface{}{"a": 1, "b": "hello!", "c": true},
|
||||||
|
ID: id,
|
||||||
|
Queue: "default",
|
||||||
|
Retry: 10,
|
||||||
|
Retried: 0,
|
||||||
|
Timeout: "0",
|
||||||
|
},
|
||||||
|
out: &TaskMessage{
|
||||||
|
Type: "task1",
|
||||||
|
Payload: map[string]interface{}{"a": json.Number("1"), "b": "hello!", "c": true},
|
||||||
|
ID: id,
|
||||||
|
Queue: "default",
|
||||||
|
Retry: 10,
|
||||||
|
Retried: 0,
|
||||||
|
Timeout: "0",
|
||||||
|
},
|
||||||
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
// Simulate hearbeater calling SetStatus and SetStarted.
|
for _, tc := range tests {
|
||||||
|
encoded, err := EncodeMessage(tc.in)
|
||||||
|
if err != nil {
|
||||||
|
t.Errorf("EncodeMessage(msg) returned error: %v", err)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
decoded, err := DecodeMessage(encoded)
|
||||||
|
if err != nil {
|
||||||
|
t.Errorf("DecodeMessage(encoded) returned error: %v", err)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if diff := cmp.Diff(tc.out, decoded); diff != "" {
|
||||||
|
t.Errorf("Decoded message == %+v, want %+v;(-want,+got)\n%s",
|
||||||
|
decoded, tc.out, diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Test for status being accessed by multiple goroutines.
|
||||||
|
// Run with -race flag to check for data race.
|
||||||
|
func TestStatusConcurrentAccess(t *testing.T) {
|
||||||
|
status := NewServerStatus(StatusIdle)
|
||||||
|
|
||||||
|
var wg sync.WaitGroup
|
||||||
|
|
||||||
wg.Add(1)
|
wg.Add(1)
|
||||||
go func() {
|
go func() {
|
||||||
defer wg.Done()
|
defer wg.Done()
|
||||||
ps.SetStarted(started)
|
status.Get()
|
||||||
ps.SetStatus(StatusRunning)
|
status.String()
|
||||||
}()
|
}()
|
||||||
|
|
||||||
// Simulate processor starting worker goroutines.
|
|
||||||
for _, msg := range msgs {
|
|
||||||
wg.Add(1)
|
|
||||||
ps.AddWorkerStats(msg, time.Now())
|
|
||||||
go func(msg *TaskMessage) {
|
|
||||||
defer wg.Done()
|
|
||||||
time.Sleep(time.Duration(rand.Intn(500)) * time.Millisecond)
|
|
||||||
ps.DeleteWorkerStats(msg)
|
|
||||||
}(msg)
|
|
||||||
}
|
|
||||||
|
|
||||||
// Simulate hearbeater calling Get and GetWorkers
|
|
||||||
wg.Add(1)
|
wg.Add(1)
|
||||||
go func() {
|
go func() {
|
||||||
wg.Done()
|
defer wg.Done()
|
||||||
for i := 0; i < 5; i++ {
|
status.Set(StatusStopped)
|
||||||
ps.Get()
|
status.String()
|
||||||
ps.GetWorkers()
|
|
||||||
time.Sleep(time.Duration(rand.Intn(100)) * time.Millisecond)
|
|
||||||
}
|
|
||||||
}()
|
}()
|
||||||
|
|
||||||
wg.Wait()
|
wg.Wait()
|
||||||
|
|
||||||
want := &ProcessInfo{
|
|
||||||
Host: "127.0.0.1",
|
|
||||||
PID: 1234,
|
|
||||||
Concurrency: 10,
|
|
||||||
Queues: map[string]int{"default": 1},
|
|
||||||
StrictPriority: false,
|
|
||||||
Status: "running",
|
|
||||||
Started: started,
|
|
||||||
ActiveWorkerCount: 0,
|
|
||||||
}
|
|
||||||
|
|
||||||
got := ps.Get()
|
|
||||||
if diff := cmp.Diff(want, got); diff != "" {
|
|
||||||
t.Errorf("(*ProcessState).Get() = %+v, want %+v; (-want,+got)\n%s",
|
|
||||||
got, want, diff)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Test for cancelations being accessed by multiple goroutines.
|
// Test for cancelations being accessed by multiple goroutines.
|
||||||
|
@@ -6,52 +6,210 @@
|
|||||||
package log
|
package log
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
stdlog "log"
|
stdlog "log"
|
||||||
"os"
|
"os"
|
||||||
|
"sync"
|
||||||
)
|
)
|
||||||
|
|
||||||
// NewLogger creates and returns a new instance of Logger.
|
// Base supports logging at various log levels.
|
||||||
func NewLogger(out io.Writer) *Logger {
|
type Base interface {
|
||||||
return &Logger{
|
// Debug logs a message at Debug level.
|
||||||
stdlog.New(out, "", stdlog.Ldate|stdlog.Ltime|stdlog.Lmicroseconds|stdlog.LUTC),
|
Debug(args ...interface{})
|
||||||
}
|
|
||||||
|
// Info logs a message at Info level.
|
||||||
|
Info(args ...interface{})
|
||||||
|
|
||||||
|
// Warn logs a message at Warning level.
|
||||||
|
Warn(args ...interface{})
|
||||||
|
|
||||||
|
// Error logs a message at Error level.
|
||||||
|
Error(args ...interface{})
|
||||||
|
|
||||||
|
// Fatal logs a message at Fatal level
|
||||||
|
// and process will exit with status set to 1.
|
||||||
|
Fatal(args ...interface{})
|
||||||
}
|
}
|
||||||
|
|
||||||
// Logger is a wrapper object around log.Logger from the standard library.
|
// baseLogger is a wrapper object around log.Logger from the standard library.
|
||||||
// It supports logging at various log levels.
|
// It supports logging at various log levels.
|
||||||
type Logger struct {
|
type baseLogger struct {
|
||||||
*stdlog.Logger
|
*stdlog.Logger
|
||||||
}
|
}
|
||||||
|
|
||||||
// Debug logs a message at Debug level.
|
// Debug logs a message at Debug level.
|
||||||
func (l *Logger) Debug(format string, args ...interface{}) {
|
func (l *baseLogger) Debug(args ...interface{}) {
|
||||||
format = "DEBUG: " + format
|
l.prefixPrint("DEBUG: ", args...)
|
||||||
l.Printf(format, args...)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Info logs a message at Info level.
|
// Info logs a message at Info level.
|
||||||
func (l *Logger) Info(format string, args ...interface{}) {
|
func (l *baseLogger) Info(args ...interface{}) {
|
||||||
format = "INFO: " + format
|
l.prefixPrint("INFO: ", args...)
|
||||||
l.Printf(format, args...)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Warn logs a message at Warning level.
|
// Warn logs a message at Warning level.
|
||||||
func (l *Logger) Warn(format string, args ...interface{}) {
|
func (l *baseLogger) Warn(args ...interface{}) {
|
||||||
format = "WARN: " + format
|
l.prefixPrint("WARN: ", args...)
|
||||||
l.Printf(format, args...)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Error logs a message at Error level.
|
// Error logs a message at Error level.
|
||||||
func (l *Logger) Error(format string, args ...interface{}) {
|
func (l *baseLogger) Error(args ...interface{}) {
|
||||||
format = "ERROR: " + format
|
l.prefixPrint("ERROR: ", args...)
|
||||||
l.Printf(format, args...)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Fatal logs a message at Fatal level
|
// Fatal logs a message at Fatal level
|
||||||
// and process will exit with status set to 1.
|
// and process will exit with status set to 1.
|
||||||
func (l *Logger) Fatal(format string, args ...interface{}) {
|
func (l *baseLogger) Fatal(args ...interface{}) {
|
||||||
format = "FATAL: " + format
|
l.prefixPrint("FATAL: ", args...)
|
||||||
l.Printf(format, args...)
|
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (l *baseLogger) prefixPrint(prefix string, args ...interface{}) {
|
||||||
|
args = append([]interface{}{prefix}, args...)
|
||||||
|
l.Print(args...)
|
||||||
|
}
|
||||||
|
|
||||||
|
// newBase creates and returns a new instance of baseLogger.
|
||||||
|
func newBase(out io.Writer) *baseLogger {
|
||||||
|
prefix := fmt.Sprintf("asynq: pid=%d ", os.Getpid())
|
||||||
|
return &baseLogger{
|
||||||
|
stdlog.New(out, prefix, stdlog.Ldate|stdlog.Ltime|stdlog.Lmicroseconds|stdlog.LUTC),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// NewLogger creates and returns a new instance of Logger.
|
||||||
|
// Log level is set to DebugLevel by default.
|
||||||
|
func NewLogger(base Base) *Logger {
|
||||||
|
if base == nil {
|
||||||
|
base = newBase(os.Stderr)
|
||||||
|
}
|
||||||
|
return &Logger{base: base, level: DebugLevel}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Logger logs message to io.Writer at various log levels.
|
||||||
|
type Logger struct {
|
||||||
|
base Base
|
||||||
|
|
||||||
|
mu sync.Mutex
|
||||||
|
// Minimum log level for this logger.
|
||||||
|
// Message with level lower than this level won't be outputted.
|
||||||
|
level Level
|
||||||
|
}
|
||||||
|
|
||||||
|
// Level represents a log level.
|
||||||
|
type Level int32
|
||||||
|
|
||||||
|
const (
|
||||||
|
// DebugLevel is the lowest level of logging.
|
||||||
|
// Debug logs are intended for debugging and development purposes.
|
||||||
|
DebugLevel Level = iota
|
||||||
|
|
||||||
|
// InfoLevel is used for general informational log messages.
|
||||||
|
InfoLevel
|
||||||
|
|
||||||
|
// WarnLevel is used for undesired but relatively expected events,
|
||||||
|
// which may indicate a problem.
|
||||||
|
WarnLevel
|
||||||
|
|
||||||
|
// ErrorLevel is used for undesired and unexpected events that
|
||||||
|
// the program can recover from.
|
||||||
|
ErrorLevel
|
||||||
|
|
||||||
|
// FatalLevel is used for undesired and unexpected events that
|
||||||
|
// the program cannot recover from.
|
||||||
|
FatalLevel
|
||||||
|
)
|
||||||
|
|
||||||
|
// String is part of the fmt.Stringer interface.
|
||||||
|
//
|
||||||
|
// Used for testing and debugging purposes.
|
||||||
|
func (l Level) String() string {
|
||||||
|
switch l {
|
||||||
|
case DebugLevel:
|
||||||
|
return "debug"
|
||||||
|
case InfoLevel:
|
||||||
|
return "info"
|
||||||
|
case WarnLevel:
|
||||||
|
return "warning"
|
||||||
|
case ErrorLevel:
|
||||||
|
return "error"
|
||||||
|
case FatalLevel:
|
||||||
|
return "fatal"
|
||||||
|
default:
|
||||||
|
return "unknown"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// canLogAt reports whether logger can log at level v.
|
||||||
|
func (l *Logger) canLogAt(v Level) bool {
|
||||||
|
l.mu.Lock()
|
||||||
|
defer l.mu.Unlock()
|
||||||
|
return v >= l.level
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Debug(args ...interface{}) {
|
||||||
|
if !l.canLogAt(DebugLevel) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
l.base.Debug(args...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Info(args ...interface{}) {
|
||||||
|
if !l.canLogAt(InfoLevel) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
l.base.Info(args...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Warn(args ...interface{}) {
|
||||||
|
if !l.canLogAt(WarnLevel) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
l.base.Warn(args...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Error(args ...interface{}) {
|
||||||
|
if !l.canLogAt(ErrorLevel) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
l.base.Error(args...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Fatal(args ...interface{}) {
|
||||||
|
if !l.canLogAt(FatalLevel) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
l.base.Fatal(args...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Debugf(format string, args ...interface{}) {
|
||||||
|
l.Debug(fmt.Sprintf(format, args...))
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Infof(format string, args ...interface{}) {
|
||||||
|
l.Info(fmt.Sprintf(format, args...))
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Warnf(format string, args ...interface{}) {
|
||||||
|
l.Warn(fmt.Sprintf(format, args...))
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Errorf(format string, args ...interface{}) {
|
||||||
|
l.Error(fmt.Sprintf(format, args...))
|
||||||
|
}
|
||||||
|
|
||||||
|
func (l *Logger) Fatalf(format string, args ...interface{}) {
|
||||||
|
l.Fatal(fmt.Sprintf(format, args...))
|
||||||
|
}
|
||||||
|
|
||||||
|
// SetLevel sets the logger level.
|
||||||
|
// It panics if v is less than DebugLevel or greater than FatalLevel.
|
||||||
|
func (l *Logger) SetLevel(v Level) {
|
||||||
|
l.mu.Lock()
|
||||||
|
defer l.mu.Unlock()
|
||||||
|
if v < DebugLevel || v > FatalLevel {
|
||||||
|
panic("log: invalid log level")
|
||||||
|
}
|
||||||
|
l.level = v
|
||||||
|
}
|
||||||
|
@@ -13,6 +13,7 @@ import (
|
|||||||
|
|
||||||
// regexp for timestamps
|
// regexp for timestamps
|
||||||
const (
|
const (
|
||||||
|
rgxPID = `[0-9]+`
|
||||||
rgxdate = `[0-9][0-9][0-9][0-9]/[0-9][0-9]/[0-9][0-9]`
|
rgxdate = `[0-9][0-9][0-9][0-9]/[0-9][0-9]/[0-9][0-9]`
|
||||||
rgxtime = `[0-9][0-9]:[0-9][0-9]:[0-9][0-9]`
|
rgxtime = `[0-9][0-9]:[0-9][0-9]:[0-9][0-9]`
|
||||||
rgxmicroseconds = `\.[0-9][0-9][0-9][0-9][0-9][0-9]`
|
rgxmicroseconds = `\.[0-9][0-9][0-9][0-9][0-9][0-9]`
|
||||||
@@ -27,20 +28,22 @@ type tester struct {
|
|||||||
func TestLoggerDebug(t *testing.T) {
|
func TestLoggerDebug(t *testing.T) {
|
||||||
tests := []tester{
|
tests := []tester{
|
||||||
{
|
{
|
||||||
desc: "without trailing newline, logger adds newline",
|
desc: "without trailing newline, logger adds newline",
|
||||||
message: "hello, world!",
|
message: "hello, world!",
|
||||||
wantPattern: fmt.Sprintf("^%s %s%s DEBUG: hello, world!\n$", rgxdate, rgxtime, rgxmicroseconds),
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s DEBUG: hello, world!\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
desc: "with trailing newline, logger preserves newline",
|
desc: "with trailing newline, logger preserves newline",
|
||||||
message: "hello, world!\n",
|
message: "hello, world!\n",
|
||||||
wantPattern: fmt.Sprintf("^%s %s%s DEBUG: hello, world!\n$", rgxdate, rgxtime, rgxmicroseconds),
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s DEBUG: hello, world!\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
var buf bytes.Buffer
|
var buf bytes.Buffer
|
||||||
logger := NewLogger(&buf)
|
logger := NewLogger(newBase(&buf))
|
||||||
|
|
||||||
logger.Debug(tc.message)
|
logger.Debug(tc.message)
|
||||||
|
|
||||||
@@ -50,7 +53,7 @@ func TestLoggerDebug(t *testing.T) {
|
|||||||
t.Fatal("pattern did not compile:", err)
|
t.Fatal("pattern did not compile:", err)
|
||||||
}
|
}
|
||||||
if !matched {
|
if !matched {
|
||||||
t.Errorf("logger.info(%q) outputted %q, should match pattern %q",
|
t.Errorf("logger.Debug(%q) outputted %q, should match pattern %q",
|
||||||
tc.message, got, tc.wantPattern)
|
tc.message, got, tc.wantPattern)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -59,20 +62,22 @@ func TestLoggerDebug(t *testing.T) {
|
|||||||
func TestLoggerInfo(t *testing.T) {
|
func TestLoggerInfo(t *testing.T) {
|
||||||
tests := []tester{
|
tests := []tester{
|
||||||
{
|
{
|
||||||
desc: "without trailing newline, logger adds newline",
|
desc: "without trailing newline, logger adds newline",
|
||||||
message: "hello, world!",
|
message: "hello, world!",
|
||||||
wantPattern: fmt.Sprintf("^%s %s%s INFO: hello, world!\n$", rgxdate, rgxtime, rgxmicroseconds),
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s INFO: hello, world!\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
desc: "with trailing newline, logger preserves newline",
|
desc: "with trailing newline, logger preserves newline",
|
||||||
message: "hello, world!\n",
|
message: "hello, world!\n",
|
||||||
wantPattern: fmt.Sprintf("^%s %s%s INFO: hello, world!\n$", rgxdate, rgxtime, rgxmicroseconds),
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s INFO: hello, world!\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
var buf bytes.Buffer
|
var buf bytes.Buffer
|
||||||
logger := NewLogger(&buf)
|
logger := NewLogger(newBase(&buf))
|
||||||
|
|
||||||
logger.Info(tc.message)
|
logger.Info(tc.message)
|
||||||
|
|
||||||
@@ -82,7 +87,7 @@ func TestLoggerInfo(t *testing.T) {
|
|||||||
t.Fatal("pattern did not compile:", err)
|
t.Fatal("pattern did not compile:", err)
|
||||||
}
|
}
|
||||||
if !matched {
|
if !matched {
|
||||||
t.Errorf("logger.info(%q) outputted %q, should match pattern %q",
|
t.Errorf("logger.Info(%q) outputted %q, should match pattern %q",
|
||||||
tc.message, got, tc.wantPattern)
|
tc.message, got, tc.wantPattern)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -91,20 +96,22 @@ func TestLoggerInfo(t *testing.T) {
|
|||||||
func TestLoggerWarn(t *testing.T) {
|
func TestLoggerWarn(t *testing.T) {
|
||||||
tests := []tester{
|
tests := []tester{
|
||||||
{
|
{
|
||||||
desc: "without trailing newline, logger adds newline",
|
desc: "without trailing newline, logger adds newline",
|
||||||
message: "hello, world!",
|
message: "hello, world!",
|
||||||
wantPattern: fmt.Sprintf("^%s %s%s WARN: hello, world!\n$", rgxdate, rgxtime, rgxmicroseconds),
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s WARN: hello, world!\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
desc: "with trailing newline, logger preserves newline",
|
desc: "with trailing newline, logger preserves newline",
|
||||||
message: "hello, world!\n",
|
message: "hello, world!\n",
|
||||||
wantPattern: fmt.Sprintf("^%s %s%s WARN: hello, world!\n$", rgxdate, rgxtime, rgxmicroseconds),
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s WARN: hello, world!\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
var buf bytes.Buffer
|
var buf bytes.Buffer
|
||||||
logger := NewLogger(&buf)
|
logger := NewLogger(newBase(&buf))
|
||||||
|
|
||||||
logger.Warn(tc.message)
|
logger.Warn(tc.message)
|
||||||
|
|
||||||
@@ -114,7 +121,7 @@ func TestLoggerWarn(t *testing.T) {
|
|||||||
t.Fatal("pattern did not compile:", err)
|
t.Fatal("pattern did not compile:", err)
|
||||||
}
|
}
|
||||||
if !matched {
|
if !matched {
|
||||||
t.Errorf("logger.info(%q) outputted %q, should match pattern %q",
|
t.Errorf("logger.Warn(%q) outputted %q, should match pattern %q",
|
||||||
tc.message, got, tc.wantPattern)
|
tc.message, got, tc.wantPattern)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -123,20 +130,22 @@ func TestLoggerWarn(t *testing.T) {
|
|||||||
func TestLoggerError(t *testing.T) {
|
func TestLoggerError(t *testing.T) {
|
||||||
tests := []tester{
|
tests := []tester{
|
||||||
{
|
{
|
||||||
desc: "without trailing newline, logger adds newline",
|
desc: "without trailing newline, logger adds newline",
|
||||||
message: "hello, world!",
|
message: "hello, world!",
|
||||||
wantPattern: fmt.Sprintf("^%s %s%s ERROR: hello, world!\n$", rgxdate, rgxtime, rgxmicroseconds),
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s ERROR: hello, world!\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
desc: "with trailing newline, logger preserves newline",
|
desc: "with trailing newline, logger preserves newline",
|
||||||
message: "hello, world!\n",
|
message: "hello, world!\n",
|
||||||
wantPattern: fmt.Sprintf("^%s %s%s ERROR: hello, world!\n$", rgxdate, rgxtime, rgxmicroseconds),
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s ERROR: hello, world!\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
var buf bytes.Buffer
|
var buf bytes.Buffer
|
||||||
logger := NewLogger(&buf)
|
logger := NewLogger(newBase(&buf))
|
||||||
|
|
||||||
logger.Error(tc.message)
|
logger.Error(tc.message)
|
||||||
|
|
||||||
@@ -146,8 +155,234 @@ func TestLoggerError(t *testing.T) {
|
|||||||
t.Fatal("pattern did not compile:", err)
|
t.Fatal("pattern did not compile:", err)
|
||||||
}
|
}
|
||||||
if !matched {
|
if !matched {
|
||||||
t.Errorf("logger.info(%q) outputted %q, should match pattern %q",
|
t.Errorf("logger.Error(%q) outputted %q, should match pattern %q",
|
||||||
tc.message, got, tc.wantPattern)
|
tc.message, got, tc.wantPattern)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
type formatTester struct {
|
||||||
|
desc string
|
||||||
|
format string
|
||||||
|
args []interface{}
|
||||||
|
wantPattern string // regexp that log output must match
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoggerDebugf(t *testing.T) {
|
||||||
|
tests := []formatTester{
|
||||||
|
{
|
||||||
|
desc: "Formats message with DEBUG prefix",
|
||||||
|
format: "hello, %s!",
|
||||||
|
args: []interface{}{"Gopher"},
|
||||||
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s DEBUG: hello, Gopher!\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
var buf bytes.Buffer
|
||||||
|
logger := NewLogger(newBase(&buf))
|
||||||
|
|
||||||
|
logger.Debugf(tc.format, tc.args...)
|
||||||
|
|
||||||
|
got := buf.String()
|
||||||
|
matched, err := regexp.MatchString(tc.wantPattern, got)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal("pattern did not compile:", err)
|
||||||
|
}
|
||||||
|
if !matched {
|
||||||
|
t.Errorf("logger.Debugf(%q, %v) outputted %q, should match pattern %q",
|
||||||
|
tc.format, tc.args, got, tc.wantPattern)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoggerInfof(t *testing.T) {
|
||||||
|
tests := []formatTester{
|
||||||
|
{
|
||||||
|
desc: "Formats message with INFO prefix",
|
||||||
|
format: "%d,%d,%d",
|
||||||
|
args: []interface{}{1, 2, 3},
|
||||||
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s INFO: 1,2,3\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
var buf bytes.Buffer
|
||||||
|
logger := NewLogger(newBase(&buf))
|
||||||
|
|
||||||
|
logger.Infof(tc.format, tc.args...)
|
||||||
|
|
||||||
|
got := buf.String()
|
||||||
|
matched, err := regexp.MatchString(tc.wantPattern, got)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal("pattern did not compile:", err)
|
||||||
|
}
|
||||||
|
if !matched {
|
||||||
|
t.Errorf("logger.Infof(%q, %v) outputted %q, should match pattern %q",
|
||||||
|
tc.format, tc.args, got, tc.wantPattern)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoggerWarnf(t *testing.T) {
|
||||||
|
tests := []formatTester{
|
||||||
|
{
|
||||||
|
desc: "Formats message with WARN prefix",
|
||||||
|
format: "hello, %s",
|
||||||
|
args: []interface{}{"Gophers"},
|
||||||
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s WARN: hello, Gophers\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
var buf bytes.Buffer
|
||||||
|
logger := NewLogger(newBase(&buf))
|
||||||
|
|
||||||
|
logger.Warnf(tc.format, tc.args...)
|
||||||
|
|
||||||
|
got := buf.String()
|
||||||
|
matched, err := regexp.MatchString(tc.wantPattern, got)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal("pattern did not compile:", err)
|
||||||
|
}
|
||||||
|
if !matched {
|
||||||
|
t.Errorf("logger.Warnf(%q, %v) outputted %q, should match pattern %q",
|
||||||
|
tc.format, tc.args, got, tc.wantPattern)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoggerErrorf(t *testing.T) {
|
||||||
|
tests := []formatTester{
|
||||||
|
{
|
||||||
|
desc: "Formats message with ERROR prefix",
|
||||||
|
format: "hello, %s",
|
||||||
|
args: []interface{}{"Gophers"},
|
||||||
|
wantPattern: fmt.Sprintf("^asynq: pid=%s %s %s%s ERROR: hello, Gophers\n$",
|
||||||
|
rgxPID, rgxdate, rgxtime, rgxmicroseconds),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
var buf bytes.Buffer
|
||||||
|
logger := NewLogger(newBase(&buf))
|
||||||
|
|
||||||
|
logger.Errorf(tc.format, tc.args...)
|
||||||
|
|
||||||
|
got := buf.String()
|
||||||
|
matched, err := regexp.MatchString(tc.wantPattern, got)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal("pattern did not compile:", err)
|
||||||
|
}
|
||||||
|
if !matched {
|
||||||
|
t.Errorf("logger.Errorf(%q, %v) outputted %q, should match pattern %q",
|
||||||
|
tc.format, tc.args, got, tc.wantPattern)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoggerWithLowerLevels(t *testing.T) {
|
||||||
|
// Logger should not log messages at a level
|
||||||
|
// lower than the specified level.
|
||||||
|
tests := []struct {
|
||||||
|
level Level
|
||||||
|
op string
|
||||||
|
}{
|
||||||
|
// with level one above
|
||||||
|
{InfoLevel, "Debug"},
|
||||||
|
{InfoLevel, "Debugf"},
|
||||||
|
{WarnLevel, "Info"},
|
||||||
|
{WarnLevel, "Infof"},
|
||||||
|
{ErrorLevel, "Warn"},
|
||||||
|
{ErrorLevel, "Warnf"},
|
||||||
|
{FatalLevel, "Error"},
|
||||||
|
{FatalLevel, "Errorf"},
|
||||||
|
// with skip level
|
||||||
|
{WarnLevel, "Debug"},
|
||||||
|
{ErrorLevel, "Infof"},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
var buf bytes.Buffer
|
||||||
|
logger := NewLogger(newBase(&buf))
|
||||||
|
logger.SetLevel(tc.level)
|
||||||
|
|
||||||
|
switch tc.op {
|
||||||
|
case "Debug":
|
||||||
|
logger.Debug("hello")
|
||||||
|
case "Debugf":
|
||||||
|
logger.Debugf("hello, %s", "world")
|
||||||
|
case "Info":
|
||||||
|
logger.Info("hello")
|
||||||
|
case "Infof":
|
||||||
|
logger.Infof("hello, %s", "world")
|
||||||
|
case "Warn":
|
||||||
|
logger.Warn("hello")
|
||||||
|
case "Warnf":
|
||||||
|
logger.Warnf("hello, %s", "world")
|
||||||
|
case "Error":
|
||||||
|
logger.Error("hello")
|
||||||
|
case "Errorf":
|
||||||
|
logger.Errorf("hello, %s", "world")
|
||||||
|
default:
|
||||||
|
t.Fatalf("unexpected op: %q", tc.op)
|
||||||
|
}
|
||||||
|
|
||||||
|
if buf.String() != "" {
|
||||||
|
t.Errorf("logger.%s outputted log message when level is set to %v", tc.op, tc.level)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLoggerWithSameOrHigherLevels(t *testing.T) {
|
||||||
|
// Logger should log messages at a level
|
||||||
|
// same as or higher than the specified level.
|
||||||
|
tests := []struct {
|
||||||
|
level Level
|
||||||
|
op string
|
||||||
|
}{
|
||||||
|
// same level
|
||||||
|
{DebugLevel, "Debug"},
|
||||||
|
{InfoLevel, "Infof"},
|
||||||
|
{WarnLevel, "Warn"},
|
||||||
|
{ErrorLevel, "Errorf"},
|
||||||
|
// higher level
|
||||||
|
{DebugLevel, "Info"},
|
||||||
|
{InfoLevel, "Warnf"},
|
||||||
|
{WarnLevel, "Error"},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
var buf bytes.Buffer
|
||||||
|
logger := NewLogger(newBase(&buf))
|
||||||
|
logger.SetLevel(tc.level)
|
||||||
|
|
||||||
|
switch tc.op {
|
||||||
|
case "Debug":
|
||||||
|
logger.Debug("hello")
|
||||||
|
case "Debugf":
|
||||||
|
logger.Debugf("hello, %s", "world")
|
||||||
|
case "Info":
|
||||||
|
logger.Info("hello")
|
||||||
|
case "Infof":
|
||||||
|
logger.Infof("hello, %s", "world")
|
||||||
|
case "Warn":
|
||||||
|
logger.Warn("hello")
|
||||||
|
case "Warnf":
|
||||||
|
logger.Warnf("hello, %s", "world")
|
||||||
|
case "Error":
|
||||||
|
logger.Error("hello")
|
||||||
|
case "Errorf":
|
||||||
|
logger.Errorf("hello, %s", "world")
|
||||||
|
default:
|
||||||
|
t.Fatalf("unexpected op: %q", tc.op)
|
||||||
|
}
|
||||||
|
|
||||||
|
if buf.String() == "" {
|
||||||
|
t.Errorf("logger.%s did not output log message when level is set to %v", tc.op, tc.level)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
@@ -7,6 +7,7 @@ package rdb
|
|||||||
import (
|
import (
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"sort"
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
@@ -25,10 +26,24 @@ type Stats struct {
|
|||||||
Dead int
|
Dead int
|
||||||
Processed int
|
Processed int
|
||||||
Failed int
|
Failed int
|
||||||
Queues map[string]int // map of queue name to number of tasks in the queue (e.g., "default": 100, "critical": 20)
|
Queues []*Queue
|
||||||
Timestamp time.Time
|
Timestamp time.Time
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Queue represents a task queue.
|
||||||
|
type Queue struct {
|
||||||
|
// Name of the queue (e.g. "default", "critical").
|
||||||
|
// Note: It doesn't include the prefix "asynq:queues:".
|
||||||
|
Name string
|
||||||
|
|
||||||
|
// Paused indicates whether the queue is paused.
|
||||||
|
// If true, tasks in the queue should not be processed.
|
||||||
|
Paused bool
|
||||||
|
|
||||||
|
// Size is the number of tasks in the queue.
|
||||||
|
Size int
|
||||||
|
}
|
||||||
|
|
||||||
// DailyStats holds aggregate data for a given day.
|
// DailyStats holds aggregate data for a given day.
|
||||||
type DailyStats struct {
|
type DailyStats struct {
|
||||||
Processed int
|
Processed int
|
||||||
@@ -143,8 +158,12 @@ func (r *RDB) CurrentStats() (*Stats, error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
paused, err := r.client.SMembersMap(base.PausedQueues).Result()
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
stats := &Stats{
|
stats := &Stats{
|
||||||
Queues: make(map[string]int),
|
Queues: make([]*Queue, 0),
|
||||||
Timestamp: now,
|
Timestamp: now,
|
||||||
}
|
}
|
||||||
for i := 0; i < len(data); i += 2 {
|
for i := 0; i < len(data); i += 2 {
|
||||||
@@ -154,7 +173,14 @@ func (r *RDB) CurrentStats() (*Stats, error) {
|
|||||||
switch {
|
switch {
|
||||||
case strings.HasPrefix(key, base.QueuePrefix):
|
case strings.HasPrefix(key, base.QueuePrefix):
|
||||||
stats.Enqueued += val
|
stats.Enqueued += val
|
||||||
stats.Queues[strings.TrimPrefix(key, base.QueuePrefix)] = val
|
q := Queue{
|
||||||
|
Name: strings.TrimPrefix(key, base.QueuePrefix),
|
||||||
|
Size: val,
|
||||||
|
}
|
||||||
|
if _, exist := paused[key]; exist {
|
||||||
|
q.Paused = true
|
||||||
|
}
|
||||||
|
stats.Queues = append(stats.Queues, &q)
|
||||||
case key == base.InProgressQueue:
|
case key == base.InProgressQueue:
|
||||||
stats.InProgress = val
|
stats.InProgress = val
|
||||||
case key == base.ScheduledQueue:
|
case key == base.ScheduledQueue:
|
||||||
@@ -169,6 +195,9 @@ func (r *RDB) CurrentStats() (*Stats, error) {
|
|||||||
stats.Failed = val
|
stats.Failed = val
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
sort.Slice(stats.Queues, func(i, j int) bool {
|
||||||
|
return stats.Queues[i].Name < stats.Queues[j].Name
|
||||||
|
})
|
||||||
return stats, nil
|
return stats, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -759,23 +788,23 @@ func (r *RDB) RemoveQueue(qname string, force bool) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Note: Script also removes stale keys.
|
// Note: Script also removes stale keys.
|
||||||
var listProcessesCmd = redis.NewScript(`
|
var listServersCmd = redis.NewScript(`
|
||||||
local res = {}
|
local res = {}
|
||||||
local now = tonumber(ARGV[1])
|
local now = tonumber(ARGV[1])
|
||||||
local keys = redis.call("ZRANGEBYSCORE", KEYS[1], now, "+inf")
|
local keys = redis.call("ZRANGEBYSCORE", KEYS[1], now, "+inf")
|
||||||
for _, key in ipairs(keys) do
|
for _, key in ipairs(keys) do
|
||||||
local ps = redis.call("GET", key)
|
local s = redis.call("GET", key)
|
||||||
if ps then
|
if s then
|
||||||
table.insert(res, ps)
|
table.insert(res, s)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
redis.call("ZREMRANGEBYSCORE", KEYS[1], "-inf", now-1)
|
redis.call("ZREMRANGEBYSCORE", KEYS[1], "-inf", now-1)
|
||||||
return res`)
|
return res`)
|
||||||
|
|
||||||
// ListProcesses returns the list of process statuses.
|
// ListServers returns the list of server info.
|
||||||
func (r *RDB) ListProcesses() ([]*base.ProcessInfo, error) {
|
func (r *RDB) ListServers() ([]*base.ServerInfo, error) {
|
||||||
res, err := listProcessesCmd.Run(r.client,
|
res, err := listServersCmd.Run(r.client,
|
||||||
[]string{base.AllProcesses}, time.Now().UTC().Unix()).Result()
|
[]string{base.AllServers}, time.Now().UTC().Unix()).Result()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -783,16 +812,16 @@ func (r *RDB) ListProcesses() ([]*base.ProcessInfo, error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
var processes []*base.ProcessInfo
|
var servers []*base.ServerInfo
|
||||||
for _, s := range data {
|
for _, s := range data {
|
||||||
var ps base.ProcessInfo
|
var info base.ServerInfo
|
||||||
err := json.Unmarshal([]byte(s), &ps)
|
err := json.Unmarshal([]byte(s), &info)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
continue // skip bad data
|
continue // skip bad data
|
||||||
}
|
}
|
||||||
processes = append(processes, &ps)
|
servers = append(servers, &info)
|
||||||
}
|
}
|
||||||
return processes, nil
|
return servers, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// Note: Script also removes stale keys.
|
// Note: Script also removes stale keys.
|
||||||
@@ -830,3 +859,33 @@ func (r *RDB) ListWorkers() ([]*base.WorkerInfo, error) {
|
|||||||
}
|
}
|
||||||
return workers, nil
|
return workers, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// KEYS[1] -> asynq:paused
|
||||||
|
// ARGV[1] -> asynq:queues:<qname> - queue to pause
|
||||||
|
var pauseCmd = redis.NewScript(`
|
||||||
|
local ismem = redis.call("SISMEMBER", KEYS[1], ARGV[1])
|
||||||
|
if ismem == 1 then
|
||||||
|
return redis.error_reply("queue is already paused")
|
||||||
|
end
|
||||||
|
return redis.call("SADD", KEYS[1], ARGV[1])`)
|
||||||
|
|
||||||
|
// Pause pauses processing of tasks from the given queue.
|
||||||
|
func (r *RDB) Pause(qname string) error {
|
||||||
|
qkey := base.QueueKey(qname)
|
||||||
|
return pauseCmd.Run(r.client, []string{base.PausedQueues}, qkey).Err()
|
||||||
|
}
|
||||||
|
|
||||||
|
// KEYS[1] -> asynq:paused
|
||||||
|
// ARGV[1] -> asynq:queues:<qname> - queue to unpause
|
||||||
|
var unpauseCmd = redis.NewScript(`
|
||||||
|
local ismem = redis.call("SISMEMBER", KEYS[1], ARGV[1])
|
||||||
|
if ismem == 0 then
|
||||||
|
return redis.error_reply("queue is not paused")
|
||||||
|
end
|
||||||
|
return redis.call("SREM", KEYS[1], ARGV[1])`)
|
||||||
|
|
||||||
|
// Unpause resumes processing of tasks from the given queue.
|
||||||
|
func (r *RDB) Unpause(qname string) error {
|
||||||
|
qkey := base.QueueKey(qname)
|
||||||
|
return unpauseCmd.Run(r.client, []string{base.PausedQueues}, qkey).Err()
|
||||||
|
}
|
||||||
|
@@ -38,6 +38,7 @@ func TestCurrentStats(t *testing.T) {
|
|||||||
processed int
|
processed int
|
||||||
failed int
|
failed int
|
||||||
allQueues []interface{}
|
allQueues []interface{}
|
||||||
|
paused []string
|
||||||
want *Stats
|
want *Stats
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
@@ -55,6 +56,7 @@ func TestCurrentStats(t *testing.T) {
|
|||||||
processed: 120,
|
processed: 120,
|
||||||
failed: 2,
|
failed: 2,
|
||||||
allQueues: []interface{}{base.DefaultQueue, base.QueueKey("critical"), base.QueueKey("low")},
|
allQueues: []interface{}{base.DefaultQueue, base.QueueKey("critical"), base.QueueKey("low")},
|
||||||
|
paused: []string{},
|
||||||
want: &Stats{
|
want: &Stats{
|
||||||
Enqueued: 3,
|
Enqueued: 3,
|
||||||
InProgress: 1,
|
InProgress: 1,
|
||||||
@@ -64,7 +66,12 @@ func TestCurrentStats(t *testing.T) {
|
|||||||
Processed: 120,
|
Processed: 120,
|
||||||
Failed: 2,
|
Failed: 2,
|
||||||
Timestamp: now,
|
Timestamp: now,
|
||||||
Queues: map[string]int{base.DefaultQueueName: 1, "critical": 1, "low": 1},
|
// Queues should be sorted by name.
|
||||||
|
Queues: []*Queue{
|
||||||
|
{Name: "critical", Paused: false, Size: 1},
|
||||||
|
{Name: "default", Paused: false, Size: 1},
|
||||||
|
{Name: "low", Paused: false, Size: 1},
|
||||||
|
},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
@@ -82,6 +89,7 @@ func TestCurrentStats(t *testing.T) {
|
|||||||
processed: 90,
|
processed: 90,
|
||||||
failed: 10,
|
failed: 10,
|
||||||
allQueues: []interface{}{base.DefaultQueue},
|
allQueues: []interface{}{base.DefaultQueue},
|
||||||
|
paused: []string{},
|
||||||
want: &Stats{
|
want: &Stats{
|
||||||
Enqueued: 0,
|
Enqueued: 0,
|
||||||
InProgress: 0,
|
InProgress: 0,
|
||||||
@@ -91,13 +99,52 @@ func TestCurrentStats(t *testing.T) {
|
|||||||
Processed: 90,
|
Processed: 90,
|
||||||
Failed: 10,
|
Failed: 10,
|
||||||
Timestamp: now,
|
Timestamp: now,
|
||||||
Queues: map[string]int{base.DefaultQueueName: 0},
|
Queues: []*Queue{
|
||||||
|
{Name: base.DefaultQueueName, Paused: false, Size: 0},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
enqueued: map[string][]*base.TaskMessage{
|
||||||
|
base.DefaultQueueName: {m1},
|
||||||
|
"critical": {m5},
|
||||||
|
"low": {m6},
|
||||||
|
},
|
||||||
|
inProgress: []*base.TaskMessage{m2},
|
||||||
|
scheduled: []h.ZSetEntry{
|
||||||
|
{Msg: m3, Score: float64(now.Add(time.Hour).Unix())},
|
||||||
|
{Msg: m4, Score: float64(now.Unix())}},
|
||||||
|
retry: []h.ZSetEntry{},
|
||||||
|
dead: []h.ZSetEntry{},
|
||||||
|
processed: 120,
|
||||||
|
failed: 2,
|
||||||
|
allQueues: []interface{}{base.DefaultQueue, base.QueueKey("critical"), base.QueueKey("low")},
|
||||||
|
paused: []string{"critical", "low"},
|
||||||
|
want: &Stats{
|
||||||
|
Enqueued: 3,
|
||||||
|
InProgress: 1,
|
||||||
|
Scheduled: 2,
|
||||||
|
Retry: 0,
|
||||||
|
Dead: 0,
|
||||||
|
Processed: 120,
|
||||||
|
Failed: 2,
|
||||||
|
Timestamp: now,
|
||||||
|
Queues: []*Queue{
|
||||||
|
{Name: "critical", Paused: true, Size: 1},
|
||||||
|
{Name: "default", Paused: false, Size: 1},
|
||||||
|
{Name: "low", Paused: true, Size: 1},
|
||||||
|
},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
h.FlushDB(t, r.client) // clean up db before each test case
|
h.FlushDB(t, r.client) // clean up db before each test case
|
||||||
|
for _, qname := range tc.paused {
|
||||||
|
if err := r.Pause(qname); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
for qname, msgs := range tc.enqueued {
|
for qname, msgs := range tc.enqueued {
|
||||||
h.SeedEnqueuedQueue(t, r.client, msgs, qname)
|
h.SeedEnqueuedQueue(t, r.client, msgs, qname)
|
||||||
}
|
}
|
||||||
@@ -136,7 +183,7 @@ func TestCurrentStatsWithoutData(t *testing.T) {
|
|||||||
Processed: 0,
|
Processed: 0,
|
||||||
Failed: 0,
|
Failed: 0,
|
||||||
Timestamp: time.Now(),
|
Timestamp: time.Now(),
|
||||||
Queues: map[string]int{},
|
Queues: make([]*Queue, 0),
|
||||||
}
|
}
|
||||||
|
|
||||||
got, err := r.CurrentStats()
|
got, err := r.CurrentStats()
|
||||||
@@ -658,12 +705,14 @@ func TestListRetry(t *testing.T) {
|
|||||||
func TestListRetryPagination(t *testing.T) {
|
func TestListRetryPagination(t *testing.T) {
|
||||||
r := setup(t)
|
r := setup(t)
|
||||||
// create 100 tasks with an increasing number of wait time.
|
// create 100 tasks with an increasing number of wait time.
|
||||||
|
now := time.Now()
|
||||||
|
var seed []h.ZSetEntry
|
||||||
for i := 0; i < 100; i++ {
|
for i := 0; i < 100; i++ {
|
||||||
msg := h.NewTaskMessage(fmt.Sprintf("task %d", i), nil)
|
msg := h.NewTaskMessage(fmt.Sprintf("task %d", i), nil)
|
||||||
if err := r.Retry(msg, time.Now().Add(time.Duration(i)*time.Second), "error"); err != nil {
|
processAt := now.Add(time.Duration(i) * time.Second)
|
||||||
t.Fatal(err)
|
seed = append(seed, h.ZSetEntry{Msg: msg, Score: float64(processAt.Unix())})
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
h.SeedRetryQueue(t, r.client, seed)
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
desc string
|
desc string
|
||||||
@@ -2051,74 +2100,63 @@ func TestRemoveQueueError(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestListProcesses(t *testing.T) {
|
func TestListServers(t *testing.T) {
|
||||||
r := setup(t)
|
r := setup(t)
|
||||||
|
|
||||||
started1 := time.Now().Add(-time.Hour)
|
started1 := time.Now().Add(-time.Hour)
|
||||||
ps1 := base.NewProcessState("do.droplet1", 1234, 10, map[string]int{"default": 1}, false)
|
info1 := &base.ServerInfo{
|
||||||
ps1.SetStarted(started1)
|
|
||||||
ps1.SetStatus(base.StatusRunning)
|
|
||||||
info1 := &base.ProcessInfo{
|
|
||||||
Concurrency: 10,
|
|
||||||
Queues: map[string]int{"default": 1},
|
|
||||||
Host: "do.droplet1",
|
Host: "do.droplet1",
|
||||||
PID: 1234,
|
PID: 1234,
|
||||||
|
ServerID: "server123",
|
||||||
|
Concurrency: 10,
|
||||||
|
Queues: map[string]int{"default": 1},
|
||||||
Status: "running",
|
Status: "running",
|
||||||
Started: started1,
|
Started: started1,
|
||||||
ActiveWorkerCount: 0,
|
ActiveWorkerCount: 0,
|
||||||
}
|
}
|
||||||
|
|
||||||
started2 := time.Now().Add(-2 * time.Hour)
|
started2 := time.Now().Add(-2 * time.Hour)
|
||||||
ps2 := base.NewProcessState("do.droplet2", 9876, 20, map[string]int{"email": 1}, false)
|
info2 := &base.ServerInfo{
|
||||||
ps2.SetStarted(started2)
|
|
||||||
ps2.SetStatus(base.StatusStopped)
|
|
||||||
ps2.AddWorkerStats(h.NewTaskMessage("send_email", nil), time.Now())
|
|
||||||
info2 := &base.ProcessInfo{
|
|
||||||
Concurrency: 20,
|
|
||||||
Queues: map[string]int{"email": 1},
|
|
||||||
Host: "do.droplet2",
|
Host: "do.droplet2",
|
||||||
PID: 9876,
|
PID: 9876,
|
||||||
|
ServerID: "server456",
|
||||||
|
Concurrency: 20,
|
||||||
|
Queues: map[string]int{"email": 1},
|
||||||
Status: "stopped",
|
Status: "stopped",
|
||||||
Started: started2,
|
Started: started2,
|
||||||
ActiveWorkerCount: 1,
|
ActiveWorkerCount: 1,
|
||||||
}
|
}
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
processes []*base.ProcessState
|
data []*base.ServerInfo
|
||||||
want []*base.ProcessInfo
|
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
processes: []*base.ProcessState{},
|
data: []*base.ServerInfo{},
|
||||||
want: []*base.ProcessInfo{},
|
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
processes: []*base.ProcessState{ps1},
|
data: []*base.ServerInfo{info1},
|
||||||
want: []*base.ProcessInfo{info1},
|
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
processes: []*base.ProcessState{ps1, ps2},
|
data: []*base.ServerInfo{info1, info2},
|
||||||
want: []*base.ProcessInfo{info1, info2},
|
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
ignoreOpt := cmpopts.IgnoreUnexported(base.ProcessInfo{})
|
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
h.FlushDB(t, r.client)
|
h.FlushDB(t, r.client)
|
||||||
|
|
||||||
for _, ps := range tc.processes {
|
for _, info := range tc.data {
|
||||||
if err := r.WriteProcessState(ps, 5*time.Second); err != nil {
|
if err := r.WriteServerState(info, []*base.WorkerInfo{}, 5*time.Second); err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
got, err := r.ListProcesses()
|
got, err := r.ListServers()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Errorf("r.ListProcesses returned an error: %v", err)
|
t.Errorf("r.ListServers returned an error: %v", err)
|
||||||
}
|
}
|
||||||
if diff := cmp.Diff(tc.want, got, h.SortProcessInfoOpt, ignoreOpt); diff != "" {
|
if diff := cmp.Diff(tc.data, got, h.SortServerInfoOpt); diff != "" {
|
||||||
t.Errorf("r.ListProcesses returned %v, want %v; (-want,+got)\n%s",
|
t.Errorf("r.ListServers returned %v, want %v; (-want,+got)\n%s",
|
||||||
got, tc.processes, diff)
|
got, tc.data, diff)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -2126,37 +2164,23 @@ func TestListProcesses(t *testing.T) {
|
|||||||
func TestListWorkers(t *testing.T) {
|
func TestListWorkers(t *testing.T) {
|
||||||
r := setup(t)
|
r := setup(t)
|
||||||
|
|
||||||
const (
|
var (
|
||||||
host = "127.0.0.1"
|
host = "127.0.0.1"
|
||||||
pid = 4567
|
pid = 4567
|
||||||
|
|
||||||
|
m1 = h.NewTaskMessage("send_email", map[string]interface{}{"user_id": "abc123"})
|
||||||
|
m2 = h.NewTaskMessage("gen_thumbnail", map[string]interface{}{"path": "some/path/to/image/file"})
|
||||||
|
m3 = h.NewTaskMessage("reindex", map[string]interface{}{})
|
||||||
)
|
)
|
||||||
|
|
||||||
m1 := h.NewTaskMessage("send_email", map[string]interface{}{"user_id": "abc123"})
|
|
||||||
m2 := h.NewTaskMessage("gen_thumbnail", map[string]interface{}{"path": "some/path/to/image/file"})
|
|
||||||
m3 := h.NewTaskMessage("reindex", map[string]interface{}{})
|
|
||||||
t1 := time.Now().Add(-time.Second)
|
|
||||||
t2 := time.Now().Add(-10 * time.Second)
|
|
||||||
t3 := time.Now().Add(-time.Minute)
|
|
||||||
|
|
||||||
type workerStats struct {
|
|
||||||
msg *base.TaskMessage
|
|
||||||
started time.Time
|
|
||||||
}
|
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
workers []*workerStats
|
data []*base.WorkerInfo
|
||||||
want []*base.WorkerInfo
|
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
workers: []*workerStats{
|
data: []*base.WorkerInfo{
|
||||||
{m1, t1},
|
{Host: host, PID: pid, ID: m1.ID.String(), Type: m1.Type, Queue: m1.Queue, Payload: m1.Payload, Started: time.Now().Add(-1 * time.Second)},
|
||||||
{m2, t2},
|
{Host: host, PID: pid, ID: m2.ID.String(), Type: m2.Type, Queue: m2.Queue, Payload: m2.Payload, Started: time.Now().Add(-5 * time.Second)},
|
||||||
{m3, t3},
|
{Host: host, PID: pid, ID: m3.ID.String(), Type: m3.Type, Queue: m3.Queue, Payload: m3.Payload, Started: time.Now().Add(-30 * time.Second)},
|
||||||
},
|
|
||||||
want: []*base.WorkerInfo{
|
|
||||||
{Host: host, PID: pid, ID: m1.ID, Type: m1.Type, Queue: m1.Queue, Payload: m1.Payload, Started: t1},
|
|
||||||
{Host: host, PID: pid, ID: m2.ID, Type: m2.Type, Queue: m2.Queue, Payload: m2.Payload, Started: t2},
|
|
||||||
{Host: host, PID: pid, ID: m3.ID, Type: m3.Type, Queue: m3.Queue, Payload: m3.Payload, Started: t3},
|
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
@@ -2164,15 +2188,9 @@ func TestListWorkers(t *testing.T) {
|
|||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
h.FlushDB(t, r.client)
|
h.FlushDB(t, r.client)
|
||||||
|
|
||||||
ps := base.NewProcessState(host, pid, 10, map[string]int{"default": 1}, false)
|
err := r.WriteServerState(&base.ServerInfo{}, tc.data, time.Minute)
|
||||||
|
|
||||||
for _, w := range tc.workers {
|
|
||||||
ps.AddWorkerStats(w.msg, w.started)
|
|
||||||
}
|
|
||||||
|
|
||||||
err := r.WriteProcessState(ps, time.Minute)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Errorf("could not write process state to redis: %v", err)
|
t.Errorf("could not write server state to redis: %v", err)
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2182,8 +2200,165 @@ func TestListWorkers(t *testing.T) {
|
|||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
if diff := cmp.Diff(tc.want, got, h.SortWorkerInfoOpt); diff != "" {
|
if diff := cmp.Diff(tc.data, got, h.SortWorkerInfoOpt); diff != "" {
|
||||||
t.Errorf("(*RDB).ListWorkers() = %v, want = %v; (-want,+got)\n%s", got, tc.want, diff)
|
t.Errorf("(*RDB).ListWorkers() = %v, want = %v; (-want,+got)\n%s", got, tc.data, diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPause(t *testing.T) {
|
||||||
|
r := setup(t)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
initial []string // initial keys in the paused set
|
||||||
|
qname string // name of the queue to pause
|
||||||
|
want []string // expected keys in the paused set
|
||||||
|
}{
|
||||||
|
{[]string{}, "default", []string{"asynq:queues:default"}},
|
||||||
|
{[]string{"asynq:queues:default"}, "critical", []string{"asynq:queues:default", "asynq:queues:critical"}},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
h.FlushDB(t, r.client)
|
||||||
|
|
||||||
|
// Set up initial state.
|
||||||
|
for _, qkey := range tc.initial {
|
||||||
|
if err := r.client.SAdd(base.PausedQueues, qkey).Err(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
err := r.Pause(tc.qname)
|
||||||
|
if err != nil {
|
||||||
|
t.Errorf("Pause(%q) returned error: %v", tc.qname, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
got, err := r.client.SMembers(base.PausedQueues).Result()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
if diff := cmp.Diff(tc.want, got, h.SortStringSliceOpt); diff != "" {
|
||||||
|
t.Errorf("%q has members %v, want %v; (-want,+got)\n%s",
|
||||||
|
base.PausedQueues, got, tc.want, diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPauseError(t *testing.T) {
|
||||||
|
r := setup(t)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
desc string // test case description
|
||||||
|
initial []string // initial keys in the paused set
|
||||||
|
qname string // name of the queue to pause
|
||||||
|
want []string // expected keys in the paused set
|
||||||
|
}{
|
||||||
|
{"queue already paused", []string{"asynq:queues:default"}, "default", []string{"asynq:queues:default"}},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
h.FlushDB(t, r.client)
|
||||||
|
|
||||||
|
// Set up initial state.
|
||||||
|
for _, qkey := range tc.initial {
|
||||||
|
if err := r.client.SAdd(base.PausedQueues, qkey).Err(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
err := r.Pause(tc.qname)
|
||||||
|
if err == nil {
|
||||||
|
t.Errorf("%s; Pause(%q) returned nil: want error", tc.desc, tc.qname)
|
||||||
|
}
|
||||||
|
|
||||||
|
got, err := r.client.SMembers(base.PausedQueues).Result()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
if diff := cmp.Diff(tc.want, got, h.SortStringSliceOpt); diff != "" {
|
||||||
|
t.Errorf("%s; %q has members %v, want %v; (-want,+got)\n%s",
|
||||||
|
tc.desc, base.PausedQueues, got, tc.want, diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestUnpause(t *testing.T) {
|
||||||
|
r := setup(t)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
initial []string // initial keys in the paused set
|
||||||
|
qname string // name of the queue to unpause
|
||||||
|
want []string // expected keys in the paused set
|
||||||
|
}{
|
||||||
|
{[]string{"asynq:queues:default"}, "default", []string{}},
|
||||||
|
{[]string{"asynq:queues:default", "asynq:queues:low"}, "low", []string{"asynq:queues:default"}},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
h.FlushDB(t, r.client)
|
||||||
|
|
||||||
|
// Set up initial state.
|
||||||
|
for _, qkey := range tc.initial {
|
||||||
|
if err := r.client.SAdd(base.PausedQueues, qkey).Err(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
err := r.Unpause(tc.qname)
|
||||||
|
if err != nil {
|
||||||
|
t.Errorf("Unpause(%q) returned error: %v", tc.qname, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
got, err := r.client.SMembers(base.PausedQueues).Result()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
if diff := cmp.Diff(tc.want, got, h.SortStringSliceOpt); diff != "" {
|
||||||
|
t.Errorf("%q has members %v, want %v; (-want,+got)\n%s",
|
||||||
|
base.PausedQueues, got, tc.want, diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestUnpauseError(t *testing.T) {
|
||||||
|
r := setup(t)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
desc string // test case description
|
||||||
|
initial []string // initial keys in the paused set
|
||||||
|
qname string // name of the queue to unpause
|
||||||
|
want []string // expected keys in the paused set
|
||||||
|
}{
|
||||||
|
{"set is empty", []string{}, "default", []string{}},
|
||||||
|
{"queue is not in the set", []string{"asynq:queues:default"}, "low", []string{"asynq:queues:default"}},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
h.FlushDB(t, r.client)
|
||||||
|
|
||||||
|
// Set up initial state.
|
||||||
|
for _, qkey := range tc.initial {
|
||||||
|
if err := r.client.SAdd(base.PausedQueues, qkey).Err(); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
err := r.Unpause(tc.qname)
|
||||||
|
if err == nil {
|
||||||
|
t.Errorf("%s; Unpause(%q) returned nil: want error", tc.desc, tc.qname)
|
||||||
|
}
|
||||||
|
|
||||||
|
got, err := r.client.SMembers(base.PausedQueues).Result()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
if diff := cmp.Diff(tc.want, got, h.SortStringSliceOpt); diff != "" {
|
||||||
|
t.Errorf("%s; %q has members %v, want %v; (-want,+got)\n%s",
|
||||||
|
tc.desc, base.PausedQueues, got, tc.want, diff)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@@ -54,12 +54,12 @@ return 1`)
|
|||||||
|
|
||||||
// Enqueue inserts the given task to the tail of the queue.
|
// Enqueue inserts the given task to the tail of the queue.
|
||||||
func (r *RDB) Enqueue(msg *base.TaskMessage) error {
|
func (r *RDB) Enqueue(msg *base.TaskMessage) error {
|
||||||
bytes, err := json.Marshal(msg)
|
encoded, err := base.EncodeMessage(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
key := base.QueueKey(msg.Queue)
|
key := base.QueueKey(msg.Queue)
|
||||||
return enqueueCmd.Run(r.client, []string{key, base.AllQueues}, bytes).Err()
|
return enqueueCmd.Run(r.client, []string{key, base.AllQueues}, encoded).Err()
|
||||||
}
|
}
|
||||||
|
|
||||||
// KEYS[1] -> unique key in the form <type>:<payload>:<qname>
|
// KEYS[1] -> unique key in the form <type>:<payload>:<qname>
|
||||||
@@ -81,14 +81,14 @@ return 1
|
|||||||
// EnqueueUnique inserts the given task if the task's uniqueness lock can be acquired.
|
// EnqueueUnique inserts the given task if the task's uniqueness lock can be acquired.
|
||||||
// It returns ErrDuplicateTask if the lock cannot be acquired.
|
// It returns ErrDuplicateTask if the lock cannot be acquired.
|
||||||
func (r *RDB) EnqueueUnique(msg *base.TaskMessage, ttl time.Duration) error {
|
func (r *RDB) EnqueueUnique(msg *base.TaskMessage, ttl time.Duration) error {
|
||||||
bytes, err := json.Marshal(msg)
|
encoded, err := base.EncodeMessage(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
key := base.QueueKey(msg.Queue)
|
key := base.QueueKey(msg.Queue)
|
||||||
res, err := enqueueUniqueCmd.Run(r.client,
|
res, err := enqueueUniqueCmd.Run(r.client,
|
||||||
[]string{msg.UniqueKey, key, base.AllQueues},
|
[]string{msg.UniqueKey, key, base.AllQueues},
|
||||||
msg.ID.String(), int(ttl.Seconds()), bytes).Result()
|
msg.ID.String(), int(ttl.Seconds()), encoded).Result()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -103,56 +103,43 @@ func (r *RDB) EnqueueUnique(msg *base.TaskMessage, ttl time.Duration) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Dequeue queries given queues in order and pops a task message if there is one and returns it.
|
// Dequeue queries given queues in order and pops a task message if there is one and returns it.
|
||||||
|
// Dequeue skips a queue if the queue is paused.
|
||||||
// If all queues are empty, ErrNoProcessableTask error is returned.
|
// If all queues are empty, ErrNoProcessableTask error is returned.
|
||||||
func (r *RDB) Dequeue(qnames ...string) (*base.TaskMessage, error) {
|
func (r *RDB) Dequeue(qnames ...string) (*base.TaskMessage, error) {
|
||||||
var data string
|
var qkeys []interface{}
|
||||||
var err error
|
for _, q := range qnames {
|
||||||
if len(qnames) == 1 {
|
qkeys = append(qkeys, base.QueueKey(q))
|
||||||
data, err = r.dequeueSingle(base.QueueKey(qnames[0]))
|
|
||||||
} else {
|
|
||||||
var keys []string
|
|
||||||
for _, q := range qnames {
|
|
||||||
keys = append(keys, base.QueueKey(q))
|
|
||||||
}
|
|
||||||
data, err = r.dequeue(keys...)
|
|
||||||
}
|
}
|
||||||
|
data, err := r.dequeue(qkeys...)
|
||||||
if err == redis.Nil {
|
if err == redis.Nil {
|
||||||
return nil, ErrNoProcessableTask
|
return nil, ErrNoProcessableTask
|
||||||
}
|
}
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
var msg base.TaskMessage
|
return base.DecodeMessage(data)
|
||||||
err = json.Unmarshal([]byte(data), &msg)
|
|
||||||
if err != nil {
|
|
||||||
return nil, err
|
|
||||||
}
|
|
||||||
return &msg, nil
|
|
||||||
}
|
|
||||||
|
|
||||||
func (r *RDB) dequeueSingle(queue string) (data string, err error) {
|
|
||||||
// timeout needed to avoid blocking forever
|
|
||||||
return r.client.BRPopLPush(queue, base.InProgressQueue, time.Second).Result()
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// KEYS[1] -> asynq:in_progress
|
// KEYS[1] -> asynq:in_progress
|
||||||
|
// KEYS[2] -> asynq:paused
|
||||||
// ARGV -> List of queues to query in order
|
// ARGV -> List of queues to query in order
|
||||||
|
//
|
||||||
|
// dequeueCmd checks whether a queue is paused first, before
|
||||||
|
// calling RPOPLPUSH to pop a task from the queue.
|
||||||
var dequeueCmd = redis.NewScript(`
|
var dequeueCmd = redis.NewScript(`
|
||||||
local res
|
|
||||||
for _, qkey in ipairs(ARGV) do
|
for _, qkey in ipairs(ARGV) do
|
||||||
res = redis.call("RPOPLPUSH", qkey, KEYS[1])
|
if redis.call("SISMEMBER", KEYS[2], qkey) == 0 then
|
||||||
if res then
|
local res = redis.call("RPOPLPUSH", qkey, KEYS[1])
|
||||||
return res
|
if res then
|
||||||
|
return res
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
return res`)
|
return nil`)
|
||||||
|
|
||||||
func (r *RDB) dequeue(queues ...string) (data string, err error) {
|
func (r *RDB) dequeue(qkeys ...interface{}) (data string, err error) {
|
||||||
var args []interface{}
|
res, err := dequeueCmd.Run(r.client,
|
||||||
for _, qkey := range queues {
|
[]string{base.InProgressQueue, base.PausedQueues}, qkeys...).Result()
|
||||||
args = append(args, qkey)
|
|
||||||
}
|
|
||||||
res, err := dequeueCmd.Run(r.client, []string{base.InProgressQueue}, args...).Result()
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return "", err
|
return "", err
|
||||||
}
|
}
|
||||||
@@ -167,7 +154,10 @@ func (r *RDB) dequeue(queues ...string) (data string, err error) {
|
|||||||
// ARGV[3] -> task ID
|
// ARGV[3] -> task ID
|
||||||
// Note: LREM count ZERO means "remove all elements equal to val"
|
// Note: LREM count ZERO means "remove all elements equal to val"
|
||||||
var doneCmd = redis.NewScript(`
|
var doneCmd = redis.NewScript(`
|
||||||
redis.call("LREM", KEYS[1], 0, ARGV[1])
|
local x = redis.call("LREM", KEYS[1], 0, ARGV[1])
|
||||||
|
if x == 0 then
|
||||||
|
return redis.error_reply("NOT FOUND")
|
||||||
|
end
|
||||||
local n = redis.call("INCR", KEYS[2])
|
local n = redis.call("INCR", KEYS[2])
|
||||||
if tonumber(n) == 1 then
|
if tonumber(n) == 1 then
|
||||||
redis.call("EXPIREAT", KEYS[2], ARGV[2])
|
redis.call("EXPIREAT", KEYS[2], ARGV[2])
|
||||||
@@ -181,7 +171,7 @@ return redis.status_reply("OK")
|
|||||||
// Done removes the task from in-progress queue to mark the task as done.
|
// Done removes the task from in-progress queue to mark the task as done.
|
||||||
// It removes a uniqueness lock acquired by the task, if any.
|
// It removes a uniqueness lock acquired by the task, if any.
|
||||||
func (r *RDB) Done(msg *base.TaskMessage) error {
|
func (r *RDB) Done(msg *base.TaskMessage) error {
|
||||||
bytes, err := json.Marshal(msg)
|
encoded, err := base.EncodeMessage(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -190,7 +180,7 @@ func (r *RDB) Done(msg *base.TaskMessage) error {
|
|||||||
expireAt := now.Add(statsTTL)
|
expireAt := now.Add(statsTTL)
|
||||||
return doneCmd.Run(r.client,
|
return doneCmd.Run(r.client,
|
||||||
[]string{base.InProgressQueue, processedKey, msg.UniqueKey},
|
[]string{base.InProgressQueue, processedKey, msg.UniqueKey},
|
||||||
bytes, expireAt.Unix(), msg.ID.String()).Err()
|
encoded, expireAt.Unix(), msg.ID.String()).Err()
|
||||||
}
|
}
|
||||||
|
|
||||||
// KEYS[1] -> asynq:in_progress
|
// KEYS[1] -> asynq:in_progress
|
||||||
@@ -204,13 +194,13 @@ return redis.status_reply("OK")`)
|
|||||||
|
|
||||||
// Requeue moves the task from in-progress queue to the specified queue.
|
// Requeue moves the task from in-progress queue to the specified queue.
|
||||||
func (r *RDB) Requeue(msg *base.TaskMessage) error {
|
func (r *RDB) Requeue(msg *base.TaskMessage) error {
|
||||||
bytes, err := json.Marshal(msg)
|
encoded, err := base.EncodeMessage(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
return requeueCmd.Run(r.client,
|
return requeueCmd.Run(r.client,
|
||||||
[]string{base.InProgressQueue, base.QueueKey(msg.Queue)},
|
[]string{base.InProgressQueue, base.QueueKey(msg.Queue)},
|
||||||
string(bytes)).Err()
|
encoded).Err()
|
||||||
}
|
}
|
||||||
|
|
||||||
// KEYS[1] -> asynq:scheduled
|
// KEYS[1] -> asynq:scheduled
|
||||||
@@ -226,7 +216,7 @@ return 1
|
|||||||
|
|
||||||
// Schedule adds the task to the backlog queue to be processed in the future.
|
// Schedule adds the task to the backlog queue to be processed in the future.
|
||||||
func (r *RDB) Schedule(msg *base.TaskMessage, processAt time.Time) error {
|
func (r *RDB) Schedule(msg *base.TaskMessage, processAt time.Time) error {
|
||||||
bytes, err := json.Marshal(msg)
|
encoded, err := base.EncodeMessage(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -234,7 +224,7 @@ func (r *RDB) Schedule(msg *base.TaskMessage, processAt time.Time) error {
|
|||||||
score := float64(processAt.Unix())
|
score := float64(processAt.Unix())
|
||||||
return scheduleCmd.Run(r.client,
|
return scheduleCmd.Run(r.client,
|
||||||
[]string{base.ScheduledQueue, base.AllQueues},
|
[]string{base.ScheduledQueue, base.AllQueues},
|
||||||
score, bytes, qkey).Err()
|
score, encoded, qkey).Err()
|
||||||
}
|
}
|
||||||
|
|
||||||
// KEYS[1] -> unique key in the format <type>:<payload>:<qname>
|
// KEYS[1] -> unique key in the format <type>:<payload>:<qname>
|
||||||
@@ -258,7 +248,7 @@ return 1
|
|||||||
// ScheduleUnique adds the task to the backlog queue to be processed in the future if the uniqueness lock can be acquired.
|
// ScheduleUnique adds the task to the backlog queue to be processed in the future if the uniqueness lock can be acquired.
|
||||||
// It returns ErrDuplicateTask if the lock cannot be acquired.
|
// It returns ErrDuplicateTask if the lock cannot be acquired.
|
||||||
func (r *RDB) ScheduleUnique(msg *base.TaskMessage, processAt time.Time, ttl time.Duration) error {
|
func (r *RDB) ScheduleUnique(msg *base.TaskMessage, processAt time.Time, ttl time.Duration) error {
|
||||||
bytes, err := json.Marshal(msg)
|
encoded, err := base.EncodeMessage(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -266,7 +256,7 @@ func (r *RDB) ScheduleUnique(msg *base.TaskMessage, processAt time.Time, ttl tim
|
|||||||
score := float64(processAt.Unix())
|
score := float64(processAt.Unix())
|
||||||
res, err := scheduleUniqueCmd.Run(r.client,
|
res, err := scheduleUniqueCmd.Run(r.client,
|
||||||
[]string{msg.UniqueKey, base.ScheduledQueue, base.AllQueues},
|
[]string{msg.UniqueKey, base.ScheduledQueue, base.AllQueues},
|
||||||
msg.ID.String(), int(ttl.Seconds()), score, bytes, qkey).Result()
|
msg.ID.String(), int(ttl.Seconds()), score, encoded, qkey).Result()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -289,7 +279,10 @@ func (r *RDB) ScheduleUnique(msg *base.TaskMessage, processAt time.Time, ttl tim
|
|||||||
// ARGV[3] -> retry_at UNIX timestamp
|
// ARGV[3] -> retry_at UNIX timestamp
|
||||||
// ARGV[4] -> stats expiration timestamp
|
// ARGV[4] -> stats expiration timestamp
|
||||||
var retryCmd = redis.NewScript(`
|
var retryCmd = redis.NewScript(`
|
||||||
redis.call("LREM", KEYS[1], 0, ARGV[1])
|
local x = redis.call("LREM", KEYS[1], 0, ARGV[1])
|
||||||
|
if x == 0 then
|
||||||
|
return redis.error_reply("NOT FOUND")
|
||||||
|
end
|
||||||
redis.call("ZADD", KEYS[2], ARGV[3], ARGV[2])
|
redis.call("ZADD", KEYS[2], ARGV[3], ARGV[2])
|
||||||
local n = redis.call("INCR", KEYS[3])
|
local n = redis.call("INCR", KEYS[3])
|
||||||
if tonumber(n) == 1 then
|
if tonumber(n) == 1 then
|
||||||
@@ -304,14 +297,14 @@ return redis.status_reply("OK")`)
|
|||||||
// Retry moves the task from in-progress to retry queue, incrementing retry count
|
// Retry moves the task from in-progress to retry queue, incrementing retry count
|
||||||
// and assigning error message to the task message.
|
// and assigning error message to the task message.
|
||||||
func (r *RDB) Retry(msg *base.TaskMessage, processAt time.Time, errMsg string) error {
|
func (r *RDB) Retry(msg *base.TaskMessage, processAt time.Time, errMsg string) error {
|
||||||
bytesToRemove, err := json.Marshal(msg)
|
msgToRemove, err := base.EncodeMessage(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
modified := *msg
|
modified := *msg
|
||||||
modified.Retried++
|
modified.Retried++
|
||||||
modified.ErrorMsg = errMsg
|
modified.ErrorMsg = errMsg
|
||||||
bytesToAdd, err := json.Marshal(&modified)
|
msgToAdd, err := base.EncodeMessage(&modified)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -321,7 +314,7 @@ func (r *RDB) Retry(msg *base.TaskMessage, processAt time.Time, errMsg string) e
|
|||||||
expireAt := now.Add(statsTTL)
|
expireAt := now.Add(statsTTL)
|
||||||
return retryCmd.Run(r.client,
|
return retryCmd.Run(r.client,
|
||||||
[]string{base.InProgressQueue, base.RetryQueue, processedKey, failureKey},
|
[]string{base.InProgressQueue, base.RetryQueue, processedKey, failureKey},
|
||||||
string(bytesToRemove), string(bytesToAdd), processAt.Unix(), expireAt.Unix()).Err()
|
msgToRemove, msgToAdd, processAt.Unix(), expireAt.Unix()).Err()
|
||||||
}
|
}
|
||||||
|
|
||||||
const (
|
const (
|
||||||
@@ -340,7 +333,10 @@ const (
|
|||||||
// ARGV[5] -> max number of tasks in dead queue (e.g., 100)
|
// ARGV[5] -> max number of tasks in dead queue (e.g., 100)
|
||||||
// ARGV[6] -> stats expiration timestamp
|
// ARGV[6] -> stats expiration timestamp
|
||||||
var killCmd = redis.NewScript(`
|
var killCmd = redis.NewScript(`
|
||||||
redis.call("LREM", KEYS[1], 0, ARGV[1])
|
local x = redis.call("LREM", KEYS[1], 0, ARGV[1])
|
||||||
|
if x == 0 then
|
||||||
|
return redis.error_reply("NOT FOUND")
|
||||||
|
end
|
||||||
redis.call("ZADD", KEYS[2], ARGV[3], ARGV[2])
|
redis.call("ZADD", KEYS[2], ARGV[3], ARGV[2])
|
||||||
redis.call("ZREMRANGEBYSCORE", KEYS[2], "-inf", ARGV[4])
|
redis.call("ZREMRANGEBYSCORE", KEYS[2], "-inf", ARGV[4])
|
||||||
redis.call("ZREMRANGEBYRANK", KEYS[2], 0, -ARGV[5])
|
redis.call("ZREMRANGEBYRANK", KEYS[2], 0, -ARGV[5])
|
||||||
@@ -358,13 +354,13 @@ return redis.status_reply("OK")`)
|
|||||||
// the error message to the task.
|
// the error message to the task.
|
||||||
// It also trims the set by timestamp and set size.
|
// It also trims the set by timestamp and set size.
|
||||||
func (r *RDB) Kill(msg *base.TaskMessage, errMsg string) error {
|
func (r *RDB) Kill(msg *base.TaskMessage, errMsg string) error {
|
||||||
bytesToRemove, err := json.Marshal(msg)
|
msgToRemove, err := base.EncodeMessage(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
modified := *msg
|
modified := *msg
|
||||||
modified.ErrorMsg = errMsg
|
modified.ErrorMsg = errMsg
|
||||||
bytesToAdd, err := json.Marshal(&modified)
|
msgToAdd, err := base.EncodeMessage(&modified)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -375,7 +371,7 @@ func (r *RDB) Kill(msg *base.TaskMessage, errMsg string) error {
|
|||||||
expireAt := now.Add(statsTTL)
|
expireAt := now.Add(statsTTL)
|
||||||
return killCmd.Run(r.client,
|
return killCmd.Run(r.client,
|
||||||
[]string{base.InProgressQueue, base.DeadQueue, processedKey, failureKey},
|
[]string{base.InProgressQueue, base.DeadQueue, processedKey, failureKey},
|
||||||
string(bytesToRemove), string(bytesToAdd), now.Unix(), limit, maxDeadTasks, expireAt.Unix()).Err()
|
msgToRemove, msgToAdd, now.Unix(), limit, maxDeadTasks, expireAt.Unix()).Err()
|
||||||
}
|
}
|
||||||
|
|
||||||
// KEYS[1] -> asynq:in_progress
|
// KEYS[1] -> asynq:in_progress
|
||||||
@@ -404,21 +400,17 @@ func (r *RDB) RequeueAll() (int64, error) {
|
|||||||
return n, nil
|
return n, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// CheckAndEnqueue checks for all scheduled tasks and enqueues any tasks that
|
// CheckAndEnqueue checks for all scheduled/retry tasks and enqueues any tasks that
|
||||||
// have to be processed.
|
// are ready to be processed.
|
||||||
//
|
func (r *RDB) CheckAndEnqueue() (err error) {
|
||||||
// qnames specifies to which queues to send tasks.
|
|
||||||
func (r *RDB) CheckAndEnqueue(qnames ...string) error {
|
|
||||||
delayed := []string{base.ScheduledQueue, base.RetryQueue}
|
delayed := []string{base.ScheduledQueue, base.RetryQueue}
|
||||||
for _, zset := range delayed {
|
for _, zset := range delayed {
|
||||||
var err error
|
n := 1
|
||||||
if len(qnames) == 1 {
|
for n != 0 {
|
||||||
err = r.forwardSingle(zset, base.QueueKey(qnames[0]))
|
n, err = r.forward(zset)
|
||||||
} else {
|
if err != nil {
|
||||||
err = r.forward(zset)
|
return err
|
||||||
}
|
}
|
||||||
if err != nil {
|
|
||||||
return err
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return nil
|
return nil
|
||||||
@@ -427,53 +419,40 @@ func (r *RDB) CheckAndEnqueue(qnames ...string) error {
|
|||||||
// KEYS[1] -> source queue (e.g. scheduled or retry queue)
|
// KEYS[1] -> source queue (e.g. scheduled or retry queue)
|
||||||
// ARGV[1] -> current unix time
|
// ARGV[1] -> current unix time
|
||||||
// ARGV[2] -> queue prefix
|
// ARGV[2] -> queue prefix
|
||||||
|
// Note: Script moves tasks up to 100 at a time to keep the runtime of script short.
|
||||||
var forwardCmd = redis.NewScript(`
|
var forwardCmd = redis.NewScript(`
|
||||||
local msgs = redis.call("ZRANGEBYSCORE", KEYS[1], "-inf", ARGV[1])
|
local msgs = redis.call("ZRANGEBYSCORE", KEYS[1], "-inf", ARGV[1], "LIMIT", 0, 100)
|
||||||
for _, msg in ipairs(msgs) do
|
for _, msg in ipairs(msgs) do
|
||||||
local decoded = cjson.decode(msg)
|
local decoded = cjson.decode(msg)
|
||||||
local qkey = ARGV[2] .. decoded["Queue"]
|
local qkey = ARGV[2] .. decoded["Queue"]
|
||||||
redis.call("LPUSH", qkey, msg)
|
redis.call("LPUSH", qkey, msg)
|
||||||
redis.call("ZREM", KEYS[1], msg)
|
redis.call("ZREM", KEYS[1], msg)
|
||||||
end
|
end
|
||||||
return msgs`)
|
return table.getn(msgs)`)
|
||||||
|
|
||||||
// forward moves all tasks with a score less than the current unix time
|
// forward moves tasks with a score less than the current unix time
|
||||||
// from the src zset.
|
// from the src zset. It returns the number of tasks moved.
|
||||||
func (r *RDB) forward(src string) error {
|
func (r *RDB) forward(src string) (int, error) {
|
||||||
now := float64(time.Now().Unix())
|
now := float64(time.Now().Unix())
|
||||||
return forwardCmd.Run(r.client,
|
res, err := forwardCmd.Run(r.client,
|
||||||
[]string{src}, now, base.QueuePrefix).Err()
|
[]string{src}, now, base.QueuePrefix).Result()
|
||||||
|
if err != nil {
|
||||||
|
return 0, err
|
||||||
|
}
|
||||||
|
return cast.ToInt(res), nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// KEYS[1] -> source queue (e.g. scheduled or retry queue)
|
// KEYS[1] -> asynq:servers:<host:pid:sid>
|
||||||
// KEYS[2] -> destination queue
|
// KEYS[2] -> asynq:servers
|
||||||
var forwardSingleCmd = redis.NewScript(`
|
// KEYS[3] -> asynq:workers<host:pid:sid>
|
||||||
local msgs = redis.call("ZRANGEBYSCORE", KEYS[1], "-inf", ARGV[1])
|
// KEYS[4] -> asynq:workers
|
||||||
for _, msg in ipairs(msgs) do
|
|
||||||
redis.call("LPUSH", KEYS[2], msg)
|
|
||||||
redis.call("ZREM", KEYS[1], msg)
|
|
||||||
end
|
|
||||||
return msgs`)
|
|
||||||
|
|
||||||
// forwardSingle moves all tasks with a score less than the current unix time
|
|
||||||
// from the src zset to dst list.
|
|
||||||
func (r *RDB) forwardSingle(src, dst string) error {
|
|
||||||
now := float64(time.Now().Unix())
|
|
||||||
return forwardSingleCmd.Run(r.client,
|
|
||||||
[]string{src, dst}, now).Err()
|
|
||||||
}
|
|
||||||
|
|
||||||
// KEYS[1] -> asynq:ps:<host:pid>
|
|
||||||
// KEYS[2] -> asynq:ps
|
|
||||||
// KEYS[3] -> asynq:workers<host:pid>
|
|
||||||
// keys[4] -> asynq:workers
|
|
||||||
// ARGV[1] -> expiration time
|
// ARGV[1] -> expiration time
|
||||||
// ARGV[2] -> TTL in seconds
|
// ARGV[2] -> TTL in seconds
|
||||||
// ARGV[3] -> process info
|
// ARGV[3] -> server info
|
||||||
// ARGV[4:] -> alternate key-value pair of (worker id, worker data)
|
// ARGV[4:] -> alternate key-value pair of (worker id, worker data)
|
||||||
// Note: Add key to ZSET with expiration time as score.
|
// Note: Add key to ZSET with expiration time as score.
|
||||||
// ref: https://github.com/antirez/redis/issues/135#issuecomment-2361996
|
// ref: https://github.com/antirez/redis/issues/135#issuecomment-2361996
|
||||||
var writeProcessInfoCmd = redis.NewScript(`
|
var writeServerStateCmd = redis.NewScript(`
|
||||||
redis.call("SETEX", KEYS[1], ARGV[2], ARGV[3])
|
redis.call("SETEX", KEYS[1], ARGV[2], ARGV[3])
|
||||||
redis.call("ZADD", KEYS[2], ARGV[1], KEYS[1])
|
redis.call("ZADD", KEYS[2], ARGV[1], KEYS[1])
|
||||||
redis.call("DEL", KEYS[3])
|
redis.call("DEL", KEYS[3])
|
||||||
@@ -484,35 +463,32 @@ redis.call("EXPIRE", KEYS[3], ARGV[2])
|
|||||||
redis.call("ZADD", KEYS[4], ARGV[1], KEYS[3])
|
redis.call("ZADD", KEYS[4], ARGV[1], KEYS[3])
|
||||||
return redis.status_reply("OK")`)
|
return redis.status_reply("OK")`)
|
||||||
|
|
||||||
// WriteProcessState writes process state data to redis with expiration set to the value ttl.
|
// WriteServerState writes server state data to redis with expiration set to the value ttl.
|
||||||
func (r *RDB) WriteProcessState(ps *base.ProcessState, ttl time.Duration) error {
|
func (r *RDB) WriteServerState(info *base.ServerInfo, workers []*base.WorkerInfo, ttl time.Duration) error {
|
||||||
info := ps.Get()
|
|
||||||
bytes, err := json.Marshal(info)
|
bytes, err := json.Marshal(info)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
var args []interface{} // args to the lua script
|
|
||||||
exp := time.Now().Add(ttl).UTC()
|
exp := time.Now().Add(ttl).UTC()
|
||||||
workers := ps.GetWorkers()
|
args := []interface{}{float64(exp.Unix()), ttl.Seconds(), bytes} // args to the lua script
|
||||||
args = append(args, float64(exp.Unix()), ttl.Seconds(), bytes)
|
|
||||||
for _, w := range workers {
|
for _, w := range workers {
|
||||||
bytes, err := json.Marshal(w)
|
bytes, err := json.Marshal(w)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
continue // skip bad data
|
continue // skip bad data
|
||||||
}
|
}
|
||||||
args = append(args, w.ID.String(), bytes)
|
args = append(args, w.ID, bytes)
|
||||||
}
|
}
|
||||||
pkey := base.ProcessInfoKey(info.Host, info.PID)
|
skey := base.ServerInfoKey(info.Host, info.PID, info.ServerID)
|
||||||
wkey := base.WorkersKey(info.Host, info.PID)
|
wkey := base.WorkersKey(info.Host, info.PID, info.ServerID)
|
||||||
return writeProcessInfoCmd.Run(r.client,
|
return writeServerStateCmd.Run(r.client,
|
||||||
[]string{pkey, base.AllProcesses, wkey, base.AllWorkers},
|
[]string{skey, base.AllServers, wkey, base.AllWorkers},
|
||||||
args...).Err()
|
args...).Err()
|
||||||
}
|
}
|
||||||
|
|
||||||
// KEYS[1] -> asynq:ps
|
// KEYS[1] -> asynq:servers
|
||||||
// KEYS[2] -> asynq:ps:<host:pid>
|
// KEYS[2] -> asynq:servers:<host:pid:sid>
|
||||||
// KEYS[3] -> asynq:workers
|
// KEYS[3] -> asynq:workers
|
||||||
// KEYS[4] -> asynq:workers<host:pid>
|
// KEYS[4] -> asynq:workers<host:pid:sid>
|
||||||
var clearProcessInfoCmd = redis.NewScript(`
|
var clearProcessInfoCmd = redis.NewScript(`
|
||||||
redis.call("ZREM", KEYS[1], KEYS[2])
|
redis.call("ZREM", KEYS[1], KEYS[2])
|
||||||
redis.call("DEL", KEYS[2])
|
redis.call("DEL", KEYS[2])
|
||||||
@@ -520,14 +496,12 @@ redis.call("ZREM", KEYS[3], KEYS[4])
|
|||||||
redis.call("DEL", KEYS[4])
|
redis.call("DEL", KEYS[4])
|
||||||
return redis.status_reply("OK")`)
|
return redis.status_reply("OK")`)
|
||||||
|
|
||||||
// ClearProcessState deletes process state data from redis.
|
// ClearServerState deletes server state data from redis.
|
||||||
func (r *RDB) ClearProcessState(ps *base.ProcessState) error {
|
func (r *RDB) ClearServerState(host string, pid int, serverID string) error {
|
||||||
info := ps.Get()
|
skey := base.ServerInfoKey(host, pid, serverID)
|
||||||
host, pid := info.Host, info.PID
|
wkey := base.WorkersKey(host, pid, serverID)
|
||||||
pkey := base.ProcessInfoKey(host, pid)
|
|
||||||
wkey := base.WorkersKey(host, pid)
|
|
||||||
return clearProcessInfoCmd.Run(r.client,
|
return clearProcessInfoCmd.Run(r.client,
|
||||||
[]string{base.AllProcesses, pkey, base.AllWorkers, wkey}).Err()
|
[]string{base.AllServers, skey, base.AllWorkers, wkey}).Err()
|
||||||
}
|
}
|
||||||
|
|
||||||
// CancelationPubSub returns a pubsub for cancelation messages.
|
// CancelationPubSub returns a pubsub for cancelation messages.
|
||||||
|
@@ -227,6 +227,97 @@ func TestDequeue(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestDequeueIgnoresPausedQueues(t *testing.T) {
|
||||||
|
r := setup(t)
|
||||||
|
t1 := h.NewTaskMessage("send_email", map[string]interface{}{"subject": "hello!"})
|
||||||
|
t2 := h.NewTaskMessage("export_csv", nil)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
paused []string // list of paused queues
|
||||||
|
enqueued map[string][]*base.TaskMessage
|
||||||
|
args []string // list of queues to query
|
||||||
|
want *base.TaskMessage
|
||||||
|
err error
|
||||||
|
wantEnqueued map[string][]*base.TaskMessage
|
||||||
|
wantInProgress []*base.TaskMessage
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
paused: []string{"default"},
|
||||||
|
enqueued: map[string][]*base.TaskMessage{
|
||||||
|
"default": {t1},
|
||||||
|
"critical": {t2},
|
||||||
|
},
|
||||||
|
args: []string{"default", "critical"},
|
||||||
|
want: t2,
|
||||||
|
err: nil,
|
||||||
|
wantEnqueued: map[string][]*base.TaskMessage{
|
||||||
|
"default": {t1},
|
||||||
|
"critical": {},
|
||||||
|
},
|
||||||
|
wantInProgress: []*base.TaskMessage{t2},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
paused: []string{"default"},
|
||||||
|
enqueued: map[string][]*base.TaskMessage{
|
||||||
|
"default": {t1},
|
||||||
|
},
|
||||||
|
args: []string{"default"},
|
||||||
|
want: nil,
|
||||||
|
err: ErrNoProcessableTask,
|
||||||
|
wantEnqueued: map[string][]*base.TaskMessage{
|
||||||
|
"default": {t1},
|
||||||
|
},
|
||||||
|
wantInProgress: []*base.TaskMessage{},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
paused: []string{"critical", "default"},
|
||||||
|
enqueued: map[string][]*base.TaskMessage{
|
||||||
|
"default": {t1},
|
||||||
|
"critical": {t2},
|
||||||
|
},
|
||||||
|
args: []string{"default", "critical"},
|
||||||
|
want: nil,
|
||||||
|
err: ErrNoProcessableTask,
|
||||||
|
wantEnqueued: map[string][]*base.TaskMessage{
|
||||||
|
"default": {t1},
|
||||||
|
"critical": {t2},
|
||||||
|
},
|
||||||
|
wantInProgress: []*base.TaskMessage{},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
h.FlushDB(t, r.client) // clean up db before each test case
|
||||||
|
for _, qname := range tc.paused {
|
||||||
|
if err := r.Pause(qname); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for queue, msgs := range tc.enqueued {
|
||||||
|
h.SeedEnqueuedQueue(t, r.client, msgs, queue)
|
||||||
|
}
|
||||||
|
|
||||||
|
got, err := r.Dequeue(tc.args...)
|
||||||
|
if !cmp.Equal(got, tc.want) || err != tc.err {
|
||||||
|
t.Errorf("Dequeue(%v) = %v, %v; want %v, %v",
|
||||||
|
tc.args, got, err, tc.want, tc.err)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
for queue, want := range tc.wantEnqueued {
|
||||||
|
gotEnqueued := h.GetEnqueuedMessages(t, r.client, queue)
|
||||||
|
if diff := cmp.Diff(want, gotEnqueued, h.SortMsgOpt); diff != "" {
|
||||||
|
t.Errorf("mismatch found in %q: (-want,+got):\n%s", base.QueueKey(queue), diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
gotInProgress := h.GetInProgressMessages(t, r.client)
|
||||||
|
if diff := cmp.Diff(tc.wantInProgress, gotInProgress, h.SortMsgOpt); diff != "" {
|
||||||
|
t.Errorf("mismatch found in %q: (-want,+got):\n%s", base.InProgressQueue, diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestDone(t *testing.T) {
|
func TestDone(t *testing.T) {
|
||||||
r := setup(t)
|
r := setup(t)
|
||||||
t1 := h.NewTaskMessage("send_email", nil)
|
t1 := h.NewTaskMessage("send_email", nil)
|
||||||
@@ -769,7 +860,6 @@ func TestCheckAndEnqueue(t *testing.T) {
|
|||||||
tests := []struct {
|
tests := []struct {
|
||||||
scheduled []h.ZSetEntry
|
scheduled []h.ZSetEntry
|
||||||
retry []h.ZSetEntry
|
retry []h.ZSetEntry
|
||||||
qnames []string
|
|
||||||
wantEnqueued map[string][]*base.TaskMessage
|
wantEnqueued map[string][]*base.TaskMessage
|
||||||
wantScheduled []*base.TaskMessage
|
wantScheduled []*base.TaskMessage
|
||||||
wantRetry []*base.TaskMessage
|
wantRetry []*base.TaskMessage
|
||||||
@@ -781,7 +871,6 @@ func TestCheckAndEnqueue(t *testing.T) {
|
|||||||
},
|
},
|
||||||
retry: []h.ZSetEntry{
|
retry: []h.ZSetEntry{
|
||||||
{Msg: t3, Score: float64(secondAgo.Unix())}},
|
{Msg: t3, Score: float64(secondAgo.Unix())}},
|
||||||
qnames: []string{"default"},
|
|
||||||
wantEnqueued: map[string][]*base.TaskMessage{
|
wantEnqueued: map[string][]*base.TaskMessage{
|
||||||
"default": {t1, t2, t3},
|
"default": {t1, t2, t3},
|
||||||
},
|
},
|
||||||
@@ -794,7 +883,6 @@ func TestCheckAndEnqueue(t *testing.T) {
|
|||||||
{Msg: t2, Score: float64(secondAgo.Unix())}},
|
{Msg: t2, Score: float64(secondAgo.Unix())}},
|
||||||
retry: []h.ZSetEntry{
|
retry: []h.ZSetEntry{
|
||||||
{Msg: t3, Score: float64(secondAgo.Unix())}},
|
{Msg: t3, Score: float64(secondAgo.Unix())}},
|
||||||
qnames: []string{"default"},
|
|
||||||
wantEnqueued: map[string][]*base.TaskMessage{
|
wantEnqueued: map[string][]*base.TaskMessage{
|
||||||
"default": {t2, t3},
|
"default": {t2, t3},
|
||||||
},
|
},
|
||||||
@@ -807,7 +895,6 @@ func TestCheckAndEnqueue(t *testing.T) {
|
|||||||
{Msg: t2, Score: float64(hourFromNow.Unix())}},
|
{Msg: t2, Score: float64(hourFromNow.Unix())}},
|
||||||
retry: []h.ZSetEntry{
|
retry: []h.ZSetEntry{
|
||||||
{Msg: t3, Score: float64(hourFromNow.Unix())}},
|
{Msg: t3, Score: float64(hourFromNow.Unix())}},
|
||||||
qnames: []string{"default"},
|
|
||||||
wantEnqueued: map[string][]*base.TaskMessage{
|
wantEnqueued: map[string][]*base.TaskMessage{
|
||||||
"default": {},
|
"default": {},
|
||||||
},
|
},
|
||||||
@@ -821,7 +908,6 @@ func TestCheckAndEnqueue(t *testing.T) {
|
|||||||
},
|
},
|
||||||
retry: []h.ZSetEntry{
|
retry: []h.ZSetEntry{
|
||||||
{Msg: t5, Score: float64(secondAgo.Unix())}},
|
{Msg: t5, Score: float64(secondAgo.Unix())}},
|
||||||
qnames: []string{"default", "critical", "low"},
|
|
||||||
wantEnqueued: map[string][]*base.TaskMessage{
|
wantEnqueued: map[string][]*base.TaskMessage{
|
||||||
"default": {t1},
|
"default": {t1},
|
||||||
"critical": {t4},
|
"critical": {t4},
|
||||||
@@ -837,7 +923,7 @@ func TestCheckAndEnqueue(t *testing.T) {
|
|||||||
h.SeedScheduledQueue(t, r.client, tc.scheduled)
|
h.SeedScheduledQueue(t, r.client, tc.scheduled)
|
||||||
h.SeedRetryQueue(t, r.client, tc.retry)
|
h.SeedRetryQueue(t, r.client, tc.retry)
|
||||||
|
|
||||||
err := r.CheckAndEnqueue(tc.qnames...)
|
err := r.CheckAndEnqueue()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Errorf("(*RDB).CheckScheduled() = %v, want nil", err)
|
t.Errorf("(*RDB).CheckScheduled() = %v, want nil", err)
|
||||||
continue
|
continue
|
||||||
@@ -862,65 +948,65 @@ func TestCheckAndEnqueue(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestWriteProcessState(t *testing.T) {
|
func TestWriteServerState(t *testing.T) {
|
||||||
r := setup(t)
|
r := setup(t)
|
||||||
host, pid := "localhost", 98765
|
|
||||||
queues := map[string]int{"default": 2, "email": 5, "low": 1}
|
|
||||||
|
|
||||||
started := time.Now()
|
var (
|
||||||
ps := base.NewProcessState(host, pid, 10, queues, false)
|
host = "localhost"
|
||||||
ps.SetStarted(started)
|
pid = 4242
|
||||||
ps.SetStatus(base.StatusRunning)
|
serverID = "server123"
|
||||||
ttl := 5 * time.Second
|
|
||||||
|
|
||||||
h.FlushDB(t, r.client)
|
ttl = 5 * time.Second
|
||||||
|
)
|
||||||
|
|
||||||
err := r.WriteProcessState(ps, ttl)
|
info := base.ServerInfo{
|
||||||
if err != nil {
|
Host: host,
|
||||||
t.Errorf("r.WriteProcessState returned an error: %v", err)
|
PID: pid,
|
||||||
|
ServerID: serverID,
|
||||||
|
Concurrency: 10,
|
||||||
|
Queues: map[string]int{"default": 2, "email": 5, "low": 1},
|
||||||
|
StrictPriority: false,
|
||||||
|
Started: time.Now(),
|
||||||
|
Status: "running",
|
||||||
|
ActiveWorkerCount: 0,
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check ProcessInfo was written correctly
|
err := r.WriteServerState(&info, nil /* workers */, ttl)
|
||||||
pkey := base.ProcessInfoKey(host, pid)
|
if err != nil {
|
||||||
data := r.client.Get(pkey).Val()
|
t.Errorf("r.WriteServerState returned an error: %v", err)
|
||||||
var got base.ProcessInfo
|
}
|
||||||
|
|
||||||
|
// Check ServerInfo was written correctly.
|
||||||
|
skey := base.ServerInfoKey(host, pid, serverID)
|
||||||
|
data := r.client.Get(skey).Val()
|
||||||
|
var got base.ServerInfo
|
||||||
err = json.Unmarshal([]byte(data), &got)
|
err = json.Unmarshal([]byte(data), &got)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("could not decode json: %v", err)
|
t.Fatalf("could not decode json: %v", err)
|
||||||
}
|
}
|
||||||
want := base.ProcessInfo{
|
if diff := cmp.Diff(info, got); diff != "" {
|
||||||
Host: "localhost",
|
t.Errorf("persisted ServerInfo was %v, want %v; (-want,+got)\n%s",
|
||||||
PID: 98765,
|
got, info, diff)
|
||||||
Concurrency: 10,
|
|
||||||
Queues: map[string]int{"default": 2, "email": 5, "low": 1},
|
|
||||||
StrictPriority: false,
|
|
||||||
Status: "running",
|
|
||||||
Started: started,
|
|
||||||
ActiveWorkerCount: 0,
|
|
||||||
}
|
}
|
||||||
if diff := cmp.Diff(want, got); diff != "" {
|
// Check ServerInfo TTL was set correctly.
|
||||||
t.Errorf("persisted ProcessInfo was %v, want %v; (-want,+got)\n%s",
|
gotTTL := r.client.TTL(skey).Val()
|
||||||
got, want, diff)
|
|
||||||
}
|
|
||||||
// Check ProcessInfo TTL was set correctly
|
|
||||||
gotTTL := r.client.TTL(pkey).Val()
|
|
||||||
if !cmp.Equal(ttl.Seconds(), gotTTL.Seconds(), cmpopts.EquateApprox(0, 1)) {
|
if !cmp.Equal(ttl.Seconds(), gotTTL.Seconds(), cmpopts.EquateApprox(0, 1)) {
|
||||||
t.Errorf("TTL of %q was %v, want %v", pkey, gotTTL, ttl)
|
t.Errorf("TTL of %q was %v, want %v", skey, gotTTL, ttl)
|
||||||
}
|
}
|
||||||
// Check ProcessInfo key was added to the set correctly
|
// Check ServerInfo key was added to the set all server keys correctly.
|
||||||
gotProcesses := r.client.ZRange(base.AllProcesses, 0, -1).Val()
|
gotServerKeys := r.client.ZRange(base.AllServers, 0, -1).Val()
|
||||||
wantProcesses := []string{pkey}
|
wantServerKeys := []string{skey}
|
||||||
if diff := cmp.Diff(wantProcesses, gotProcesses); diff != "" {
|
if diff := cmp.Diff(wantServerKeys, gotServerKeys); diff != "" {
|
||||||
t.Errorf("%q contained %v, want %v", base.AllProcesses, gotProcesses, wantProcesses)
|
t.Errorf("%q contained %v, want %v", base.AllServers, gotServerKeys, wantServerKeys)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check WorkersInfo was written correctly
|
// Check WorkersInfo was written correctly.
|
||||||
wkey := base.WorkersKey(host, pid)
|
wkey := base.WorkersKey(host, pid, serverID)
|
||||||
workerExist := r.client.Exists(wkey).Val()
|
workerExist := r.client.Exists(wkey).Val()
|
||||||
if workerExist != 0 {
|
if workerExist != 0 {
|
||||||
t.Errorf("%q key exists", wkey)
|
t.Errorf("%q key exists", wkey)
|
||||||
}
|
}
|
||||||
// Check WorkersInfo key was added to the set correctly
|
// Check WorkersInfo key was added to the set correctly.
|
||||||
gotWorkerKeys := r.client.ZRange(base.AllWorkers, 0, -1).Val()
|
gotWorkerKeys := r.client.ZRange(base.AllWorkers, 0, -1).Val()
|
||||||
wantWorkerKeys := []string{wkey}
|
wantWorkerKeys := []string{wkey}
|
||||||
if diff := cmp.Diff(wantWorkerKeys, gotWorkerKeys); diff != "" {
|
if diff := cmp.Diff(wantWorkerKeys, gotWorkerKeys); diff != "" {
|
||||||
@@ -928,110 +1014,107 @@ func TestWriteProcessState(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestWriteProcessStateWithWorkers(t *testing.T) {
|
func TestWriteServerStateWithWorkers(t *testing.T) {
|
||||||
r := setup(t)
|
r := setup(t)
|
||||||
host, pid := "localhost", 98765
|
|
||||||
queues := map[string]int{"default": 2, "email": 5, "low": 1}
|
|
||||||
concurrency := 10
|
|
||||||
|
|
||||||
started := time.Now().Add(-10 * time.Minute)
|
var (
|
||||||
w1Started := time.Now().Add(-time.Minute)
|
host = "127.0.0.1"
|
||||||
w2Started := time.Now().Add(-time.Second)
|
pid = 4242
|
||||||
msg1 := h.NewTaskMessage("send_email", map[string]interface{}{"user_id": "123"})
|
serverID = "server123"
|
||||||
msg2 := h.NewTaskMessage("gen_thumbnail", map[string]interface{}{"path": "some/path/to/imgfile"})
|
|
||||||
ps := base.NewProcessState(host, pid, concurrency, queues, false)
|
|
||||||
ps.SetStarted(started)
|
|
||||||
ps.SetStatus(base.StatusRunning)
|
|
||||||
ps.AddWorkerStats(msg1, w1Started)
|
|
||||||
ps.AddWorkerStats(msg2, w2Started)
|
|
||||||
ttl := 5 * time.Second
|
|
||||||
|
|
||||||
h.FlushDB(t, r.client)
|
msg1 = h.NewTaskMessage("send_email", map[string]interface{}{"user_id": "123"})
|
||||||
|
msg2 = h.NewTaskMessage("gen_thumbnail", map[string]interface{}{"path": "some/path/to/imgfile"})
|
||||||
|
|
||||||
err := r.WriteProcessState(ps, ttl)
|
ttl = 5 * time.Second
|
||||||
if err != nil {
|
)
|
||||||
t.Errorf("r.WriteProcessState returned an error: %v", err)
|
|
||||||
|
workers := []*base.WorkerInfo{
|
||||||
|
{
|
||||||
|
Host: host,
|
||||||
|
PID: pid,
|
||||||
|
ID: msg1.ID.String(),
|
||||||
|
Type: msg1.Type,
|
||||||
|
Queue: msg1.Queue,
|
||||||
|
Payload: msg1.Payload,
|
||||||
|
Started: time.Now().Add(-10 * time.Second),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
Host: host,
|
||||||
|
PID: pid,
|
||||||
|
ID: msg2.ID.String(),
|
||||||
|
Type: msg2.Type,
|
||||||
|
Queue: msg2.Queue,
|
||||||
|
Payload: msg2.Payload,
|
||||||
|
Started: time.Now().Add(-2 * time.Minute),
|
||||||
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check ProcessInfo was written correctly
|
serverInfo := base.ServerInfo{
|
||||||
pkey := base.ProcessInfoKey(host, pid)
|
Host: host,
|
||||||
data := r.client.Get(pkey).Val()
|
PID: pid,
|
||||||
var got base.ProcessInfo
|
ServerID: serverID,
|
||||||
|
Concurrency: 10,
|
||||||
|
Queues: map[string]int{"default": 2, "email": 5, "low": 1},
|
||||||
|
StrictPriority: false,
|
||||||
|
Started: time.Now().Add(-10 * time.Minute),
|
||||||
|
Status: "running",
|
||||||
|
ActiveWorkerCount: len(workers),
|
||||||
|
}
|
||||||
|
|
||||||
|
err := r.WriteServerState(&serverInfo, workers, ttl)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("r.WriteServerState returned an error: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check ServerInfo was written correctly.
|
||||||
|
skey := base.ServerInfoKey(host, pid, serverID)
|
||||||
|
data := r.client.Get(skey).Val()
|
||||||
|
var got base.ServerInfo
|
||||||
err = json.Unmarshal([]byte(data), &got)
|
err = json.Unmarshal([]byte(data), &got)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("could not decode json: %v", err)
|
t.Fatalf("could not decode json: %v", err)
|
||||||
}
|
}
|
||||||
want := base.ProcessInfo{
|
if diff := cmp.Diff(serverInfo, got); diff != "" {
|
||||||
Host: host,
|
t.Errorf("persisted ServerInfo was %v, want %v; (-want,+got)\n%s",
|
||||||
PID: pid,
|
got, serverInfo, diff)
|
||||||
Concurrency: concurrency,
|
|
||||||
Queues: queues,
|
|
||||||
StrictPriority: false,
|
|
||||||
Status: "running",
|
|
||||||
Started: started,
|
|
||||||
ActiveWorkerCount: 2,
|
|
||||||
}
|
}
|
||||||
if diff := cmp.Diff(want, got); diff != "" {
|
// Check ServerInfo TTL was set correctly.
|
||||||
t.Errorf("persisted ProcessInfo was %v, want %v; (-want,+got)\n%s",
|
gotTTL := r.client.TTL(skey).Val()
|
||||||
got, want, diff)
|
|
||||||
}
|
|
||||||
// Check ProcessInfo TTL was set correctly
|
|
||||||
gotTTL := r.client.TTL(pkey).Val()
|
|
||||||
if !cmp.Equal(ttl.Seconds(), gotTTL.Seconds(), cmpopts.EquateApprox(0, 1)) {
|
if !cmp.Equal(ttl.Seconds(), gotTTL.Seconds(), cmpopts.EquateApprox(0, 1)) {
|
||||||
t.Errorf("TTL of %q was %v, want %v", pkey, gotTTL, ttl)
|
t.Errorf("TTL of %q was %v, want %v", skey, gotTTL, ttl)
|
||||||
}
|
}
|
||||||
// Check ProcessInfo key was added to the set correctly
|
// Check ServerInfo key was added to the set correctly.
|
||||||
gotProcesses := r.client.ZRange(base.AllProcesses, 0, -1).Val()
|
gotServerKeys := r.client.ZRange(base.AllServers, 0, -1).Val()
|
||||||
wantProcesses := []string{pkey}
|
wantServerKeys := []string{skey}
|
||||||
if diff := cmp.Diff(wantProcesses, gotProcesses); diff != "" {
|
if diff := cmp.Diff(wantServerKeys, gotServerKeys); diff != "" {
|
||||||
t.Errorf("%q contained %v, want %v", base.AllProcesses, gotProcesses, wantProcesses)
|
t.Errorf("%q contained %v, want %v", base.AllServers, gotServerKeys, wantServerKeys)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check WorkersInfo was written correctly
|
// Check WorkersInfo was written correctly.
|
||||||
wkey := base.WorkersKey(host, pid)
|
wkey := base.WorkersKey(host, pid, serverID)
|
||||||
wdata := r.client.HGetAll(wkey).Val()
|
wdata := r.client.HGetAll(wkey).Val()
|
||||||
if len(wdata) != 2 {
|
if len(wdata) != 2 {
|
||||||
t.Fatalf("HGETALL %q returned a hash of size %d, want 2", wkey, len(wdata))
|
t.Fatalf("HGETALL %q returned a hash of size %d, want 2", wkey, len(wdata))
|
||||||
}
|
}
|
||||||
gotWorkers := make(map[string]*base.WorkerInfo)
|
var gotWorkers []*base.WorkerInfo
|
||||||
for key, val := range wdata {
|
for _, val := range wdata {
|
||||||
var w base.WorkerInfo
|
var w base.WorkerInfo
|
||||||
if err := json.Unmarshal([]byte(val), &w); err != nil {
|
if err := json.Unmarshal([]byte(val), &w); err != nil {
|
||||||
t.Fatalf("could not unmarshal worker's data: %v", err)
|
t.Fatalf("could not unmarshal worker's data: %v", err)
|
||||||
}
|
}
|
||||||
gotWorkers[key] = &w
|
gotWorkers = append(gotWorkers, &w)
|
||||||
}
|
}
|
||||||
wantWorkers := map[string]*base.WorkerInfo{
|
if diff := cmp.Diff(workers, gotWorkers, h.SortWorkerInfoOpt); diff != "" {
|
||||||
msg1.ID.String(): {
|
|
||||||
Host: host,
|
|
||||||
PID: pid,
|
|
||||||
ID: msg1.ID,
|
|
||||||
Type: msg1.Type,
|
|
||||||
Queue: msg1.Queue,
|
|
||||||
Payload: msg1.Payload,
|
|
||||||
Started: w1Started,
|
|
||||||
},
|
|
||||||
msg2.ID.String(): {
|
|
||||||
Host: host,
|
|
||||||
PID: pid,
|
|
||||||
ID: msg2.ID,
|
|
||||||
Type: msg2.Type,
|
|
||||||
Queue: msg2.Queue,
|
|
||||||
Payload: msg2.Payload,
|
|
||||||
Started: w2Started,
|
|
||||||
},
|
|
||||||
}
|
|
||||||
if diff := cmp.Diff(wantWorkers, gotWorkers); diff != "" {
|
|
||||||
t.Errorf("persisted workers info was %v, want %v; (-want,+got)\n%s",
|
t.Errorf("persisted workers info was %v, want %v; (-want,+got)\n%s",
|
||||||
gotWorkers, wantWorkers, diff)
|
gotWorkers, workers, diff)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check WorkersInfo TTL was set correctly
|
// Check WorkersInfo TTL was set correctly.
|
||||||
gotTTL = r.client.TTL(wkey).Val()
|
gotTTL = r.client.TTL(wkey).Val()
|
||||||
if !cmp.Equal(ttl, gotTTL, timeCmpOpt) {
|
if !cmp.Equal(ttl.Seconds(), gotTTL.Seconds(), cmpopts.EquateApprox(0, 1)) {
|
||||||
t.Errorf("TTL of %q was %v, want %v", wkey, gotTTL, ttl)
|
t.Errorf("TTL of %q was %v, want %v", wkey, gotTTL, ttl)
|
||||||
}
|
}
|
||||||
// Check WorkersInfo key was added to the set correctly
|
// Check WorkersInfo key was added to the set correctly.
|
||||||
gotWorkerKeys := r.client.ZRange(base.AllWorkers, 0, -1).Val()
|
gotWorkerKeys := r.client.ZRange(base.AllWorkers, 0, -1).Val()
|
||||||
wantWorkerKeys := []string{wkey}
|
wantWorkerKeys := []string{wkey}
|
||||||
if diff := cmp.Diff(wantWorkerKeys, gotWorkerKeys); diff != "" {
|
if diff := cmp.Diff(wantWorkerKeys, gotWorkerKeys); diff != "" {
|
||||||
@@ -1039,54 +1122,98 @@ func TestWriteProcessStateWithWorkers(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestClearProcessState(t *testing.T) {
|
func TestClearServerState(t *testing.T) {
|
||||||
r := setup(t)
|
r := setup(t)
|
||||||
host, pid := "127.0.0.1", 1234
|
|
||||||
|
|
||||||
h.FlushDB(t, r.client)
|
var (
|
||||||
|
host = "127.0.0.1"
|
||||||
|
pid = 1234
|
||||||
|
serverID = "server123"
|
||||||
|
|
||||||
pkey := base.ProcessInfoKey(host, pid)
|
otherHost = "127.0.0.2"
|
||||||
wkey := base.WorkersKey(host, pid)
|
otherPID = 9876
|
||||||
otherPKey := base.ProcessInfoKey("otherhost", 12345)
|
otherServerID = "server987"
|
||||||
otherWKey := base.WorkersKey("otherhost", 12345)
|
|
||||||
// Populate the keys.
|
msg1 = h.NewTaskMessage("send_email", map[string]interface{}{"user_id": "123"})
|
||||||
if err := r.client.Set(pkey, "process-info", 0).Err(); err != nil {
|
msg2 = h.NewTaskMessage("gen_thumbnail", map[string]interface{}{"path": "some/path/to/imgfile"})
|
||||||
t.Fatal(err)
|
|
||||||
|
ttl = 5 * time.Second
|
||||||
|
)
|
||||||
|
|
||||||
|
workers1 := []*base.WorkerInfo{
|
||||||
|
{
|
||||||
|
Host: host,
|
||||||
|
PID: pid,
|
||||||
|
ID: msg1.ID.String(),
|
||||||
|
Type: msg1.Type,
|
||||||
|
Queue: msg1.Queue,
|
||||||
|
Payload: msg1.Payload,
|
||||||
|
Started: time.Now().Add(-10 * time.Second),
|
||||||
|
},
|
||||||
}
|
}
|
||||||
if err := r.client.HSet(wkey, "worker-key", "worker-info").Err(); err != nil {
|
serverInfo1 := base.ServerInfo{
|
||||||
t.Fatal(err)
|
Host: host,
|
||||||
}
|
PID: pid,
|
||||||
if err := r.client.ZAdd(base.AllProcesses, &redis.Z{Member: pkey}).Err(); err != nil {
|
ServerID: serverID,
|
||||||
t.Fatal(err)
|
Concurrency: 10,
|
||||||
}
|
Queues: map[string]int{"default": 2, "email": 5, "low": 1},
|
||||||
if err := r.client.ZAdd(base.AllProcesses, &redis.Z{Member: otherPKey}).Err(); err != nil {
|
StrictPriority: false,
|
||||||
t.Fatal(err)
|
Started: time.Now().Add(-10 * time.Minute),
|
||||||
}
|
Status: "running",
|
||||||
if err := r.client.ZAdd(base.AllWorkers, &redis.Z{Member: wkey}).Err(); err != nil {
|
ActiveWorkerCount: len(workers1),
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
if err := r.client.ZAdd(base.AllWorkers, &redis.Z{Member: otherWKey}).Err(); err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
ps := base.NewProcessState(host, pid, 10, map[string]int{"default": 1}, false)
|
workers2 := []*base.WorkerInfo{
|
||||||
|
{
|
||||||
|
Host: otherHost,
|
||||||
|
PID: otherPID,
|
||||||
|
ID: msg2.ID.String(),
|
||||||
|
Type: msg2.Type,
|
||||||
|
Queue: msg2.Queue,
|
||||||
|
Payload: msg2.Payload,
|
||||||
|
Started: time.Now().Add(-30 * time.Second),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
serverInfo2 := base.ServerInfo{
|
||||||
|
Host: otherHost,
|
||||||
|
PID: otherPID,
|
||||||
|
ServerID: otherServerID,
|
||||||
|
Concurrency: 10,
|
||||||
|
Queues: map[string]int{"default": 2, "email": 5, "low": 1},
|
||||||
|
StrictPriority: false,
|
||||||
|
Started: time.Now().Add(-15 * time.Minute),
|
||||||
|
Status: "running",
|
||||||
|
ActiveWorkerCount: len(workers2),
|
||||||
|
}
|
||||||
|
|
||||||
err := r.ClearProcessState(ps)
|
// Write server and workers data.
|
||||||
|
if err := r.WriteServerState(&serverInfo1, workers1, ttl); err != nil {
|
||||||
|
t.Fatalf("could not write server state: %v", err)
|
||||||
|
}
|
||||||
|
if err := r.WriteServerState(&serverInfo2, workers2, ttl); err != nil {
|
||||||
|
t.Fatalf("could not write server state: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
err := r.ClearServerState(host, pid, serverID)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("(*RDB).ClearProcessState failed: %v", err)
|
t.Fatalf("(*RDB).ClearServerState failed: %v", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check all keys are cleared
|
skey := base.ServerInfoKey(host, pid, serverID)
|
||||||
if r.client.Exists(pkey).Val() != 0 {
|
wkey := base.WorkersKey(host, pid, serverID)
|
||||||
t.Errorf("Redis key %q exists", pkey)
|
otherSKey := base.ServerInfoKey(otherHost, otherPID, otherServerID)
|
||||||
|
otherWKey := base.WorkersKey(otherHost, otherPID, otherServerID)
|
||||||
|
// Check all keys are cleared.
|
||||||
|
if r.client.Exists(skey).Val() != 0 {
|
||||||
|
t.Errorf("Redis key %q exists", skey)
|
||||||
}
|
}
|
||||||
if r.client.Exists(wkey).Val() != 0 {
|
if r.client.Exists(wkey).Val() != 0 {
|
||||||
t.Errorf("Redis key %q exists", wkey)
|
t.Errorf("Redis key %q exists", wkey)
|
||||||
}
|
}
|
||||||
gotProcessKeys := r.client.ZRange(base.AllProcesses, 0, -1).Val()
|
gotServerKeys := r.client.ZRange(base.AllServers, 0, -1).Val()
|
||||||
wantProcessKeys := []string{otherPKey}
|
wantServerKeys := []string{otherSKey}
|
||||||
if diff := cmp.Diff(wantProcessKeys, gotProcessKeys); diff != "" {
|
if diff := cmp.Diff(wantServerKeys, gotServerKeys); diff != "" {
|
||||||
t.Errorf("%q contained %v, want %v", base.AllProcesses, gotProcessKeys, wantProcessKeys)
|
t.Errorf("%q contained %v, want %v", base.AllServers, gotServerKeys, wantServerKeys)
|
||||||
}
|
}
|
||||||
gotWorkerKeys := r.client.ZRange(base.AllWorkers, 0, -1).Val()
|
gotWorkerKeys := r.client.ZRange(base.AllWorkers, 0, -1).Val()
|
||||||
wantWorkerKeys := []string{otherWKey}
|
wantWorkerKeys := []string{otherWKey}
|
||||||
|
187
internal/testbroker/testbroker.go
Normal file
@@ -0,0 +1,187 @@
|
|||||||
|
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
||||||
|
// Use of this source code is governed by a MIT license
|
||||||
|
// that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
// Package testbroker exports a broker implementation that should be used in package testing.
|
||||||
|
package testbroker
|
||||||
|
|
||||||
|
import (
|
||||||
|
"errors"
|
||||||
|
"sync"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/go-redis/redis/v7"
|
||||||
|
"github.com/hibiken/asynq/internal/base"
|
||||||
|
)
|
||||||
|
|
||||||
|
var errRedisDown = errors.New("asynqtest: redis is down")
|
||||||
|
|
||||||
|
// TestBroker is a broker implementation which enables
|
||||||
|
// to simulate Redis failure in tests.
|
||||||
|
type TestBroker struct {
|
||||||
|
mu sync.Mutex
|
||||||
|
sleeping bool
|
||||||
|
|
||||||
|
// real broker
|
||||||
|
real base.Broker
|
||||||
|
}
|
||||||
|
|
||||||
|
func NewTestBroker(b base.Broker) *TestBroker {
|
||||||
|
return &TestBroker{real: b}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Sleep() {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
tb.sleeping = true
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Wakeup() {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
tb.sleeping = false
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Enqueue(msg *base.TaskMessage) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.Enqueue(msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) EnqueueUnique(msg *base.TaskMessage, ttl time.Duration) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.EnqueueUnique(msg, ttl)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Dequeue(qnames ...string) (*base.TaskMessage, error) {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return nil, errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.Dequeue(qnames...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Done(msg *base.TaskMessage) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.Done(msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Requeue(msg *base.TaskMessage) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.Requeue(msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Schedule(msg *base.TaskMessage, processAt time.Time) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.Schedule(msg, processAt)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) ScheduleUnique(msg *base.TaskMessage, processAt time.Time, ttl time.Duration) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.ScheduleUnique(msg, processAt, ttl)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Retry(msg *base.TaskMessage, processAt time.Time, errMsg string) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.Retry(msg, processAt, errMsg)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Kill(msg *base.TaskMessage, errMsg string) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.Kill(msg, errMsg)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) RequeueAll() (int64, error) {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return 0, errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.RequeueAll()
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) CheckAndEnqueue() error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.CheckAndEnqueue()
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) WriteServerState(info *base.ServerInfo, workers []*base.WorkerInfo, ttl time.Duration) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.WriteServerState(info, workers, ttl)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) ClearServerState(host string, pid int, serverID string) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.ClearServerState(host, pid, serverID)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) CancelationPubSub() (*redis.PubSub, error) {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return nil, errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.CancelationPubSub()
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) PublishCancelation(id string) error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.PublishCancelation(id)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tb *TestBroker) Close() error {
|
||||||
|
tb.mu.Lock()
|
||||||
|
defer tb.mu.Unlock()
|
||||||
|
if tb.sleeping {
|
||||||
|
return errRedisDown
|
||||||
|
}
|
||||||
|
return tb.real.Close()
|
||||||
|
}
|
64
payload.go
@@ -5,6 +5,7 @@
|
|||||||
package asynq
|
package asynq
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"encoding/json"
|
||||||
"fmt"
|
"fmt"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
@@ -30,6 +31,19 @@ func (p Payload) Has(key string) bool {
|
|||||||
return ok
|
return ok
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func toInt(v interface{}) (int, error) {
|
||||||
|
switch v := v.(type) {
|
||||||
|
case json.Number:
|
||||||
|
val, err := v.Int64()
|
||||||
|
if err != nil {
|
||||||
|
return 0, err
|
||||||
|
}
|
||||||
|
return int(val), nil
|
||||||
|
default:
|
||||||
|
return cast.ToIntE(v)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// GetString returns a string value if a string type is associated with
|
// GetString returns a string value if a string type is associated with
|
||||||
// the key, otherwise reports an error.
|
// the key, otherwise reports an error.
|
||||||
func (p Payload) GetString(key string) (string, error) {
|
func (p Payload) GetString(key string) (string, error) {
|
||||||
@@ -47,7 +61,7 @@ func (p Payload) GetInt(key string) (int, error) {
|
|||||||
if !ok {
|
if !ok {
|
||||||
return 0, &errKeyNotFound{key}
|
return 0, &errKeyNotFound{key}
|
||||||
}
|
}
|
||||||
return cast.ToIntE(v)
|
return toInt(v)
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetFloat64 returns a float64 value if a numeric type is associated with
|
// GetFloat64 returns a float64 value if a numeric type is associated with
|
||||||
@@ -57,7 +71,12 @@ func (p Payload) GetFloat64(key string) (float64, error) {
|
|||||||
if !ok {
|
if !ok {
|
||||||
return 0, &errKeyNotFound{key}
|
return 0, &errKeyNotFound{key}
|
||||||
}
|
}
|
||||||
return cast.ToFloat64E(v)
|
switch v := v.(type) {
|
||||||
|
case json.Number:
|
||||||
|
return v.Float64()
|
||||||
|
default:
|
||||||
|
return cast.ToFloat64E(v)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetBool returns a boolean value if a boolean type is associated with
|
// GetBool returns a boolean value if a boolean type is associated with
|
||||||
@@ -87,7 +106,20 @@ func (p Payload) GetIntSlice(key string) ([]int, error) {
|
|||||||
if !ok {
|
if !ok {
|
||||||
return nil, &errKeyNotFound{key}
|
return nil, &errKeyNotFound{key}
|
||||||
}
|
}
|
||||||
return cast.ToIntSliceE(v)
|
switch v := v.(type) {
|
||||||
|
case []interface{}:
|
||||||
|
var res []int
|
||||||
|
for _, elem := range v {
|
||||||
|
val, err := toInt(elem)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
res = append(res, int(val))
|
||||||
|
}
|
||||||
|
return res, nil
|
||||||
|
default:
|
||||||
|
return cast.ToIntSliceE(v)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetStringMap returns a map of string to empty interface
|
// GetStringMap returns a map of string to empty interface
|
||||||
@@ -131,7 +163,20 @@ func (p Payload) GetStringMapInt(key string) (map[string]int, error) {
|
|||||||
if !ok {
|
if !ok {
|
||||||
return nil, &errKeyNotFound{key}
|
return nil, &errKeyNotFound{key}
|
||||||
}
|
}
|
||||||
return cast.ToStringMapIntE(v)
|
switch v := v.(type) {
|
||||||
|
case map[string]interface{}:
|
||||||
|
res := make(map[string]int)
|
||||||
|
for key, val := range v {
|
||||||
|
ival, err := toInt(val)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
res[key] = ival
|
||||||
|
}
|
||||||
|
return res, nil
|
||||||
|
default:
|
||||||
|
return cast.ToStringMapIntE(v)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetStringMapBool returns a map of string to boolean
|
// GetStringMapBool returns a map of string to boolean
|
||||||
@@ -162,5 +207,14 @@ func (p Payload) GetDuration(key string) (time.Duration, error) {
|
|||||||
if !ok {
|
if !ok {
|
||||||
return 0, &errKeyNotFound{key}
|
return 0, &errKeyNotFound{key}
|
||||||
}
|
}
|
||||||
return cast.ToDurationE(v)
|
switch v := v.(type) {
|
||||||
|
case json.Number:
|
||||||
|
val, err := v.Int64()
|
||||||
|
if err != nil {
|
||||||
|
return 0, err
|
||||||
|
}
|
||||||
|
return time.Duration(val), nil
|
||||||
|
default:
|
||||||
|
return cast.ToDurationE(v)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
@@ -10,6 +10,7 @@ import (
|
|||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/google/go-cmp/cmp"
|
"github.com/google/go-cmp/cmp"
|
||||||
|
"github.com/google/go-cmp/cmp/cmpopts"
|
||||||
h "github.com/hibiken/asynq/internal/asynqtest"
|
h "github.com/hibiken/asynq/internal/asynqtest"
|
||||||
"github.com/hibiken/asynq/internal/base"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
)
|
)
|
||||||
@@ -40,12 +41,11 @@ func TestPayloadString(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -85,12 +85,11 @@ func TestPayloadInt(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -130,12 +129,11 @@ func TestPayloadFloat64(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -175,12 +173,11 @@ func TestPayloadBool(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -221,12 +218,11 @@ func TestPayloadStringSlice(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -268,12 +264,11 @@ func TestPayloadIntSlice(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -315,21 +310,28 @@ func TestPayloadStringMap(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
payload = Payload{out.Payload}
|
payload = Payload{out.Payload}
|
||||||
got, err = payload.GetStringMap(tc.key)
|
got, err = payload.GetStringMap(tc.key)
|
||||||
diff = cmp.Diff(got, tc.data[tc.key])
|
ignoreOpt := cmpopts.IgnoreMapEntries(func(key string, val interface{}) bool {
|
||||||
|
switch val.(type) {
|
||||||
|
case json.Number:
|
||||||
|
return true
|
||||||
|
default:
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
})
|
||||||
|
diff = cmp.Diff(got, tc.data[tc.key], ignoreOpt)
|
||||||
if err != nil || diff != "" {
|
if err != nil || diff != "" {
|
||||||
t.Errorf("With Marshaling: Payload.GetStringMap(%q) = %v, %v, want %v, nil",
|
t.Errorf("With Marshaling: Payload.GetStringMap(%q) = %v, %v, want %v, nil;(-want,+got)\n%s",
|
||||||
tc.key, got, err, tc.data[tc.key])
|
tc.key, got, err, tc.data[tc.key], diff)
|
||||||
}
|
}
|
||||||
|
|
||||||
// access non-existent key.
|
// access non-existent key.
|
||||||
@@ -362,12 +364,11 @@ func TestPayloadStringMapString(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -413,12 +414,11 @@ func TestPayloadStringMapStringSlice(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -465,12 +465,11 @@ func TestPayloadStringMapInt(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -517,12 +516,11 @@ func TestPayloadStringMapBool(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -564,12 +562,11 @@ func TestPayloadTime(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -611,12 +608,11 @@ func TestPayloadDuration(t *testing.T) {
|
|||||||
|
|
||||||
// encode and then decode task messsage.
|
// encode and then decode task messsage.
|
||||||
in := h.NewTaskMessage("testing", tc.data)
|
in := h.NewTaskMessage("testing", tc.data)
|
||||||
b, err := json.Marshal(in)
|
encoded, err := base.EncodeMessage(in)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
var out base.TaskMessage
|
out, err := base.DecodeMessage(encoded)
|
||||||
err = json.Unmarshal(b, &out)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
|
169
processor.go
@@ -13,15 +13,14 @@ import (
|
|||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/hibiken/asynq/internal/base"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
|
"github.com/hibiken/asynq/internal/log"
|
||||||
"github.com/hibiken/asynq/internal/rdb"
|
"github.com/hibiken/asynq/internal/rdb"
|
||||||
"golang.org/x/time/rate"
|
"golang.org/x/time/rate"
|
||||||
)
|
)
|
||||||
|
|
||||||
type processor struct {
|
type processor struct {
|
||||||
logger Logger
|
logger *log.Logger
|
||||||
rdb *rdb.RDB
|
broker base.Broker
|
||||||
|
|
||||||
ps *base.ProcessState
|
|
||||||
|
|
||||||
handler Handler
|
handler Handler
|
||||||
|
|
||||||
@@ -34,6 +33,8 @@ type processor struct {
|
|||||||
|
|
||||||
errHandler ErrorHandler
|
errHandler ErrorHandler
|
||||||
|
|
||||||
|
shutdownTimeout time.Duration
|
||||||
|
|
||||||
// channel via which to send sync requests to syncer.
|
// channel via which to send sync requests to syncer.
|
||||||
syncRequestCh chan<- *syncRequest
|
syncRequestCh chan<- *syncRequest
|
||||||
|
|
||||||
@@ -57,35 +58,52 @@ type processor struct {
|
|||||||
|
|
||||||
// cancelations is a set of cancel functions for all in-progress tasks.
|
// cancelations is a set of cancel functions for all in-progress tasks.
|
||||||
cancelations *base.Cancelations
|
cancelations *base.Cancelations
|
||||||
|
|
||||||
|
starting chan<- *base.TaskMessage
|
||||||
|
finished chan<- *base.TaskMessage
|
||||||
}
|
}
|
||||||
|
|
||||||
type retryDelayFunc func(n int, err error, task *Task) time.Duration
|
type retryDelayFunc func(n int, err error, task *Task) time.Duration
|
||||||
|
|
||||||
|
type processorParams struct {
|
||||||
|
logger *log.Logger
|
||||||
|
broker base.Broker
|
||||||
|
retryDelayFunc retryDelayFunc
|
||||||
|
syncCh chan<- *syncRequest
|
||||||
|
cancelations *base.Cancelations
|
||||||
|
concurrency int
|
||||||
|
queues map[string]int
|
||||||
|
strictPriority bool
|
||||||
|
errHandler ErrorHandler
|
||||||
|
shutdownTimeout time.Duration
|
||||||
|
starting chan<- *base.TaskMessage
|
||||||
|
finished chan<- *base.TaskMessage
|
||||||
|
}
|
||||||
|
|
||||||
// newProcessor constructs a new processor.
|
// newProcessor constructs a new processor.
|
||||||
func newProcessor(l Logger, r *rdb.RDB, ps *base.ProcessState, fn retryDelayFunc,
|
func newProcessor(params processorParams) *processor {
|
||||||
syncCh chan<- *syncRequest, c *base.Cancelations, errHandler ErrorHandler) *processor {
|
queues := normalizeQueues(params.queues)
|
||||||
info := ps.Get()
|
|
||||||
qcfg := normalizeQueueCfg(info.Queues)
|
|
||||||
orderedQueues := []string(nil)
|
orderedQueues := []string(nil)
|
||||||
if info.StrictPriority {
|
if params.strictPriority {
|
||||||
orderedQueues = sortByPriority(qcfg)
|
orderedQueues = sortByPriority(queues)
|
||||||
}
|
}
|
||||||
return &processor{
|
return &processor{
|
||||||
logger: l,
|
logger: params.logger,
|
||||||
rdb: r,
|
broker: params.broker,
|
||||||
ps: ps,
|
queueConfig: queues,
|
||||||
queueConfig: qcfg,
|
|
||||||
orderedQueues: orderedQueues,
|
orderedQueues: orderedQueues,
|
||||||
retryDelayFunc: fn,
|
retryDelayFunc: params.retryDelayFunc,
|
||||||
syncRequestCh: syncCh,
|
syncRequestCh: params.syncCh,
|
||||||
cancelations: c,
|
cancelations: params.cancelations,
|
||||||
errLogLimiter: rate.NewLimiter(rate.Every(3*time.Second), 1),
|
errLogLimiter: rate.NewLimiter(rate.Every(3*time.Second), 1),
|
||||||
sema: make(chan struct{}, info.Concurrency),
|
sema: make(chan struct{}, params.concurrency),
|
||||||
done: make(chan struct{}),
|
done: make(chan struct{}),
|
||||||
abort: make(chan struct{}),
|
abort: make(chan struct{}),
|
||||||
quit: make(chan struct{}),
|
quit: make(chan struct{}),
|
||||||
errHandler: errHandler,
|
errHandler: params.errHandler,
|
||||||
handler: HandlerFunc(func(ctx context.Context, t *Task) error { return fmt.Errorf("handler not set") }),
|
handler: HandlerFunc(func(ctx context.Context, t *Task) error { return fmt.Errorf("handler not set") }),
|
||||||
|
starting: params.starting,
|
||||||
|
finished: params.finished,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -93,7 +111,7 @@ func newProcessor(l Logger, r *rdb.RDB, ps *base.ProcessState, fn retryDelayFunc
|
|||||||
// It's safe to call this method multiple times.
|
// It's safe to call this method multiple times.
|
||||||
func (p *processor) stop() {
|
func (p *processor) stop() {
|
||||||
p.once.Do(func() {
|
p.once.Do(func() {
|
||||||
p.logger.Info("Processor shutting down...")
|
p.logger.Debug("Processor shutting down...")
|
||||||
// Unblock if processor is waiting for sema token.
|
// Unblock if processor is waiting for sema token.
|
||||||
close(p.abort)
|
close(p.abort)
|
||||||
// Signal the processor goroutine to stop processing tasks
|
// Signal the processor goroutine to stop processing tasks
|
||||||
@@ -106,9 +124,7 @@ func (p *processor) stop() {
|
|||||||
func (p *processor) terminate() {
|
func (p *processor) terminate() {
|
||||||
p.stop()
|
p.stop()
|
||||||
|
|
||||||
// IDEA: Allow user to customize this timeout value.
|
time.AfterFunc(p.shutdownTimeout, func() { close(p.quit) })
|
||||||
const timeout = 8 * time.Second
|
|
||||||
time.AfterFunc(timeout, func() { close(p.quit) })
|
|
||||||
p.logger.Info("Waiting for all workers to finish...")
|
p.logger.Info("Waiting for all workers to finish...")
|
||||||
|
|
||||||
// send cancellation signal to all in-progress task handlers
|
// send cancellation signal to all in-progress task handlers
|
||||||
@@ -134,7 +150,7 @@ func (p *processor) start(wg *sync.WaitGroup) {
|
|||||||
for {
|
for {
|
||||||
select {
|
select {
|
||||||
case <-p.done:
|
case <-p.done:
|
||||||
p.logger.Info("Processor done")
|
p.logger.Debug("Processor done")
|
||||||
return
|
return
|
||||||
default:
|
default:
|
||||||
p.exec()
|
p.exec()
|
||||||
@@ -147,20 +163,19 @@ func (p *processor) start(wg *sync.WaitGroup) {
|
|||||||
// process the task.
|
// process the task.
|
||||||
func (p *processor) exec() {
|
func (p *processor) exec() {
|
||||||
qnames := p.queues()
|
qnames := p.queues()
|
||||||
msg, err := p.rdb.Dequeue(qnames...)
|
msg, err := p.broker.Dequeue(qnames...)
|
||||||
if err == rdb.ErrNoProcessableTask {
|
switch {
|
||||||
// queues are empty, this is a normal behavior.
|
case err == rdb.ErrNoProcessableTask:
|
||||||
if len(p.queueConfig) > 1 {
|
p.logger.Debug("All queues are empty")
|
||||||
// sleep to avoid slamming redis and let scheduler move tasks into queues.
|
// Queues are empty, this is a normal behavior.
|
||||||
// Note: With multiple queues, we are not using blocking pop operation and
|
// Sleep to avoid slamming redis and let scheduler move tasks into queues.
|
||||||
// polling queues instead. This adds significant load to redis.
|
// Note: We are not using blocking pop operation and polling queues instead.
|
||||||
time.Sleep(time.Second)
|
// This adds significant load to redis.
|
||||||
}
|
time.Sleep(time.Second)
|
||||||
return
|
return
|
||||||
}
|
case err != nil:
|
||||||
if err != nil {
|
|
||||||
if p.errLogLimiter.Allow() {
|
if p.errLogLimiter.Allow() {
|
||||||
p.logger.Error("Dequeue error: %v", err)
|
p.logger.Errorf("Dequeue error: %v", err)
|
||||||
}
|
}
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -171,26 +186,28 @@ func (p *processor) exec() {
|
|||||||
p.requeue(msg)
|
p.requeue(msg)
|
||||||
return
|
return
|
||||||
case p.sema <- struct{}{}: // acquire token
|
case p.sema <- struct{}{}: // acquire token
|
||||||
p.ps.AddWorkerStats(msg, time.Now())
|
p.starting <- msg
|
||||||
go func() {
|
go func() {
|
||||||
defer func() {
|
defer func() {
|
||||||
p.ps.DeleteWorkerStats(msg)
|
p.finished <- msg
|
||||||
<-p.sema /* release token */
|
<-p.sema // release token
|
||||||
|
}()
|
||||||
|
|
||||||
|
ctx, cancel := createContext(msg)
|
||||||
|
p.cancelations.Add(msg.ID.String(), cancel)
|
||||||
|
defer func() {
|
||||||
|
cancel()
|
||||||
|
p.cancelations.Delete(msg.ID.String())
|
||||||
}()
|
}()
|
||||||
|
|
||||||
resCh := make(chan error, 1)
|
resCh := make(chan error, 1)
|
||||||
task := NewTask(msg.Type, msg.Payload)
|
task := NewTask(msg.Type, msg.Payload)
|
||||||
ctx, cancel := createContext(msg)
|
go func() { resCh <- perform(ctx, task, p.handler) }()
|
||||||
p.cancelations.Add(msg.ID.String(), cancel)
|
|
||||||
go func() {
|
|
||||||
resCh <- perform(ctx, task, p.handler)
|
|
||||||
p.cancelations.Delete(msg.ID.String())
|
|
||||||
}()
|
|
||||||
|
|
||||||
select {
|
select {
|
||||||
case <-p.quit:
|
case <-p.quit:
|
||||||
// time is up, quit this worker goroutine.
|
// time is up, quit this worker goroutine.
|
||||||
p.logger.Warn("Quitting worker. task id=%s", msg.ID)
|
p.logger.Warnf("Quitting worker. task id=%s", msg.ID)
|
||||||
return
|
return
|
||||||
case resErr := <-resCh:
|
case resErr := <-resCh:
|
||||||
// Note: One of three things should happen.
|
// Note: One of three things should happen.
|
||||||
@@ -217,30 +234,30 @@ func (p *processor) exec() {
|
|||||||
// restore moves all tasks from "in-progress" back to queue
|
// restore moves all tasks from "in-progress" back to queue
|
||||||
// to restore all unfinished tasks.
|
// to restore all unfinished tasks.
|
||||||
func (p *processor) restore() {
|
func (p *processor) restore() {
|
||||||
n, err := p.rdb.RequeueAll()
|
n, err := p.broker.RequeueAll()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
p.logger.Error("Could not restore unfinished tasks: %v", err)
|
p.logger.Errorf("Could not restore unfinished tasks: %v", err)
|
||||||
}
|
}
|
||||||
if n > 0 {
|
if n > 0 {
|
||||||
p.logger.Info("Restored %d unfinished tasks back to queue", n)
|
p.logger.Infof("Restored %d unfinished tasks back to queue", n)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (p *processor) requeue(msg *base.TaskMessage) {
|
func (p *processor) requeue(msg *base.TaskMessage) {
|
||||||
err := p.rdb.Requeue(msg)
|
err := p.broker.Requeue(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
p.logger.Error("Could not push task id=%s back to queue: %v", msg.ID, err)
|
p.logger.Errorf("Could not push task id=%s back to queue: %v", msg.ID, err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (p *processor) markAsDone(msg *base.TaskMessage) {
|
func (p *processor) markAsDone(msg *base.TaskMessage) {
|
||||||
err := p.rdb.Done(msg)
|
err := p.broker.Done(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
errMsg := fmt.Sprintf("Could not remove task id=%s from %q", msg.ID, base.InProgressQueue)
|
errMsg := fmt.Sprintf("Could not remove task id=%s type=%q from %q err: %+v", msg.ID, msg.Type, base.InProgressQueue, err)
|
||||||
p.logger.Warn("%s; Will retry syncing", errMsg)
|
p.logger.Warnf("%s; Will retry syncing", errMsg)
|
||||||
p.syncRequestCh <- &syncRequest{
|
p.syncRequestCh <- &syncRequest{
|
||||||
fn: func() error {
|
fn: func() error {
|
||||||
return p.rdb.Done(msg)
|
return p.broker.Done(msg)
|
||||||
},
|
},
|
||||||
errMsg: errMsg,
|
errMsg: errMsg,
|
||||||
}
|
}
|
||||||
@@ -250,13 +267,13 @@ func (p *processor) markAsDone(msg *base.TaskMessage) {
|
|||||||
func (p *processor) retry(msg *base.TaskMessage, e error) {
|
func (p *processor) retry(msg *base.TaskMessage, e error) {
|
||||||
d := p.retryDelayFunc(msg.Retried, e, NewTask(msg.Type, msg.Payload))
|
d := p.retryDelayFunc(msg.Retried, e, NewTask(msg.Type, msg.Payload))
|
||||||
retryAt := time.Now().Add(d)
|
retryAt := time.Now().Add(d)
|
||||||
err := p.rdb.Retry(msg, retryAt, e.Error())
|
err := p.broker.Retry(msg, retryAt, e.Error())
|
||||||
if err != nil {
|
if err != nil {
|
||||||
errMsg := fmt.Sprintf("Could not move task id=%s from %q to %q", msg.ID, base.InProgressQueue, base.RetryQueue)
|
errMsg := fmt.Sprintf("Could not move task id=%s from %q to %q", msg.ID, base.InProgressQueue, base.RetryQueue)
|
||||||
p.logger.Warn("%s; Will retry syncing", errMsg)
|
p.logger.Warnf("%s; Will retry syncing", errMsg)
|
||||||
p.syncRequestCh <- &syncRequest{
|
p.syncRequestCh <- &syncRequest{
|
||||||
fn: func() error {
|
fn: func() error {
|
||||||
return p.rdb.Retry(msg, retryAt, e.Error())
|
return p.broker.Retry(msg, retryAt, e.Error())
|
||||||
},
|
},
|
||||||
errMsg: errMsg,
|
errMsg: errMsg,
|
||||||
}
|
}
|
||||||
@@ -264,14 +281,14 @@ func (p *processor) retry(msg *base.TaskMessage, e error) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (p *processor) kill(msg *base.TaskMessage, e error) {
|
func (p *processor) kill(msg *base.TaskMessage, e error) {
|
||||||
p.logger.Warn("Retry exhausted for task id=%s", msg.ID)
|
p.logger.Warnf("Retry exhausted for task id=%s", msg.ID)
|
||||||
err := p.rdb.Kill(msg, e.Error())
|
err := p.broker.Kill(msg, e.Error())
|
||||||
if err != nil {
|
if err != nil {
|
||||||
errMsg := fmt.Sprintf("Could not move task id=%s from %q to %q", msg.ID, base.InProgressQueue, base.DeadQueue)
|
errMsg := fmt.Sprintf("Could not move task id=%s from %q to %q", msg.ID, base.InProgressQueue, base.DeadQueue)
|
||||||
p.logger.Warn("%s; Will retry syncing", errMsg)
|
p.logger.Warnf("%s; Will retry syncing", errMsg)
|
||||||
p.syncRequestCh <- &syncRequest{
|
p.syncRequestCh <- &syncRequest{
|
||||||
fn: func() error {
|
fn: func() error {
|
||||||
return p.rdb.Kill(msg, e.Error())
|
return p.broker.Kill(msg, e.Error())
|
||||||
},
|
},
|
||||||
errMsg: errMsg,
|
errMsg: errMsg,
|
||||||
}
|
}
|
||||||
@@ -296,7 +313,7 @@ func (p *processor) queues() []string {
|
|||||||
}
|
}
|
||||||
var names []string
|
var names []string
|
||||||
for qname, priority := range p.queueConfig {
|
for qname, priority := range p.queueConfig {
|
||||||
for i := 0; i < int(priority); i++ {
|
for i := 0; i < priority; i++ {
|
||||||
names = append(names, qname)
|
names = append(names, qname)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -360,16 +377,15 @@ func (x byPriority) Len() int { return len(x) }
|
|||||||
func (x byPriority) Less(i, j int) bool { return x[i].priority < x[j].priority }
|
func (x byPriority) Less(i, j int) bool { return x[i].priority < x[j].priority }
|
||||||
func (x byPriority) Swap(i, j int) { x[i], x[j] = x[j], x[i] }
|
func (x byPriority) Swap(i, j int) { x[i], x[j] = x[j], x[i] }
|
||||||
|
|
||||||
// normalizeQueueCfg divides priority numbers by their
|
// normalizeQueues divides priority numbers by their greatest common divisor.
|
||||||
// greatest common divisor.
|
func normalizeQueues(queues map[string]int) map[string]int {
|
||||||
func normalizeQueueCfg(queueCfg map[string]int) map[string]int {
|
|
||||||
var xs []int
|
var xs []int
|
||||||
for _, x := range queueCfg {
|
for _, x := range queues {
|
||||||
xs = append(xs, x)
|
xs = append(xs, x)
|
||||||
}
|
}
|
||||||
d := gcd(xs...)
|
d := gcd(xs...)
|
||||||
res := make(map[string]int)
|
res := make(map[string]int)
|
||||||
for q, x := range queueCfg {
|
for q, x := range queues {
|
||||||
res[q] = x / d
|
res[q] = x / d
|
||||||
}
|
}
|
||||||
return res
|
return res
|
||||||
@@ -391,20 +407,3 @@ func gcd(xs ...int) int {
|
|||||||
}
|
}
|
||||||
return res
|
return res
|
||||||
}
|
}
|
||||||
|
|
||||||
// createContext returns a context and cancel function for a given task message.
|
|
||||||
func createContext(msg *base.TaskMessage) (ctx context.Context, cancel context.CancelFunc) {
|
|
||||||
ctx = context.Background()
|
|
||||||
timeout, err := time.ParseDuration(msg.Timeout)
|
|
||||||
if err == nil && timeout != 0 {
|
|
||||||
ctx, cancel = context.WithTimeout(ctx, timeout)
|
|
||||||
}
|
|
||||||
deadline, err := time.Parse(time.RFC3339, msg.Deadline)
|
|
||||||
if err == nil && !deadline.IsZero() {
|
|
||||||
ctx, cancel = context.WithDeadline(ctx, deadline)
|
|
||||||
}
|
|
||||||
if cancel == nil {
|
|
||||||
ctx, cancel = context.WithCancel(ctx)
|
|
||||||
}
|
|
||||||
return ctx, cancel
|
|
||||||
}
|
|
||||||
|
@@ -17,9 +17,31 @@ import (
|
|||||||
h "github.com/hibiken/asynq/internal/asynqtest"
|
h "github.com/hibiken/asynq/internal/asynqtest"
|
||||||
"github.com/hibiken/asynq/internal/base"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
"github.com/hibiken/asynq/internal/rdb"
|
"github.com/hibiken/asynq/internal/rdb"
|
||||||
"github.com/rs/xid"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// fakeHeartbeater receives from starting and finished channels and do nothing.
|
||||||
|
func fakeHeartbeater(starting, finished <-chan *base.TaskMessage, done <-chan struct{}) {
|
||||||
|
for {
|
||||||
|
select {
|
||||||
|
case <-starting:
|
||||||
|
case <-finished:
|
||||||
|
case <-done:
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// fakeSyncer receives from sync channel and do nothing.
|
||||||
|
func fakeSyncer(syncCh <-chan *syncRequest, done <-chan struct{}) {
|
||||||
|
for {
|
||||||
|
select {
|
||||||
|
case <-syncCh:
|
||||||
|
case <-done:
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestProcessorSuccess(t *testing.T) {
|
func TestProcessorSuccess(t *testing.T) {
|
||||||
r := setup(t)
|
r := setup(t)
|
||||||
rdbClient := rdb.NewRDB(r)
|
rdbClient := rdb.NewRDB(r)
|
||||||
@@ -37,19 +59,16 @@ func TestProcessorSuccess(t *testing.T) {
|
|||||||
tests := []struct {
|
tests := []struct {
|
||||||
enqueued []*base.TaskMessage // initial default queue state
|
enqueued []*base.TaskMessage // initial default queue state
|
||||||
incoming []*base.TaskMessage // tasks to be enqueued during run
|
incoming []*base.TaskMessage // tasks to be enqueued during run
|
||||||
wait time.Duration // wait duration between starting and stopping processor for this test case
|
|
||||||
wantProcessed []*Task // tasks to be processed at the end
|
wantProcessed []*Task // tasks to be processed at the end
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
enqueued: []*base.TaskMessage{m1},
|
enqueued: []*base.TaskMessage{m1},
|
||||||
incoming: []*base.TaskMessage{m2, m3, m4},
|
incoming: []*base.TaskMessage{m2, m3, m4},
|
||||||
wait: time.Second,
|
|
||||||
wantProcessed: []*Task{t1, t2, t3, t4},
|
wantProcessed: []*Task{t1, t2, t3, t4},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
enqueued: []*base.TaskMessage{},
|
enqueued: []*base.TaskMessage{},
|
||||||
incoming: []*base.TaskMessage{m1},
|
incoming: []*base.TaskMessage{m1},
|
||||||
wait: time.Second,
|
|
||||||
wantProcessed: []*Task{t1},
|
wantProcessed: []*Task{t1},
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
@@ -67,13 +86,30 @@ func TestProcessorSuccess(t *testing.T) {
|
|||||||
processed = append(processed, task)
|
processed = append(processed, task)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
ps := base.NewProcessState("localhost", 1234, 10, defaultQueueConfig, false)
|
starting := make(chan *base.TaskMessage)
|
||||||
cancelations := base.NewCancelations()
|
finished := make(chan *base.TaskMessage)
|
||||||
p := newProcessor(testLogger, rdbClient, ps, defaultDelayFunc, nil, cancelations, nil)
|
syncCh := make(chan *syncRequest)
|
||||||
|
done := make(chan struct{})
|
||||||
|
defer func() { close(done) }()
|
||||||
|
go fakeHeartbeater(starting, finished, done)
|
||||||
|
go fakeSyncer(syncCh, done)
|
||||||
|
p := newProcessor(processorParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: rdbClient,
|
||||||
|
retryDelayFunc: defaultDelayFunc,
|
||||||
|
syncCh: syncCh,
|
||||||
|
cancelations: base.NewCancelations(),
|
||||||
|
concurrency: 10,
|
||||||
|
queues: defaultQueueConfig,
|
||||||
|
strictPriority: false,
|
||||||
|
errHandler: nil,
|
||||||
|
shutdownTimeout: defaultShutdownTimeout,
|
||||||
|
starting: starting,
|
||||||
|
finished: finished,
|
||||||
|
})
|
||||||
p.handler = HandlerFunc(handler)
|
p.handler = HandlerFunc(handler)
|
||||||
|
|
||||||
var wg sync.WaitGroup
|
p.start(&sync.WaitGroup{})
|
||||||
p.start(&wg)
|
|
||||||
for _, msg := range tc.incoming {
|
for _, msg := range tc.incoming {
|
||||||
err := rdbClient.Enqueue(msg)
|
err := rdbClient.Enqueue(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -81,16 +117,90 @@ func TestProcessorSuccess(t *testing.T) {
|
|||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
time.Sleep(tc.wait)
|
time.Sleep(2 * time.Second) // wait for two second to allow all enqueued tasks to be processed.
|
||||||
p.terminate()
|
|
||||||
|
|
||||||
if diff := cmp.Diff(tc.wantProcessed, processed, sortTaskOpt, cmp.AllowUnexported(Payload{})); diff != "" {
|
|
||||||
t.Errorf("mismatch found in processed tasks; (-want, +got)\n%s", diff)
|
|
||||||
}
|
|
||||||
|
|
||||||
if l := r.LLen(base.InProgressQueue).Val(); l != 0 {
|
if l := r.LLen(base.InProgressQueue).Val(); l != 0 {
|
||||||
t.Errorf("%q has %d tasks, want 0", base.InProgressQueue, l)
|
t.Errorf("%q has %d tasks, want 0", base.InProgressQueue, l)
|
||||||
}
|
}
|
||||||
|
p.terminate()
|
||||||
|
|
||||||
|
mu.Lock()
|
||||||
|
if diff := cmp.Diff(tc.wantProcessed, processed, sortTaskOpt, cmp.AllowUnexported(Payload{})); diff != "" {
|
||||||
|
t.Errorf("mismatch found in processed tasks; (-want, +got)\n%s", diff)
|
||||||
|
}
|
||||||
|
mu.Unlock()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// https://github.com/hibiken/asynq/issues/166
|
||||||
|
func TestProcessTasksWithLargeNumberInPayload(t *testing.T) {
|
||||||
|
r := setup(t)
|
||||||
|
rdbClient := rdb.NewRDB(r)
|
||||||
|
|
||||||
|
m1 := h.NewTaskMessage("large_number", map[string]interface{}{"data": 111111111111111111})
|
||||||
|
t1 := NewTask(m1.Type, m1.Payload)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
enqueued []*base.TaskMessage // initial default queue state
|
||||||
|
wantProcessed []*Task // tasks to be processed at the end
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
enqueued: []*base.TaskMessage{m1},
|
||||||
|
wantProcessed: []*Task{t1},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
h.FlushDB(t, r) // clean up db before each test case.
|
||||||
|
h.SeedEnqueuedQueue(t, r, tc.enqueued) // initialize default queue.
|
||||||
|
|
||||||
|
var mu sync.Mutex
|
||||||
|
var processed []*Task
|
||||||
|
handler := func(ctx context.Context, task *Task) error {
|
||||||
|
mu.Lock()
|
||||||
|
defer mu.Unlock()
|
||||||
|
if data, err := task.Payload.GetInt("data"); err != nil {
|
||||||
|
t.Errorf("coult not get data from payload: %v", err)
|
||||||
|
} else {
|
||||||
|
t.Logf("data == %d", data)
|
||||||
|
}
|
||||||
|
processed = append(processed, task)
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
starting := make(chan *base.TaskMessage)
|
||||||
|
finished := make(chan *base.TaskMessage)
|
||||||
|
syncCh := make(chan *syncRequest)
|
||||||
|
done := make(chan struct{})
|
||||||
|
defer func() { close(done) }()
|
||||||
|
go fakeHeartbeater(starting, finished, done)
|
||||||
|
go fakeSyncer(syncCh, done)
|
||||||
|
p := newProcessor(processorParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: rdbClient,
|
||||||
|
retryDelayFunc: defaultDelayFunc,
|
||||||
|
syncCh: syncCh,
|
||||||
|
cancelations: base.NewCancelations(),
|
||||||
|
concurrency: 10,
|
||||||
|
queues: defaultQueueConfig,
|
||||||
|
strictPriority: false,
|
||||||
|
errHandler: nil,
|
||||||
|
shutdownTimeout: defaultShutdownTimeout,
|
||||||
|
starting: starting,
|
||||||
|
finished: finished,
|
||||||
|
})
|
||||||
|
p.handler = HandlerFunc(handler)
|
||||||
|
|
||||||
|
p.start(&sync.WaitGroup{})
|
||||||
|
time.Sleep(2 * time.Second) // wait for two second to allow all enqueued tasks to be processed.
|
||||||
|
if l := r.LLen(base.InProgressQueue).Val(); l != 0 {
|
||||||
|
t.Errorf("%q has %d tasks, want 0", base.InProgressQueue, l)
|
||||||
|
}
|
||||||
|
p.terminate()
|
||||||
|
|
||||||
|
mu.Lock()
|
||||||
|
if diff := cmp.Diff(tc.wantProcessed, processed, sortTaskOpt, cmpopts.IgnoreUnexported(Payload{})); diff != "" {
|
||||||
|
t.Errorf("mismatch found in processed tasks; (-want, +got)\n%s", diff)
|
||||||
|
}
|
||||||
|
mu.Unlock()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -137,7 +247,7 @@ func TestProcessorRetry(t *testing.T) {
|
|||||||
handler: HandlerFunc(func(ctx context.Context, task *Task) error {
|
handler: HandlerFunc(func(ctx context.Context, task *Task) error {
|
||||||
return fmt.Errorf(errMsg)
|
return fmt.Errorf(errMsg)
|
||||||
}),
|
}),
|
||||||
wait: time.Second,
|
wait: 2 * time.Second,
|
||||||
wantRetry: []h.ZSetEntry{
|
wantRetry: []h.ZSetEntry{
|
||||||
{Msg: &r2, Score: float64(now.Add(time.Minute).Unix())},
|
{Msg: &r2, Score: float64(now.Add(time.Minute).Unix())},
|
||||||
{Msg: &r3, Score: float64(now.Add(time.Minute).Unix())},
|
{Msg: &r3, Score: float64(now.Add(time.Minute).Unix())},
|
||||||
@@ -165,13 +275,28 @@ func TestProcessorRetry(t *testing.T) {
|
|||||||
defer mu.Unlock()
|
defer mu.Unlock()
|
||||||
n++
|
n++
|
||||||
}
|
}
|
||||||
ps := base.NewProcessState("localhost", 1234, 10, defaultQueueConfig, false)
|
starting := make(chan *base.TaskMessage)
|
||||||
cancelations := base.NewCancelations()
|
finished := make(chan *base.TaskMessage)
|
||||||
p := newProcessor(testLogger, rdbClient, ps, delayFunc, nil, cancelations, ErrorHandlerFunc(errHandler))
|
done := make(chan struct{})
|
||||||
|
defer func() { close(done) }()
|
||||||
|
go fakeHeartbeater(starting, finished, done)
|
||||||
|
p := newProcessor(processorParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: rdbClient,
|
||||||
|
retryDelayFunc: delayFunc,
|
||||||
|
syncCh: nil,
|
||||||
|
cancelations: base.NewCancelations(),
|
||||||
|
concurrency: 10,
|
||||||
|
queues: defaultQueueConfig,
|
||||||
|
strictPriority: false,
|
||||||
|
errHandler: ErrorHandlerFunc(errHandler),
|
||||||
|
shutdownTimeout: defaultShutdownTimeout,
|
||||||
|
starting: starting,
|
||||||
|
finished: finished,
|
||||||
|
})
|
||||||
p.handler = tc.handler
|
p.handler = tc.handler
|
||||||
|
|
||||||
var wg sync.WaitGroup
|
p.start(&sync.WaitGroup{})
|
||||||
p.start(&wg)
|
|
||||||
for _, msg := range tc.incoming {
|
for _, msg := range tc.incoming {
|
||||||
err := rdbClient.Enqueue(msg)
|
err := rdbClient.Enqueue(msg)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -179,10 +304,10 @@ func TestProcessorRetry(t *testing.T) {
|
|||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
time.Sleep(tc.wait)
|
time.Sleep(tc.wait) // FIXME: This makes test flaky.
|
||||||
p.terminate()
|
p.terminate()
|
||||||
|
|
||||||
cmpOpt := cmpopts.EquateApprox(0, float64(time.Second)) // allow up to second difference in zset score
|
cmpOpt := cmpopts.EquateApprox(0, float64(time.Second)) // allow up to a second difference in zset score
|
||||||
gotRetry := h.GetRetryEntries(t, r)
|
gotRetry := h.GetRetryEntries(t, r)
|
||||||
if diff := cmp.Diff(tc.wantRetry, gotRetry, h.SortZSetEntryOpt, cmpOpt); diff != "" {
|
if diff := cmp.Diff(tc.wantRetry, gotRetry, h.SortZSetEntryOpt, cmpOpt); diff != "" {
|
||||||
t.Errorf("mismatch found in %q after running processor; (-want, +got)\n%s", base.RetryQueue, diff)
|
t.Errorf("mismatch found in %q after running processor; (-want, +got)\n%s", base.RetryQueue, diff)
|
||||||
@@ -231,9 +356,25 @@ func TestProcessorQueues(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
cancelations := base.NewCancelations()
|
starting := make(chan *base.TaskMessage)
|
||||||
ps := base.NewProcessState("localhost", 1234, 10, tc.queueCfg, false)
|
finished := make(chan *base.TaskMessage)
|
||||||
p := newProcessor(testLogger, nil, ps, defaultDelayFunc, nil, cancelations, nil)
|
done := make(chan struct{})
|
||||||
|
defer func() { close(done) }()
|
||||||
|
go fakeHeartbeater(starting, finished, done)
|
||||||
|
p := newProcessor(processorParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: nil,
|
||||||
|
retryDelayFunc: defaultDelayFunc,
|
||||||
|
syncCh: nil,
|
||||||
|
cancelations: base.NewCancelations(),
|
||||||
|
concurrency: 10,
|
||||||
|
queues: tc.queueCfg,
|
||||||
|
strictPriority: false,
|
||||||
|
errHandler: nil,
|
||||||
|
shutdownTimeout: defaultShutdownTimeout,
|
||||||
|
starting: starting,
|
||||||
|
finished: finished,
|
||||||
|
})
|
||||||
got := p.queues()
|
got := p.queues()
|
||||||
if diff := cmp.Diff(tc.want, got, sortOpt); diff != "" {
|
if diff := cmp.Diff(tc.want, got, sortOpt); diff != "" {
|
||||||
t.Errorf("with queue config: %v\n(*processor).queues() = %v, want %v\n(-want,+got):\n%s",
|
t.Errorf("with queue config: %v\n(*processor).queues() = %v, want %v\n(-want,+got):\n%s",
|
||||||
@@ -298,14 +439,28 @@ func TestProcessorWithStrictPriority(t *testing.T) {
|
|||||||
base.DefaultQueueName: 2,
|
base.DefaultQueueName: 2,
|
||||||
"low": 1,
|
"low": 1,
|
||||||
}
|
}
|
||||||
// Note: Set concurrency to 1 to make sure tasks are processed one at a time.
|
starting := make(chan *base.TaskMessage)
|
||||||
cancelations := base.NewCancelations()
|
finished := make(chan *base.TaskMessage)
|
||||||
ps := base.NewProcessState("localhost", 1234, 1 /* concurrency */, queueCfg, true /*strict*/)
|
done := make(chan struct{})
|
||||||
p := newProcessor(testLogger, rdbClient, ps, defaultDelayFunc, nil, cancelations, nil)
|
defer func() { close(done) }()
|
||||||
|
go fakeHeartbeater(starting, finished, done)
|
||||||
|
p := newProcessor(processorParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: rdbClient,
|
||||||
|
retryDelayFunc: defaultDelayFunc,
|
||||||
|
syncCh: nil,
|
||||||
|
cancelations: base.NewCancelations(),
|
||||||
|
concurrency: 1, // Set concurrency to 1 to make sure tasks are processed one at a time.
|
||||||
|
queues: queueCfg,
|
||||||
|
strictPriority: true,
|
||||||
|
errHandler: nil,
|
||||||
|
shutdownTimeout: defaultShutdownTimeout,
|
||||||
|
starting: starting,
|
||||||
|
finished: finished,
|
||||||
|
})
|
||||||
p.handler = HandlerFunc(handler)
|
p.handler = HandlerFunc(handler)
|
||||||
|
|
||||||
var wg sync.WaitGroup
|
p.start(&sync.WaitGroup{})
|
||||||
p.start(&wg)
|
|
||||||
time.Sleep(tc.wait)
|
time.Sleep(tc.wait)
|
||||||
p.terminate()
|
p.terminate()
|
||||||
|
|
||||||
@@ -365,84 +520,82 @@ func TestPerform(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestCreateContextWithTimeRestrictions(t *testing.T) {
|
func TestGCD(t *testing.T) {
|
||||||
var (
|
|
||||||
noTimeout = time.Duration(0)
|
|
||||||
noDeadline = time.Time{}
|
|
||||||
)
|
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
desc string
|
input []int
|
||||||
timeout time.Duration
|
want int
|
||||||
deadline time.Time
|
|
||||||
wantDeadline time.Time
|
|
||||||
}{
|
}{
|
||||||
{"only with timeout", 10 * time.Second, noDeadline, time.Now().Add(10 * time.Second)},
|
{[]int{6, 2, 12}, 2},
|
||||||
{"only with deadline", noTimeout, time.Now().Add(time.Hour), time.Now().Add(time.Hour)},
|
{[]int{3, 3, 3}, 3},
|
||||||
{"with timeout and deadline (timeout < deadline)", 10 * time.Second, time.Now().Add(time.Hour), time.Now().Add(10 * time.Second)},
|
{[]int{6, 3, 1}, 1},
|
||||||
{"with timeout and deadline (timeout > deadline)", 10 * time.Minute, time.Now().Add(30 * time.Second), time.Now().Add(30 * time.Second)},
|
{[]int{1}, 1},
|
||||||
|
{[]int{1, 0, 2}, 1},
|
||||||
|
{[]int{8, 0, 4}, 4},
|
||||||
|
{[]int{9, 12, 18, 30}, 3},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range tests {
|
for _, tc := range tests {
|
||||||
msg := &base.TaskMessage{
|
got := gcd(tc.input...)
|
||||||
Type: "something",
|
if got != tc.want {
|
||||||
ID: xid.New(),
|
t.Errorf("gcd(%v) = %d, want %d", tc.input, got, tc.want)
|
||||||
Timeout: tc.timeout.String(),
|
|
||||||
Deadline: tc.deadline.Format(time.RFC3339),
|
|
||||||
}
|
|
||||||
|
|
||||||
ctx, cancel := createContext(msg)
|
|
||||||
|
|
||||||
select {
|
|
||||||
case x := <-ctx.Done():
|
|
||||||
t.Errorf("%s: <-ctx.Done() == %v, want nothing (it should block)", tc.desc, x)
|
|
||||||
default:
|
|
||||||
}
|
|
||||||
|
|
||||||
got, ok := ctx.Deadline()
|
|
||||||
if !ok {
|
|
||||||
t.Errorf("%s: ctx.Deadline() returned false, want deadline to be set", tc.desc)
|
|
||||||
}
|
|
||||||
if !cmp.Equal(tc.wantDeadline, got, cmpopts.EquateApproxTime(time.Second)) {
|
|
||||||
t.Errorf("%s: ctx.Deadline() returned %v, want %v", tc.desc, got, tc.wantDeadline)
|
|
||||||
}
|
|
||||||
|
|
||||||
cancel()
|
|
||||||
|
|
||||||
select {
|
|
||||||
case <-ctx.Done():
|
|
||||||
default:
|
|
||||||
t.Errorf("ctx.Done() blocked, want it to be non-blocking")
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestCreateContextWithoutTimeRestrictions(t *testing.T) {
|
func TestNormalizeQueues(t *testing.T) {
|
||||||
msg := &base.TaskMessage{
|
tests := []struct {
|
||||||
Type: "something",
|
input map[string]int
|
||||||
ID: xid.New(),
|
want map[string]int
|
||||||
Timeout: time.Duration(0).String(), // zero value to indicate no timeout
|
}{
|
||||||
Deadline: time.Time{}.Format(time.RFC3339), // zero value to indicate no deadline
|
{
|
||||||
|
input: map[string]int{
|
||||||
|
"high": 100,
|
||||||
|
"default": 20,
|
||||||
|
"low": 5,
|
||||||
|
},
|
||||||
|
want: map[string]int{
|
||||||
|
"high": 20,
|
||||||
|
"default": 4,
|
||||||
|
"low": 1,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
input: map[string]int{
|
||||||
|
"default": 10,
|
||||||
|
},
|
||||||
|
want: map[string]int{
|
||||||
|
"default": 1,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
input: map[string]int{
|
||||||
|
"critical": 5,
|
||||||
|
"default": 1,
|
||||||
|
},
|
||||||
|
want: map[string]int{
|
||||||
|
"critical": 5,
|
||||||
|
"default": 1,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
input: map[string]int{
|
||||||
|
"critical": 6,
|
||||||
|
"default": 3,
|
||||||
|
"low": 0,
|
||||||
|
},
|
||||||
|
want: map[string]int{
|
||||||
|
"critical": 2,
|
||||||
|
"default": 1,
|
||||||
|
"low": 0,
|
||||||
|
},
|
||||||
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
ctx, cancel := createContext(msg)
|
for _, tc := range tests {
|
||||||
|
got := normalizeQueues(tc.input)
|
||||||
select {
|
if diff := cmp.Diff(tc.want, got); diff != "" {
|
||||||
case x := <-ctx.Done():
|
t.Errorf("normalizeQueues(%v) = %v, want %v; (-want, +got):\n%s",
|
||||||
t.Errorf("<-ctx.Done() == %v, want nothing (it should block)", x)
|
tc.input, got, tc.want, diff)
|
||||||
default:
|
}
|
||||||
}
|
|
||||||
|
|
||||||
_, ok := ctx.Deadline()
|
|
||||||
if ok {
|
|
||||||
t.Error("ctx.Deadline() returned true, want deadline to not be set")
|
|
||||||
}
|
|
||||||
|
|
||||||
cancel()
|
|
||||||
|
|
||||||
select {
|
|
||||||
case <-ctx.Done():
|
|
||||||
default:
|
|
||||||
t.Error("ctx.Done() blocked, want it to be non-blocking")
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
37
scheduler.go
@@ -8,39 +8,38 @@ import (
|
|||||||
"sync"
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/hibiken/asynq/internal/rdb"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
|
"github.com/hibiken/asynq/internal/log"
|
||||||
)
|
)
|
||||||
|
|
||||||
type scheduler struct {
|
type scheduler struct {
|
||||||
logger Logger
|
logger *log.Logger
|
||||||
rdb *rdb.RDB
|
broker base.Broker
|
||||||
|
|
||||||
// channel to communicate back to the long running "scheduler" goroutine.
|
// channel to communicate back to the long running "scheduler" goroutine.
|
||||||
done chan struct{}
|
done chan struct{}
|
||||||
|
|
||||||
// poll interval on average
|
// poll interval on average
|
||||||
avgInterval time.Duration
|
avgInterval time.Duration
|
||||||
|
|
||||||
// list of queues to move the tasks into.
|
|
||||||
qnames []string
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func newScheduler(l Logger, r *rdb.RDB, avgInterval time.Duration, qcfg map[string]int) *scheduler {
|
type schedulerParams struct {
|
||||||
var qnames []string
|
logger *log.Logger
|
||||||
for q := range qcfg {
|
broker base.Broker
|
||||||
qnames = append(qnames, q)
|
interval time.Duration
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func newScheduler(params schedulerParams) *scheduler {
|
||||||
return &scheduler{
|
return &scheduler{
|
||||||
logger: l,
|
logger: params.logger,
|
||||||
rdb: r,
|
broker: params.broker,
|
||||||
done: make(chan struct{}),
|
done: make(chan struct{}),
|
||||||
avgInterval: avgInterval,
|
avgInterval: params.interval,
|
||||||
qnames: qnames,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *scheduler) terminate() {
|
func (s *scheduler) terminate() {
|
||||||
s.logger.Info("Scheduler shutting down...")
|
s.logger.Debug("Scheduler shutting down...")
|
||||||
// Signal the scheduler goroutine to stop polling.
|
// Signal the scheduler goroutine to stop polling.
|
||||||
s.done <- struct{}{}
|
s.done <- struct{}{}
|
||||||
}
|
}
|
||||||
@@ -53,7 +52,7 @@ func (s *scheduler) start(wg *sync.WaitGroup) {
|
|||||||
for {
|
for {
|
||||||
select {
|
select {
|
||||||
case <-s.done:
|
case <-s.done:
|
||||||
s.logger.Info("Scheduler done")
|
s.logger.Debug("Scheduler done")
|
||||||
return
|
return
|
||||||
case <-time.After(s.avgInterval):
|
case <-time.After(s.avgInterval):
|
||||||
s.exec()
|
s.exec()
|
||||||
@@ -63,7 +62,7 @@ func (s *scheduler) start(wg *sync.WaitGroup) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (s *scheduler) exec() {
|
func (s *scheduler) exec() {
|
||||||
if err := s.rdb.CheckAndEnqueue(s.qnames...); err != nil {
|
if err := s.broker.CheckAndEnqueue(); err != nil {
|
||||||
s.logger.Error("Could not enqueue scheduled tasks: %v", err)
|
s.logger.Errorf("Could not enqueue scheduled tasks: %v", err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@@ -19,7 +19,11 @@ func TestScheduler(t *testing.T) {
|
|||||||
r := setup(t)
|
r := setup(t)
|
||||||
rdbClient := rdb.NewRDB(r)
|
rdbClient := rdb.NewRDB(r)
|
||||||
const pollInterval = time.Second
|
const pollInterval = time.Second
|
||||||
s := newScheduler(testLogger, rdbClient, pollInterval, defaultQueueConfig)
|
s := newScheduler(schedulerParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: rdbClient,
|
||||||
|
interval: pollInterval,
|
||||||
|
})
|
||||||
t1 := h.NewTaskMessage("gen_thumbnail", nil)
|
t1 := h.NewTaskMessage("gen_thumbnail", nil)
|
||||||
t2 := h.NewTaskMessage("send_email", nil)
|
t2 := h.NewTaskMessage("send_email", nil)
|
||||||
t3 := h.NewTaskMessage("reindex", nil)
|
t3 := h.NewTaskMessage("reindex", nil)
|
||||||
|
@@ -15,7 +15,7 @@ import (
|
|||||||
// ServeMux is a multiplexer for asynchronous tasks.
|
// ServeMux is a multiplexer for asynchronous tasks.
|
||||||
// It matches the type of each task against a list of registered patterns
|
// It matches the type of each task against a list of registered patterns
|
||||||
// and calls the handler for the pattern that most closely matches the
|
// and calls the handler for the pattern that most closely matches the
|
||||||
// taks's type name.
|
// task's type name.
|
||||||
//
|
//
|
||||||
// Longer patterns take precedence over shorter ones, so that if there are
|
// Longer patterns take precedence over shorter ones, so that if there are
|
||||||
// handlers registered for both "images" and "images:thumbnails",
|
// handlers registered for both "images" and "images:thumbnails",
|
||||||
|
452
server.go
Normal file
@@ -0,0 +1,452 @@
|
|||||||
|
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
||||||
|
// Use of this source code is governed by a MIT license
|
||||||
|
// that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package asynq
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"math"
|
||||||
|
"math/rand"
|
||||||
|
"runtime"
|
||||||
|
"strings"
|
||||||
|
"sync"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/hibiken/asynq/internal/base"
|
||||||
|
"github.com/hibiken/asynq/internal/log"
|
||||||
|
"github.com/hibiken/asynq/internal/rdb"
|
||||||
|
)
|
||||||
|
|
||||||
|
// Server is responsible for managing the background-task processing.
|
||||||
|
//
|
||||||
|
// Server pulls tasks off queues and processes them.
|
||||||
|
// If the processing of a task is unsuccessful, server will
|
||||||
|
// schedule it for a retry.
|
||||||
|
// A task will be retried until either the task gets processed successfully
|
||||||
|
// or until it reaches its max retry count.
|
||||||
|
//
|
||||||
|
// If a task exhausts its retries, it will be moved to the "dead" queue and
|
||||||
|
// will be kept in the queue for some time until a certain condition is met
|
||||||
|
// (e.g., queue size reaches a certain limit, or the task has been in the
|
||||||
|
// queue for a certain amount of time).
|
||||||
|
type Server struct {
|
||||||
|
logger *log.Logger
|
||||||
|
|
||||||
|
broker base.Broker
|
||||||
|
|
||||||
|
status *base.ServerStatus
|
||||||
|
|
||||||
|
// wait group to wait for all goroutines to finish.
|
||||||
|
wg sync.WaitGroup
|
||||||
|
scheduler *scheduler
|
||||||
|
processor *processor
|
||||||
|
syncer *syncer
|
||||||
|
heartbeater *heartbeater
|
||||||
|
subscriber *subscriber
|
||||||
|
}
|
||||||
|
|
||||||
|
// Config specifies the server's background-task processing behavior.
|
||||||
|
type Config struct {
|
||||||
|
// Maximum number of concurrent processing of tasks.
|
||||||
|
//
|
||||||
|
// If set to a zero or negative value, NewServer will overwrite the value
|
||||||
|
// to the number of CPUs usable by the currennt process.
|
||||||
|
Concurrency int
|
||||||
|
|
||||||
|
// Function to calculate retry delay for a failed task.
|
||||||
|
//
|
||||||
|
// By default, it uses exponential backoff algorithm to calculate the delay.
|
||||||
|
//
|
||||||
|
// n is the number of times the task has been retried.
|
||||||
|
// e is the error returned by the task handler.
|
||||||
|
// t is the task in question.
|
||||||
|
RetryDelayFunc func(n int, e error, t *Task) time.Duration
|
||||||
|
|
||||||
|
// List of queues to process with given priority value. Keys are the names of the
|
||||||
|
// queues and values are associated priority value.
|
||||||
|
//
|
||||||
|
// If set to nil or not specified, the server will process only the "default" queue.
|
||||||
|
//
|
||||||
|
// Priority is treated as follows to avoid starving low priority queues.
|
||||||
|
//
|
||||||
|
// Example:
|
||||||
|
// Queues: map[string]int{
|
||||||
|
// "critical": 6,
|
||||||
|
// "default": 3,
|
||||||
|
// "low": 1,
|
||||||
|
// }
|
||||||
|
// With the above config and given that all queues are not empty, the tasks
|
||||||
|
// in "critical", "default", "low" should be processed 60%, 30%, 10% of
|
||||||
|
// the time respectively.
|
||||||
|
//
|
||||||
|
// If a queue has a zero or negative priority value, the queue will be ignored.
|
||||||
|
Queues map[string]int
|
||||||
|
|
||||||
|
// StrictPriority indicates whether the queue priority should be treated strictly.
|
||||||
|
//
|
||||||
|
// If set to true, tasks in the queue with the highest priority is processed first.
|
||||||
|
// The tasks in lower priority queues are processed only when those queues with
|
||||||
|
// higher priorities are empty.
|
||||||
|
StrictPriority bool
|
||||||
|
|
||||||
|
// ErrorHandler handles errors returned by the task handler.
|
||||||
|
//
|
||||||
|
// HandleError is invoked only if the task handler returns a non-nil error.
|
||||||
|
//
|
||||||
|
// Example:
|
||||||
|
// func reportError(task *asynq.Task, err error, retried, maxRetry int) {
|
||||||
|
// if retried >= maxRetry {
|
||||||
|
// err = fmt.Errorf("retry exhausted for task %s: %w", task.Type, err)
|
||||||
|
// }
|
||||||
|
// errorReportingService.Notify(err)
|
||||||
|
// })
|
||||||
|
//
|
||||||
|
// ErrorHandler: asynq.ErrorHandlerFunc(reportError)
|
||||||
|
ErrorHandler ErrorHandler
|
||||||
|
|
||||||
|
// Logger specifies the logger used by the server instance.
|
||||||
|
//
|
||||||
|
// If unset, default logger is used.
|
||||||
|
Logger Logger
|
||||||
|
|
||||||
|
// LogLevel specifies the minimum log level to enable.
|
||||||
|
//
|
||||||
|
// If unset, InfoLevel is used by default.
|
||||||
|
LogLevel LogLevel
|
||||||
|
|
||||||
|
// ShutdownTimeout specifies the duration to wait to let workers finish their tasks
|
||||||
|
// before forcing them to abort when stopping the server.
|
||||||
|
//
|
||||||
|
// If unset or zero, default timeout of 8 seconds is used.
|
||||||
|
ShutdownTimeout time.Duration
|
||||||
|
}
|
||||||
|
|
||||||
|
// An ErrorHandler handles errors returned by the task handler.
|
||||||
|
type ErrorHandler interface {
|
||||||
|
HandleError(task *Task, err error, retried, maxRetry int)
|
||||||
|
}
|
||||||
|
|
||||||
|
// The ErrorHandlerFunc type is an adapter to allow the use of ordinary functions as a ErrorHandler.
|
||||||
|
// If f is a function with the appropriate signature, ErrorHandlerFunc(f) is a ErrorHandler that calls f.
|
||||||
|
type ErrorHandlerFunc func(task *Task, err error, retried, maxRetry int)
|
||||||
|
|
||||||
|
// HandleError calls fn(task, err, retried, maxRetry)
|
||||||
|
func (fn ErrorHandlerFunc) HandleError(task *Task, err error, retried, maxRetry int) {
|
||||||
|
fn(task, err, retried, maxRetry)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Logger supports logging at various log levels.
|
||||||
|
type Logger interface {
|
||||||
|
// Debug logs a message at Debug level.
|
||||||
|
Debug(args ...interface{})
|
||||||
|
|
||||||
|
// Info logs a message at Info level.
|
||||||
|
Info(args ...interface{})
|
||||||
|
|
||||||
|
// Warn logs a message at Warning level.
|
||||||
|
Warn(args ...interface{})
|
||||||
|
|
||||||
|
// Error logs a message at Error level.
|
||||||
|
Error(args ...interface{})
|
||||||
|
|
||||||
|
// Fatal logs a message at Fatal level
|
||||||
|
// and process will exit with status set to 1.
|
||||||
|
Fatal(args ...interface{})
|
||||||
|
}
|
||||||
|
|
||||||
|
// LogLevel represents logging level.
|
||||||
|
//
|
||||||
|
// It satisfies flag.Value interface.
|
||||||
|
type LogLevel int32
|
||||||
|
|
||||||
|
const (
|
||||||
|
// Note: reserving value zero to differentiate unspecified case.
|
||||||
|
level_unspecified LogLevel = iota
|
||||||
|
|
||||||
|
// DebugLevel is the lowest level of logging.
|
||||||
|
// Debug logs are intended for debugging and development purposes.
|
||||||
|
DebugLevel
|
||||||
|
|
||||||
|
// InfoLevel is used for general informational log messages.
|
||||||
|
InfoLevel
|
||||||
|
|
||||||
|
// WarnLevel is used for undesired but relatively expected events,
|
||||||
|
// which may indicate a problem.
|
||||||
|
WarnLevel
|
||||||
|
|
||||||
|
// ErrorLevel is used for undesired and unexpected events that
|
||||||
|
// the program can recover from.
|
||||||
|
ErrorLevel
|
||||||
|
|
||||||
|
// FatalLevel is used for undesired and unexpected events that
|
||||||
|
// the program cannot recover from.
|
||||||
|
FatalLevel
|
||||||
|
)
|
||||||
|
|
||||||
|
// String is part of the flag.Value interface.
|
||||||
|
func (l *LogLevel) String() string {
|
||||||
|
switch *l {
|
||||||
|
case DebugLevel:
|
||||||
|
return "debug"
|
||||||
|
case InfoLevel:
|
||||||
|
return "info"
|
||||||
|
case WarnLevel:
|
||||||
|
return "warn"
|
||||||
|
case ErrorLevel:
|
||||||
|
return "error"
|
||||||
|
case FatalLevel:
|
||||||
|
return "fatal"
|
||||||
|
}
|
||||||
|
panic(fmt.Sprintf("asynq: unexpected log level: %v", *l))
|
||||||
|
}
|
||||||
|
|
||||||
|
// Set is part of the flag.Value interface.
|
||||||
|
func (l *LogLevel) Set(val string) error {
|
||||||
|
switch strings.ToLower(val) {
|
||||||
|
case "debug":
|
||||||
|
*l = DebugLevel
|
||||||
|
case "info":
|
||||||
|
*l = InfoLevel
|
||||||
|
case "warn", "warning":
|
||||||
|
*l = WarnLevel
|
||||||
|
case "error":
|
||||||
|
*l = ErrorLevel
|
||||||
|
case "fatal":
|
||||||
|
*l = FatalLevel
|
||||||
|
default:
|
||||||
|
return fmt.Errorf("asynq: unsupported log level %q", val)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func toInternalLogLevel(l LogLevel) log.Level {
|
||||||
|
switch l {
|
||||||
|
case DebugLevel:
|
||||||
|
return log.DebugLevel
|
||||||
|
case InfoLevel:
|
||||||
|
return log.InfoLevel
|
||||||
|
case WarnLevel:
|
||||||
|
return log.WarnLevel
|
||||||
|
case ErrorLevel:
|
||||||
|
return log.ErrorLevel
|
||||||
|
case FatalLevel:
|
||||||
|
return log.FatalLevel
|
||||||
|
}
|
||||||
|
panic(fmt.Sprintf("asynq: unexpected log level: %v", l))
|
||||||
|
}
|
||||||
|
|
||||||
|
// Formula taken from https://github.com/mperham/sidekiq.
|
||||||
|
func defaultDelayFunc(n int, e error, t *Task) time.Duration {
|
||||||
|
r := rand.New(rand.NewSource(time.Now().UnixNano()))
|
||||||
|
s := int(math.Pow(float64(n), 4)) + 15 + (r.Intn(30) * (n + 1))
|
||||||
|
return time.Duration(s) * time.Second
|
||||||
|
}
|
||||||
|
|
||||||
|
var defaultQueueConfig = map[string]int{
|
||||||
|
base.DefaultQueueName: 1,
|
||||||
|
}
|
||||||
|
|
||||||
|
const defaultShutdownTimeout = 8 * time.Second
|
||||||
|
|
||||||
|
// NewServer returns a new Server given a redis connection option
|
||||||
|
// and background processing configuration.
|
||||||
|
func NewServer(r RedisConnOpt, cfg Config) *Server {
|
||||||
|
n := cfg.Concurrency
|
||||||
|
if n < 1 {
|
||||||
|
n = runtime.NumCPU()
|
||||||
|
}
|
||||||
|
delayFunc := cfg.RetryDelayFunc
|
||||||
|
if delayFunc == nil {
|
||||||
|
delayFunc = defaultDelayFunc
|
||||||
|
}
|
||||||
|
queues := make(map[string]int)
|
||||||
|
for qname, p := range cfg.Queues {
|
||||||
|
if p > 0 {
|
||||||
|
queues[qname] = p
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(queues) == 0 {
|
||||||
|
queues = defaultQueueConfig
|
||||||
|
}
|
||||||
|
shutdownTimeout := cfg.ShutdownTimeout
|
||||||
|
if shutdownTimeout == 0 {
|
||||||
|
shutdownTimeout = defaultShutdownTimeout
|
||||||
|
}
|
||||||
|
logger := log.NewLogger(cfg.Logger)
|
||||||
|
loglevel := cfg.LogLevel
|
||||||
|
if loglevel == level_unspecified {
|
||||||
|
loglevel = InfoLevel
|
||||||
|
}
|
||||||
|
logger.SetLevel(toInternalLogLevel(loglevel))
|
||||||
|
|
||||||
|
rdb := rdb.NewRDB(createRedisClient(r))
|
||||||
|
starting := make(chan *base.TaskMessage)
|
||||||
|
finished := make(chan *base.TaskMessage)
|
||||||
|
syncCh := make(chan *syncRequest)
|
||||||
|
status := base.NewServerStatus(base.StatusIdle)
|
||||||
|
cancels := base.NewCancelations()
|
||||||
|
|
||||||
|
syncer := newSyncer(syncerParams{
|
||||||
|
logger: logger,
|
||||||
|
requestsCh: syncCh,
|
||||||
|
interval: 5 * time.Second,
|
||||||
|
})
|
||||||
|
heartbeater := newHeartbeater(heartbeaterParams{
|
||||||
|
logger: logger,
|
||||||
|
broker: rdb,
|
||||||
|
interval: 5 * time.Second,
|
||||||
|
concurrency: n,
|
||||||
|
queues: queues,
|
||||||
|
strictPriority: cfg.StrictPriority,
|
||||||
|
status: status,
|
||||||
|
starting: starting,
|
||||||
|
finished: finished,
|
||||||
|
})
|
||||||
|
scheduler := newScheduler(schedulerParams{
|
||||||
|
logger: logger,
|
||||||
|
broker: rdb,
|
||||||
|
interval: 5 * time.Second,
|
||||||
|
})
|
||||||
|
subscriber := newSubscriber(subscriberParams{
|
||||||
|
logger: logger,
|
||||||
|
broker: rdb,
|
||||||
|
cancelations: cancels,
|
||||||
|
})
|
||||||
|
processor := newProcessor(processorParams{
|
||||||
|
logger: logger,
|
||||||
|
broker: rdb,
|
||||||
|
retryDelayFunc: delayFunc,
|
||||||
|
syncCh: syncCh,
|
||||||
|
cancelations: cancels,
|
||||||
|
concurrency: n,
|
||||||
|
queues: queues,
|
||||||
|
strictPriority: cfg.StrictPriority,
|
||||||
|
errHandler: cfg.ErrorHandler,
|
||||||
|
shutdownTimeout: shutdownTimeout,
|
||||||
|
starting: starting,
|
||||||
|
finished: finished,
|
||||||
|
})
|
||||||
|
return &Server{
|
||||||
|
logger: logger,
|
||||||
|
broker: rdb,
|
||||||
|
status: status,
|
||||||
|
scheduler: scheduler,
|
||||||
|
processor: processor,
|
||||||
|
syncer: syncer,
|
||||||
|
heartbeater: heartbeater,
|
||||||
|
subscriber: subscriber,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A Handler processes tasks.
|
||||||
|
//
|
||||||
|
// ProcessTask should return nil if the processing of a task
|
||||||
|
// is successful.
|
||||||
|
//
|
||||||
|
// If ProcessTask return a non-nil error or panics, the task
|
||||||
|
// will be retried after delay.
|
||||||
|
type Handler interface {
|
||||||
|
ProcessTask(context.Context, *Task) error
|
||||||
|
}
|
||||||
|
|
||||||
|
// The HandlerFunc type is an adapter to allow the use of
|
||||||
|
// ordinary functions as a Handler. If f is a function
|
||||||
|
// with the appropriate signature, HandlerFunc(f) is a
|
||||||
|
// Handler that calls f.
|
||||||
|
type HandlerFunc func(context.Context, *Task) error
|
||||||
|
|
||||||
|
// ProcessTask calls fn(ctx, task)
|
||||||
|
func (fn HandlerFunc) ProcessTask(ctx context.Context, task *Task) error {
|
||||||
|
return fn(ctx, task)
|
||||||
|
}
|
||||||
|
|
||||||
|
// ErrServerStopped indicates that the operation is now illegal because of the server being stopped.
|
||||||
|
var ErrServerStopped = errors.New("asynq: the server has been stopped")
|
||||||
|
|
||||||
|
// Run starts the background-task processing and blocks until
|
||||||
|
// an os signal to exit the program is received. Once it receives
|
||||||
|
// a signal, it gracefully shuts down all active workers and other
|
||||||
|
// goroutines to process the tasks.
|
||||||
|
//
|
||||||
|
// Run returns any error encountered during server startup time.
|
||||||
|
// If the server has already been stopped, ErrServerStopped is returned.
|
||||||
|
func (srv *Server) Run(handler Handler) error {
|
||||||
|
if err := srv.Start(handler); err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
srv.waitForSignals()
|
||||||
|
srv.Stop()
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// Start starts the worker server. Once the server has started,
|
||||||
|
// it pulls tasks off queues and starts a worker goroutine for each task.
|
||||||
|
// Tasks are processed concurrently by the workers up to the number of
|
||||||
|
// concurrency specified at the initialization time.
|
||||||
|
//
|
||||||
|
// Start returns any error encountered during server startup time.
|
||||||
|
// If the server has already been stopped, ErrServerStopped is returned.
|
||||||
|
func (srv *Server) Start(handler Handler) error {
|
||||||
|
if handler == nil {
|
||||||
|
return fmt.Errorf("asynq: server cannot run with nil handler")
|
||||||
|
}
|
||||||
|
switch srv.status.Get() {
|
||||||
|
case base.StatusRunning:
|
||||||
|
return fmt.Errorf("asynq: the server is already running")
|
||||||
|
case base.StatusStopped:
|
||||||
|
return ErrServerStopped
|
||||||
|
}
|
||||||
|
srv.status.Set(base.StatusRunning)
|
||||||
|
srv.processor.handler = handler
|
||||||
|
|
||||||
|
srv.logger.Info("Starting processing")
|
||||||
|
|
||||||
|
srv.heartbeater.start(&srv.wg)
|
||||||
|
srv.subscriber.start(&srv.wg)
|
||||||
|
srv.syncer.start(&srv.wg)
|
||||||
|
srv.scheduler.start(&srv.wg)
|
||||||
|
srv.processor.start(&srv.wg)
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// Stop stops the worker server.
|
||||||
|
// It gracefully closes all active workers. The server will wait for
|
||||||
|
// active workers to finish processing tasks for duration specified in Config.ShutdownTimeout.
|
||||||
|
// If worker didn't finish processing a task during the timeout, the task will be pushed back to Redis.
|
||||||
|
func (srv *Server) Stop() {
|
||||||
|
switch srv.status.Get() {
|
||||||
|
case base.StatusIdle, base.StatusStopped:
|
||||||
|
// server is not running, do nothing and return.
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
srv.logger.Info("Starting graceful shutdown")
|
||||||
|
// Note: The order of termination is important.
|
||||||
|
// Sender goroutines should be terminated before the receiver goroutines.
|
||||||
|
// processor -> syncer (via syncCh)
|
||||||
|
// processor -> heartbeater (via starting, finished channels)
|
||||||
|
srv.scheduler.terminate()
|
||||||
|
srv.processor.terminate()
|
||||||
|
srv.syncer.terminate()
|
||||||
|
srv.subscriber.terminate()
|
||||||
|
srv.heartbeater.terminate()
|
||||||
|
|
||||||
|
srv.wg.Wait()
|
||||||
|
|
||||||
|
srv.broker.Close()
|
||||||
|
srv.status.Set(base.StatusStopped)
|
||||||
|
|
||||||
|
srv.logger.Info("Exiting")
|
||||||
|
}
|
||||||
|
|
||||||
|
// Quiet signals the server to stop pulling new tasks off queues.
|
||||||
|
// Quiet should be used before stopping the server.
|
||||||
|
func (srv *Server) Quiet() {
|
||||||
|
srv.logger.Info("Stopping processor")
|
||||||
|
srv.processor.stop()
|
||||||
|
srv.status.Set(base.StatusQuiet)
|
||||||
|
srv.logger.Info("Processor stopped")
|
||||||
|
}
|
240
server_test.go
Normal file
@@ -0,0 +1,240 @@
|
|||||||
|
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
||||||
|
// Use of this source code is governed by a MIT license
|
||||||
|
// that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package asynq
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"fmt"
|
||||||
|
"syscall"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/hibiken/asynq/internal/rdb"
|
||||||
|
"github.com/hibiken/asynq/internal/testbroker"
|
||||||
|
"go.uber.org/goleak"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestServer(t *testing.T) {
|
||||||
|
// https://github.com/go-redis/redis/issues/1029
|
||||||
|
ignoreOpt := goleak.IgnoreTopFunction("github.com/go-redis/redis/v7/internal/pool.(*ConnPool).reaper")
|
||||||
|
defer goleak.VerifyNoLeaks(t, ignoreOpt)
|
||||||
|
|
||||||
|
r := &RedisClientOpt{
|
||||||
|
Addr: "localhost:6379",
|
||||||
|
DB: 15,
|
||||||
|
}
|
||||||
|
c := NewClient(r)
|
||||||
|
srv := NewServer(r, Config{
|
||||||
|
Concurrency: 10,
|
||||||
|
LogLevel: testLogLevel,
|
||||||
|
})
|
||||||
|
|
||||||
|
// no-op handler
|
||||||
|
h := func(ctx context.Context, task *Task) error {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
err := srv.Start(HandlerFunc(h))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
err = c.Enqueue(NewTask("send_email", map[string]interface{}{"recipient_id": 123}))
|
||||||
|
if err != nil {
|
||||||
|
t.Errorf("could not enqueue a task: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
err = c.EnqueueAt(time.Now().Add(time.Hour), NewTask("send_email", map[string]interface{}{"recipient_id": 456}))
|
||||||
|
if err != nil {
|
||||||
|
t.Errorf("could not enqueue a task: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
srv.Stop()
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServerRun(t *testing.T) {
|
||||||
|
// https://github.com/go-redis/redis/issues/1029
|
||||||
|
ignoreOpt := goleak.IgnoreTopFunction("github.com/go-redis/redis/v7/internal/pool.(*ConnPool).reaper")
|
||||||
|
defer goleak.VerifyNoLeaks(t, ignoreOpt)
|
||||||
|
|
||||||
|
srv := NewServer(RedisClientOpt{Addr: ":6379"}, Config{LogLevel: testLogLevel})
|
||||||
|
|
||||||
|
done := make(chan struct{})
|
||||||
|
// Make sure server exits when receiving TERM signal.
|
||||||
|
go func() {
|
||||||
|
time.Sleep(2 * time.Second)
|
||||||
|
syscall.Kill(syscall.Getpid(), syscall.SIGTERM)
|
||||||
|
done <- struct{}{}
|
||||||
|
}()
|
||||||
|
|
||||||
|
go func() {
|
||||||
|
select {
|
||||||
|
case <-time.After(10 * time.Second):
|
||||||
|
t.Fatal("server did not stop after receiving TERM signal")
|
||||||
|
case <-done:
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
|
mux := NewServeMux()
|
||||||
|
if err := srv.Run(mux); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServerErrServerStopped(t *testing.T) {
|
||||||
|
srv := NewServer(RedisClientOpt{Addr: ":6379"}, Config{LogLevel: testLogLevel})
|
||||||
|
handler := NewServeMux()
|
||||||
|
if err := srv.Start(handler); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
srv.Stop()
|
||||||
|
err := srv.Start(handler)
|
||||||
|
if err != ErrServerStopped {
|
||||||
|
t.Errorf("Restarting server: (*Server).Start(handler) = %v, want ErrServerStopped error", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServerErrNilHandler(t *testing.T) {
|
||||||
|
srv := NewServer(RedisClientOpt{Addr: ":6379"}, Config{LogLevel: testLogLevel})
|
||||||
|
err := srv.Start(nil)
|
||||||
|
if err == nil {
|
||||||
|
t.Error("Starting server with nil handler: (*Server).Start(nil) did not return error")
|
||||||
|
srv.Stop()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServerErrServerRunning(t *testing.T) {
|
||||||
|
srv := NewServer(RedisClientOpt{Addr: ":6379"}, Config{LogLevel: testLogLevel})
|
||||||
|
handler := NewServeMux()
|
||||||
|
if err := srv.Start(handler); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
err := srv.Start(handler)
|
||||||
|
if err == nil {
|
||||||
|
t.Error("Calling (*Server).Start(handler) on already running server did not return error")
|
||||||
|
}
|
||||||
|
srv.Stop()
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServerWithRedisDown(t *testing.T) {
|
||||||
|
// Make sure that server does not panic and exit if redis is down.
|
||||||
|
defer func() {
|
||||||
|
if r := recover(); r != nil {
|
||||||
|
t.Errorf("panic occurred: %v", r)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
r := rdb.NewRDB(setup(t))
|
||||||
|
testBroker := testbroker.NewTestBroker(r)
|
||||||
|
srv := NewServer(RedisClientOpt{Addr: ":6379"}, Config{LogLevel: testLogLevel})
|
||||||
|
srv.broker = testBroker
|
||||||
|
srv.scheduler.broker = testBroker
|
||||||
|
srv.heartbeater.broker = testBroker
|
||||||
|
srv.processor.broker = testBroker
|
||||||
|
srv.subscriber.broker = testBroker
|
||||||
|
testBroker.Sleep()
|
||||||
|
|
||||||
|
// no-op handler
|
||||||
|
h := func(ctx context.Context, task *Task) error {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
err := srv.Start(HandlerFunc(h))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
time.Sleep(3 * time.Second)
|
||||||
|
|
||||||
|
srv.Stop()
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestServerWithFlakyBroker(t *testing.T) {
|
||||||
|
// Make sure that server does not panic and exit if redis is down.
|
||||||
|
defer func() {
|
||||||
|
if r := recover(); r != nil {
|
||||||
|
t.Errorf("panic occurred: %v", r)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
r := rdb.NewRDB(setup(t))
|
||||||
|
testBroker := testbroker.NewTestBroker(r)
|
||||||
|
srv := NewServer(RedisClientOpt{Addr: redisAddr, DB: redisDB}, Config{LogLevel: testLogLevel})
|
||||||
|
srv.broker = testBroker
|
||||||
|
srv.scheduler.broker = testBroker
|
||||||
|
srv.heartbeater.broker = testBroker
|
||||||
|
srv.processor.broker = testBroker
|
||||||
|
srv.subscriber.broker = testBroker
|
||||||
|
|
||||||
|
c := NewClient(RedisClientOpt{Addr: redisAddr, DB: redisDB})
|
||||||
|
|
||||||
|
h := func(ctx context.Context, task *Task) error {
|
||||||
|
// force task retry.
|
||||||
|
if task.Type == "bad_task" {
|
||||||
|
return fmt.Errorf("could not process %q", task.Type)
|
||||||
|
}
|
||||||
|
time.Sleep(2 * time.Second)
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
err := srv.Start(HandlerFunc(h))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
for i := 0; i < 10; i++ {
|
||||||
|
err := c.Enqueue(NewTask("enqueued", nil), MaxRetry(i))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
err = c.Enqueue(NewTask("bad_task", nil))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
err = c.EnqueueIn(time.Duration(i)*time.Second, NewTask("scheduled", nil))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// simulate redis going down.
|
||||||
|
testBroker.Sleep()
|
||||||
|
|
||||||
|
time.Sleep(3 * time.Second)
|
||||||
|
|
||||||
|
// simulate redis comes back online.
|
||||||
|
testBroker.Wakeup()
|
||||||
|
|
||||||
|
time.Sleep(3 * time.Second)
|
||||||
|
|
||||||
|
srv.Stop()
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestLogLevel(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
flagVal string
|
||||||
|
want LogLevel
|
||||||
|
wantStr string
|
||||||
|
}{
|
||||||
|
{"debug", DebugLevel, "debug"},
|
||||||
|
{"Info", InfoLevel, "info"},
|
||||||
|
{"WARN", WarnLevel, "warn"},
|
||||||
|
{"warning", WarnLevel, "warn"},
|
||||||
|
{"Error", ErrorLevel, "error"},
|
||||||
|
{"fatal", FatalLevel, "fatal"},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tc := range tests {
|
||||||
|
level := new(LogLevel)
|
||||||
|
if err := level.Set(tc.flagVal); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if *level != tc.want {
|
||||||
|
t.Errorf("Set(%q): got %v, want %v", tc.flagVal, level, &tc.want)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if got := level.String(); got != tc.wantStr {
|
||||||
|
t.Errorf("String() returned %q, want %q", got, tc.wantStr)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
30
signals_unix.go
Normal file
@@ -0,0 +1,30 @@
|
|||||||
|
// +build linux bsd darwin
|
||||||
|
|
||||||
|
package asynq
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"os/signal"
|
||||||
|
|
||||||
|
"golang.org/x/sys/unix"
|
||||||
|
)
|
||||||
|
|
||||||
|
// waitForSignals waits for signals and handles them.
|
||||||
|
// It handles SIGTERM, SIGINT, and SIGTSTP.
|
||||||
|
// SIGTERM and SIGINT will signal the process to exit.
|
||||||
|
// SIGTSTP will signal the process to stop processing new tasks.
|
||||||
|
func (srv *Server) waitForSignals() {
|
||||||
|
srv.logger.Info("Send signal TSTP to stop processing new tasks")
|
||||||
|
srv.logger.Info("Send signal TERM or INT to terminate the process")
|
||||||
|
|
||||||
|
sigs := make(chan os.Signal, 1)
|
||||||
|
signal.Notify(sigs, unix.SIGTERM, unix.SIGINT, unix.SIGTSTP)
|
||||||
|
for {
|
||||||
|
sig := <-sigs
|
||||||
|
if sig == unix.SIGTSTP {
|
||||||
|
srv.Quiet()
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
22
signals_windows.go
Normal file
@@ -0,0 +1,22 @@
|
|||||||
|
// +build windows
|
||||||
|
|
||||||
|
package asynq
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"os/signal"
|
||||||
|
|
||||||
|
"golang.org/x/sys/windows"
|
||||||
|
)
|
||||||
|
|
||||||
|
// waitForSignals waits for signals and handles them.
|
||||||
|
// It handles SIGTERM and SIGINT.
|
||||||
|
// SIGTERM and SIGINT will signal the process to exit.
|
||||||
|
//
|
||||||
|
// Note: Currently SIGTSTP is not supported for windows build.
|
||||||
|
func (srv *Server) waitForSignals() {
|
||||||
|
srv.logger.Info("Send signal TERM or INT to terminate the process")
|
||||||
|
sigs := make(chan os.Signal, 1)
|
||||||
|
signal.Notify(sigs, windows.SIGTERM, windows.SIGINT)
|
||||||
|
<-sigs
|
||||||
|
}
|
@@ -6,52 +6,78 @@ package asynq
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"sync"
|
"sync"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/go-redis/redis/v7"
|
||||||
"github.com/hibiken/asynq/internal/base"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
"github.com/hibiken/asynq/internal/rdb"
|
"github.com/hibiken/asynq/internal/log"
|
||||||
)
|
)
|
||||||
|
|
||||||
type subscriber struct {
|
type subscriber struct {
|
||||||
logger Logger
|
logger *log.Logger
|
||||||
rdb *rdb.RDB
|
broker base.Broker
|
||||||
|
|
||||||
// channel to communicate back to the long running "subscriber" goroutine.
|
// channel to communicate back to the long running "subscriber" goroutine.
|
||||||
done chan struct{}
|
done chan struct{}
|
||||||
|
|
||||||
// cancelations hold cancel functions for all in-progress tasks.
|
// cancelations hold cancel functions for all in-progress tasks.
|
||||||
cancelations *base.Cancelations
|
cancelations *base.Cancelations
|
||||||
|
|
||||||
|
// time to wait before retrying to connect to redis.
|
||||||
|
retryTimeout time.Duration
|
||||||
}
|
}
|
||||||
|
|
||||||
func newSubscriber(l Logger, rdb *rdb.RDB, cancelations *base.Cancelations) *subscriber {
|
type subscriberParams struct {
|
||||||
|
logger *log.Logger
|
||||||
|
broker base.Broker
|
||||||
|
cancelations *base.Cancelations
|
||||||
|
}
|
||||||
|
|
||||||
|
func newSubscriber(params subscriberParams) *subscriber {
|
||||||
return &subscriber{
|
return &subscriber{
|
||||||
logger: l,
|
logger: params.logger,
|
||||||
rdb: rdb,
|
broker: params.broker,
|
||||||
done: make(chan struct{}),
|
done: make(chan struct{}),
|
||||||
cancelations: cancelations,
|
cancelations: params.cancelations,
|
||||||
|
retryTimeout: 5 * time.Second,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *subscriber) terminate() {
|
func (s *subscriber) terminate() {
|
||||||
s.logger.Info("Subscriber shutting down...")
|
s.logger.Debug("Subscriber shutting down...")
|
||||||
// Signal the subscriber goroutine to stop.
|
// Signal the subscriber goroutine to stop.
|
||||||
s.done <- struct{}{}
|
s.done <- struct{}{}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *subscriber) start(wg *sync.WaitGroup) {
|
func (s *subscriber) start(wg *sync.WaitGroup) {
|
||||||
pubsub, err := s.rdb.CancelationPubSub()
|
|
||||||
cancelCh := pubsub.Channel()
|
|
||||||
if err != nil {
|
|
||||||
s.logger.Error("cannot subscribe to cancelation channel: %v", err)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
wg.Add(1)
|
wg.Add(1)
|
||||||
go func() {
|
go func() {
|
||||||
defer wg.Done()
|
defer wg.Done()
|
||||||
|
var (
|
||||||
|
pubsub *redis.PubSub
|
||||||
|
err error
|
||||||
|
)
|
||||||
|
// Try until successfully connect to Redis.
|
||||||
|
for {
|
||||||
|
pubsub, err = s.broker.CancelationPubSub()
|
||||||
|
if err != nil {
|
||||||
|
s.logger.Errorf("cannot subscribe to cancelation channel: %v", err)
|
||||||
|
select {
|
||||||
|
case <-time.After(s.retryTimeout):
|
||||||
|
continue
|
||||||
|
case <-s.done:
|
||||||
|
s.logger.Debug("Subscriber done")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
break
|
||||||
|
}
|
||||||
|
cancelCh := pubsub.Channel()
|
||||||
for {
|
for {
|
||||||
select {
|
select {
|
||||||
case <-s.done:
|
case <-s.done:
|
||||||
pubsub.Close()
|
pubsub.Close()
|
||||||
s.logger.Info("Subscriber done")
|
s.logger.Debug("Subscriber done")
|
||||||
return
|
return
|
||||||
case msg := <-cancelCh:
|
case msg := <-cancelCh:
|
||||||
cancel, ok := s.cancelations.Get(msg.Payload)
|
cancel, ok := s.cancelations.Get(msg.Payload)
|
||||||
|
@@ -11,6 +11,7 @@ import (
|
|||||||
|
|
||||||
"github.com/hibiken/asynq/internal/base"
|
"github.com/hibiken/asynq/internal/base"
|
||||||
"github.com/hibiken/asynq/internal/rdb"
|
"github.com/hibiken/asynq/internal/rdb"
|
||||||
|
"github.com/hibiken/asynq/internal/testbroker"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestSubscriber(t *testing.T) {
|
func TestSubscriber(t *testing.T) {
|
||||||
@@ -37,16 +38,23 @@ func TestSubscriber(t *testing.T) {
|
|||||||
cancelations := base.NewCancelations()
|
cancelations := base.NewCancelations()
|
||||||
cancelations.Add(tc.registeredID, fakeCancelFunc)
|
cancelations.Add(tc.registeredID, fakeCancelFunc)
|
||||||
|
|
||||||
subscriber := newSubscriber(testLogger, rdbClient, cancelations)
|
subscriber := newSubscriber(subscriberParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: rdbClient,
|
||||||
|
cancelations: cancelations,
|
||||||
|
})
|
||||||
var wg sync.WaitGroup
|
var wg sync.WaitGroup
|
||||||
subscriber.start(&wg)
|
subscriber.start(&wg)
|
||||||
|
defer subscriber.terminate()
|
||||||
|
|
||||||
|
// wait for subscriber to establish connection to pubsub channel
|
||||||
|
time.Sleep(time.Second)
|
||||||
|
|
||||||
if err := rdbClient.PublishCancelation(tc.publishID); err != nil {
|
if err := rdbClient.PublishCancelation(tc.publishID); err != nil {
|
||||||
subscriber.terminate()
|
|
||||||
t.Fatalf("could not publish cancelation message: %v", err)
|
t.Fatalf("could not publish cancelation message: %v", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// allow for redis to publish message
|
// wait for redis to publish message
|
||||||
time.Sleep(time.Second)
|
time.Sleep(time.Second)
|
||||||
|
|
||||||
mu.Lock()
|
mu.Lock()
|
||||||
@@ -58,7 +66,57 @@ func TestSubscriber(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
mu.Unlock()
|
mu.Unlock()
|
||||||
|
|
||||||
subscriber.terminate()
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestSubscriberWithRedisDown(t *testing.T) {
|
||||||
|
defer func() {
|
||||||
|
if r := recover(); r != nil {
|
||||||
|
t.Errorf("panic occurred: %v", r)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
r := rdb.NewRDB(setup(t))
|
||||||
|
testBroker := testbroker.NewTestBroker(r)
|
||||||
|
|
||||||
|
cancelations := base.NewCancelations()
|
||||||
|
subscriber := newSubscriber(subscriberParams{
|
||||||
|
logger: testLogger,
|
||||||
|
broker: testBroker,
|
||||||
|
cancelations: cancelations,
|
||||||
|
})
|
||||||
|
subscriber.retryTimeout = 1 * time.Second // set shorter retry timeout for testing purpose.
|
||||||
|
|
||||||
|
testBroker.Sleep() // simulate a situation where subscriber cannot connect to redis.
|
||||||
|
var wg sync.WaitGroup
|
||||||
|
subscriber.start(&wg)
|
||||||
|
defer subscriber.terminate()
|
||||||
|
|
||||||
|
time.Sleep(2 * time.Second) // subscriber should wait and retry connecting to redis.
|
||||||
|
|
||||||
|
testBroker.Wakeup() // simulate a situation where redis server is back online.
|
||||||
|
|
||||||
|
time.Sleep(2 * time.Second) // allow subscriber to establish pubsub channel.
|
||||||
|
|
||||||
|
const id = "test"
|
||||||
|
var (
|
||||||
|
mu sync.Mutex
|
||||||
|
called bool
|
||||||
|
)
|
||||||
|
cancelations.Add(id, func() {
|
||||||
|
mu.Lock()
|
||||||
|
defer mu.Unlock()
|
||||||
|
called = true
|
||||||
|
})
|
||||||
|
|
||||||
|
if err := r.PublishCancelation(id); err != nil {
|
||||||
|
t.Fatalf("could not publish cancelation message: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
time.Sleep(time.Second) // wait for redis to publish message.
|
||||||
|
|
||||||
|
mu.Lock()
|
||||||
|
if !called {
|
||||||
|
t.Errorf("cancel function was not called")
|
||||||
|
}
|
||||||
|
mu.Unlock()
|
||||||
|
}
|
||||||
|
22
syncer.go
@@ -7,12 +7,14 @@ package asynq
|
|||||||
import (
|
import (
|
||||||
"sync"
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
|
"github.com/hibiken/asynq/internal/log"
|
||||||
)
|
)
|
||||||
|
|
||||||
// syncer is responsible for queuing up failed requests to redis and retry
|
// syncer is responsible for queuing up failed requests to redis and retry
|
||||||
// those requests to sync state between the background process and redis.
|
// those requests to sync state between the background process and redis.
|
||||||
type syncer struct {
|
type syncer struct {
|
||||||
logger Logger
|
logger *log.Logger
|
||||||
|
|
||||||
requestsCh <-chan *syncRequest
|
requestsCh <-chan *syncRequest
|
||||||
|
|
||||||
@@ -28,17 +30,23 @@ type syncRequest struct {
|
|||||||
errMsg string // error message
|
errMsg string // error message
|
||||||
}
|
}
|
||||||
|
|
||||||
func newSyncer(l Logger, requestsCh <-chan *syncRequest, interval time.Duration) *syncer {
|
type syncerParams struct {
|
||||||
|
logger *log.Logger
|
||||||
|
requestsCh <-chan *syncRequest
|
||||||
|
interval time.Duration
|
||||||
|
}
|
||||||
|
|
||||||
|
func newSyncer(params syncerParams) *syncer {
|
||||||
return &syncer{
|
return &syncer{
|
||||||
logger: l,
|
logger: params.logger,
|
||||||
requestsCh: requestsCh,
|
requestsCh: params.requestsCh,
|
||||||
done: make(chan struct{}),
|
done: make(chan struct{}),
|
||||||
interval: interval,
|
interval: params.interval,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *syncer) terminate() {
|
func (s *syncer) terminate() {
|
||||||
s.logger.Info("Syncer shutting down...")
|
s.logger.Debug("Syncer shutting down...")
|
||||||
// Signal the syncer goroutine to stop.
|
// Signal the syncer goroutine to stop.
|
||||||
s.done <- struct{}{}
|
s.done <- struct{}{}
|
||||||
}
|
}
|
||||||
@@ -57,7 +65,7 @@ func (s *syncer) start(wg *sync.WaitGroup) {
|
|||||||
s.logger.Error(req.errMsg)
|
s.logger.Error(req.errMsg)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
s.logger.Info("Syncer done")
|
s.logger.Debug("Syncer done")
|
||||||
return
|
return
|
||||||
case req := <-s.requestsCh:
|
case req := <-s.requestsCh:
|
||||||
requests = append(requests, req)
|
requests = append(requests, req)
|
||||||
|
@@ -27,7 +27,11 @@ func TestSyncer(t *testing.T) {
|
|||||||
|
|
||||||
const interval = time.Second
|
const interval = time.Second
|
||||||
syncRequestCh := make(chan *syncRequest)
|
syncRequestCh := make(chan *syncRequest)
|
||||||
syncer := newSyncer(testLogger, syncRequestCh, interval)
|
syncer := newSyncer(syncerParams{
|
||||||
|
logger: testLogger,
|
||||||
|
requestsCh: syncRequestCh,
|
||||||
|
interval: interval,
|
||||||
|
})
|
||||||
var wg sync.WaitGroup
|
var wg sync.WaitGroup
|
||||||
syncer.start(&wg)
|
syncer.start(&wg)
|
||||||
defer syncer.terminate()
|
defer syncer.terminate()
|
||||||
@@ -52,7 +56,11 @@ func TestSyncer(t *testing.T) {
|
|||||||
func TestSyncerRetry(t *testing.T) {
|
func TestSyncerRetry(t *testing.T) {
|
||||||
const interval = time.Second
|
const interval = time.Second
|
||||||
syncRequestCh := make(chan *syncRequest)
|
syncRequestCh := make(chan *syncRequest)
|
||||||
syncer := newSyncer(testLogger, syncRequestCh, interval)
|
syncer := newSyncer(syncerParams{
|
||||||
|
logger: testLogger,
|
||||||
|
requestsCh: syncRequestCh,
|
||||||
|
interval: interval,
|
||||||
|
})
|
||||||
|
|
||||||
var wg sync.WaitGroup
|
var wg sync.WaitGroup
|
||||||
syncer.start(&wg)
|
syncer.start(&wg)
|
||||||
|
@@ -1,6 +1,6 @@
|
|||||||
# Asynqmon
|
# Asynq CLI
|
||||||
|
|
||||||
Asynqmon is a command line tool to monitor the tasks managed by `asynq` package.
|
Asynq CLI is a command line tool to monitor the tasks managed by `asynq` package.
|
||||||
|
|
||||||
## Table of Contents
|
## Table of Contents
|
||||||
|
|
||||||
@@ -8,31 +8,32 @@ Asynqmon is a command line tool to monitor the tasks managed by `asynq` package.
|
|||||||
- [Quick Start](#quick-start)
|
- [Quick Start](#quick-start)
|
||||||
- [Stats](#stats)
|
- [Stats](#stats)
|
||||||
- [History](#history)
|
- [History](#history)
|
||||||
- [Process Status](#process-status)
|
- [Servers](#servers)
|
||||||
- [List](#list)
|
- [List](#list)
|
||||||
- [Enqueue](#enqueue)
|
- [Enqueue](#enqueue)
|
||||||
- [Delete](#delete)
|
- [Delete](#delete)
|
||||||
- [Kill](#kill)
|
- [Kill](#kill)
|
||||||
- [Cancel](#cancel)
|
- [Cancel](#cancel)
|
||||||
|
- [Pause](#pause)
|
||||||
- [Config File](#config-file)
|
- [Config File](#config-file)
|
||||||
|
|
||||||
## Installation
|
## Installation
|
||||||
|
|
||||||
In order to use the tool, compile it using the following command:
|
In order to use the tool, compile it using the following command:
|
||||||
|
|
||||||
go get github.com/hibiken/asynq/tools/asynqmon
|
go get github.com/hibiken/asynq/tools/asynq
|
||||||
|
|
||||||
This will create the asynqmon executable under your `$GOPATH/bin` directory.
|
This will create the asynq executable under your `$GOPATH/bin` directory.
|
||||||
|
|
||||||
## Quickstart
|
## Quickstart
|
||||||
|
|
||||||
The tool has a few commands to inspect the state of tasks and queues.
|
The tool has a few commands to inspect the state of tasks and queues.
|
||||||
|
|
||||||
Run `asynqmon help` to see all the available commands.
|
Run `asynq help` to see all the available commands.
|
||||||
|
|
||||||
Asynqmon needs to connect to a redis-server to inspect the state of queues and tasks. Use flags to specify the options to connect to the redis-server used by your application.
|
Asynq CLI needs to connect to a redis-server to inspect the state of queues and tasks. Use flags to specify the options to connect to the redis-server used by your application.
|
||||||
|
|
||||||
By default, Asynqmon will try to connect to a redis server running at `localhost:6379`.
|
By default, CLI will try to connect to a redis server running at `localhost:6379`.
|
||||||
|
|
||||||
### Stats
|
### Stats
|
||||||
|
|
||||||
@@ -40,11 +41,11 @@ Stats command gives the overview of the current state of tasks and queues. You c
|
|||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
watch -n 3 asynqmon stats
|
watch -n 3 asynq stats
|
||||||
|
|
||||||
This will run `asynqmon stats` command every 3 seconds.
|
This will run `asynq stats` command every 3 seconds.
|
||||||
|
|
||||||

|

|
||||||
|
|
||||||
### History
|
### History
|
||||||
|
|
||||||
@@ -54,19 +55,17 @@ By default, it shows the stats from the last 10 days. Use `--days` to specify th
|
|||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon history --days=30
|
asynq history --days=30
|
||||||
|
|
||||||

|

|
||||||
|
|
||||||
### Process Status
|
### Servers
|
||||||
|
|
||||||
PS (ProcessStatus) command shows the list of running worker processes.
|
Servers command shows the list of running worker servers pulling tasks from the given redis instance.
|
||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon ps
|
asynq servers
|
||||||
|
|
||||||

|
|
||||||
|
|
||||||
### List
|
### List
|
||||||
|
|
||||||
@@ -74,11 +73,11 @@ List command shows all tasks in the specified state in a table format
|
|||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon ls retry
|
asynq ls retry
|
||||||
asynqmon ls scheduled
|
asynq ls scheduled
|
||||||
asynqmon ls dead
|
asynq ls dead
|
||||||
asynqmon ls enqueued:default
|
asynq ls enqueued:default
|
||||||
asynqmon ls inprogress
|
asynq ls inprogress
|
||||||
|
|
||||||
### Enqueue
|
### Enqueue
|
||||||
|
|
||||||
@@ -88,13 +87,13 @@ Command `enq` takes a task ID and moves the task to **Enqueued** state. You can
|
|||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon enq d:1575732274:bnogo8gt6toe23vhef0g
|
asynq enq d:1575732274:bnogo8gt6toe23vhef0g
|
||||||
|
|
||||||
Command `enqall` moves all tasks to **Enqueued** state from the specified state.
|
Command `enqall` moves all tasks to **Enqueued** state from the specified state.
|
||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon enqall retry
|
asynq enqall retry
|
||||||
|
|
||||||
Running the above command will move all **Retry** tasks to **Enqueued** state.
|
Running the above command will move all **Retry** tasks to **Enqueued** state.
|
||||||
|
|
||||||
@@ -106,13 +105,13 @@ Command `del` takes a task ID and deletes the task. You can obtain the task ID b
|
|||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon del r:1575732274:bnogo8gt6toe23vhef0g
|
asynq del r:1575732274:bnogo8gt6toe23vhef0g
|
||||||
|
|
||||||
Command `delall` deletes all tasks which are in the specified state.
|
Command `delall` deletes all tasks which are in the specified state.
|
||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon delall retry
|
asynq delall retry
|
||||||
|
|
||||||
Running the above command will delete all **Retry** tasks.
|
Running the above command will delete all **Retry** tasks.
|
||||||
|
|
||||||
@@ -124,13 +123,13 @@ Command `kill` takes a task ID and kills the task. You can obtain the task ID by
|
|||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon kill r:1575732274:bnogo8gt6toe23vhef0g
|
asynq kill r:1575732274:bnogo8gt6toe23vhef0g
|
||||||
|
|
||||||
Command `killall` kills all tasks which are in the specified state.
|
Command `killall` kills all tasks which are in the specified state.
|
||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon killall retry
|
asynq killall retry
|
||||||
|
|
||||||
Running the above command will move all **Retry** tasks to **Dead** state.
|
Running the above command will move all **Retry** tasks to **Dead** state.
|
||||||
|
|
||||||
@@ -144,15 +143,26 @@ Handler implementation needs to be context aware in order to actually stop proce
|
|||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
asynqmon cancel bnogo8gt6toe23vhef0g
|
asynq cancel bnogo8gt6toe23vhef0g
|
||||||
|
|
||||||
|
### Pause
|
||||||
|
|
||||||
|
Command `pause` pauses the spcified queue. Tasks in paused queues are not processed by servers.
|
||||||
|
To resume processing from the queue, use `unpause` command.
|
||||||
|
To see which queues are currently paused, use `stats` command.
|
||||||
|
|
||||||
|
Example:
|
||||||
|
|
||||||
|
asynq pause email
|
||||||
|
asynq unpause email
|
||||||
|
|
||||||
## Config File
|
## Config File
|
||||||
|
|
||||||
You can use a config file to set default values for the flags.
|
You can use a config file to set default values for the flags.
|
||||||
This is useful, for example when you have to connect to a remote redis server.
|
This is useful, for example when you have to connect to a remote redis server.
|
||||||
|
|
||||||
By default, `asynqmon` will try to read config file located in
|
By default, `asynq` will try to read config file located in
|
||||||
`$HOME/.asynqmon.(yaml|json)`. You can specify the file location via `--config` flag.
|
`$HOME/.asynq.(yaml|json)`. You can specify the file location via `--config` flag.
|
||||||
|
|
||||||
Config file example:
|
Config file example:
|
||||||
|
|
@@ -18,17 +18,17 @@ import (
|
|||||||
var cancelCmd = &cobra.Command{
|
var cancelCmd = &cobra.Command{
|
||||||
Use: "cancel [task id]",
|
Use: "cancel [task id]",
|
||||||
Short: "Sends a cancelation signal to the goroutine processing the specified task",
|
Short: "Sends a cancelation signal to the goroutine processing the specified task",
|
||||||
Long: `Cancel (asynqmon cancel) will send a cancelation signal to the goroutine processing
|
Long: `Cancel (asynq cancel) will send a cancelation signal to the goroutine processing
|
||||||
the specified task.
|
the specified task.
|
||||||
|
|
||||||
The command takes one argument which specifies the task to cancel.
|
The command takes one argument which specifies the task to cancel.
|
||||||
The task should be in in-progress state.
|
The task should be in in-progress state.
|
||||||
Identifier for a task should be obtained by running "asynqmon ls" command.
|
Identifier for a task should be obtained by running "asynq ls" command.
|
||||||
|
|
||||||
Handler implementation needs to be context aware for cancelation signal to
|
Handler implementation needs to be context aware for cancelation signal to
|
||||||
actually cancel the processing.
|
actually cancel the processing.
|
||||||
|
|
||||||
Example: asynqmon cancel bnogo8gt6toe23vhef0g`,
|
Example: asynq cancel bnogo8gt6toe23vhef0g`,
|
||||||
Args: cobra.ExactArgs(1),
|
Args: cobra.ExactArgs(1),
|
||||||
Run: cancel,
|
Run: cancel,
|
||||||
}
|
}
|
@@ -18,13 +18,13 @@ import (
|
|||||||
var delCmd = &cobra.Command{
|
var delCmd = &cobra.Command{
|
||||||
Use: "del [task id]",
|
Use: "del [task id]",
|
||||||
Short: "Deletes a task given an identifier",
|
Short: "Deletes a task given an identifier",
|
||||||
Long: `Del (asynqmon del) will delete a task given an identifier.
|
Long: `Del (asynq del) will delete a task given an identifier.
|
||||||
|
|
||||||
The command takes one argument which specifies the task to delete.
|
The command takes one argument which specifies the task to delete.
|
||||||
The task should be in either scheduled, retry or dead state.
|
The task should be in either scheduled, retry or dead state.
|
||||||
Identifier for a task should be obtained by running "asynqmon ls" command.
|
Identifier for a task should be obtained by running "asynq ls" command.
|
||||||
|
|
||||||
Example: asynqmon enq d:1575732274:bnogo8gt6toe23vhef0g`,
|
Example: asynq enq d:1575732274:bnogo8gt6toe23vhef0g`,
|
||||||
Args: cobra.ExactArgs(1),
|
Args: cobra.ExactArgs(1),
|
||||||
Run: del,
|
Run: del,
|
||||||
}
|
}
|
@@ -20,11 +20,11 @@ var delallValidArgs = []string{"scheduled", "retry", "dead"}
|
|||||||
var delallCmd = &cobra.Command{
|
var delallCmd = &cobra.Command{
|
||||||
Use: "delall [state]",
|
Use: "delall [state]",
|
||||||
Short: "Deletes all tasks in the specified state",
|
Short: "Deletes all tasks in the specified state",
|
||||||
Long: `Delall (asynqmon delall) will delete all tasks in the specified state.
|
Long: `Delall (asynq delall) will delete all tasks in the specified state.
|
||||||
|
|
||||||
The argument should be one of "scheduled", "retry", or "dead".
|
The argument should be one of "scheduled", "retry", or "dead".
|
||||||
|
|
||||||
Example: asynqmon delall dead -> Deletes all dead tasks`,
|
Example: asynq delall dead -> Deletes all dead tasks`,
|
||||||
ValidArgs: delallValidArgs,
|
ValidArgs: delallValidArgs,
|
||||||
Args: cobra.ExactValidArgs(1),
|
Args: cobra.ExactValidArgs(1),
|
||||||
Run: delall,
|
Run: delall,
|
||||||
@@ -60,7 +60,7 @@ func delall(cmd *cobra.Command, args []string) {
|
|||||||
case "dead":
|
case "dead":
|
||||||
err = r.DeleteAllDeadTasks()
|
err = r.DeleteAllDeadTasks()
|
||||||
default:
|
default:
|
||||||
fmt.Printf("error: `asynqmon delall [state]` only accepts %v as the argument.\n", delallValidArgs)
|
fmt.Printf("error: `asynq delall [state]` only accepts %v as the argument.\n", delallValidArgs)
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
if err != nil {
|
if err != nil {
|
@@ -18,16 +18,16 @@ import (
|
|||||||
var enqCmd = &cobra.Command{
|
var enqCmd = &cobra.Command{
|
||||||
Use: "enq [task id]",
|
Use: "enq [task id]",
|
||||||
Short: "Enqueues a task given an identifier",
|
Short: "Enqueues a task given an identifier",
|
||||||
Long: `Enq (asynqmon enq) will enqueue a task given an identifier.
|
Long: `Enq (asynq enq) will enqueue a task given an identifier.
|
||||||
|
|
||||||
The command takes one argument which specifies the task to enqueue.
|
The command takes one argument which specifies the task to enqueue.
|
||||||
The task should be in either scheduled, retry or dead state.
|
The task should be in either scheduled, retry or dead state.
|
||||||
Identifier for a task should be obtained by running "asynqmon ls" command.
|
Identifier for a task should be obtained by running "asynq ls" command.
|
||||||
|
|
||||||
The task enqueued by this command will be processed as soon as the task
|
The task enqueued by this command will be processed as soon as the task
|
||||||
gets dequeued by a processor.
|
gets dequeued by a processor.
|
||||||
|
|
||||||
Example: asynqmon enq d:1575732274:bnogo8gt6toe23vhef0g`,
|
Example: asynq enq d:1575732274:bnogo8gt6toe23vhef0g`,
|
||||||
Args: cobra.ExactArgs(1),
|
Args: cobra.ExactArgs(1),
|
||||||
Run: enq,
|
Run: enq,
|
||||||
}
|
}
|
@@ -20,14 +20,14 @@ var enqallValidArgs = []string{"scheduled", "retry", "dead"}
|
|||||||
var enqallCmd = &cobra.Command{
|
var enqallCmd = &cobra.Command{
|
||||||
Use: "enqall [state]",
|
Use: "enqall [state]",
|
||||||
Short: "Enqueues all tasks in the specified state",
|
Short: "Enqueues all tasks in the specified state",
|
||||||
Long: `Enqall (asynqmon enqall) will enqueue all tasks in the specified state.
|
Long: `Enqall (asynq enqall) will enqueue all tasks in the specified state.
|
||||||
|
|
||||||
The argument should be one of "scheduled", "retry", or "dead".
|
The argument should be one of "scheduled", "retry", or "dead".
|
||||||
|
|
||||||
The tasks enqueued by this command will be processed as soon as it
|
The tasks enqueued by this command will be processed as soon as it
|
||||||
gets dequeued by a processor.
|
gets dequeued by a processor.
|
||||||
|
|
||||||
Example: asynqmon enqall dead -> Enqueues all dead tasks`,
|
Example: asynq enqall dead -> Enqueues all dead tasks`,
|
||||||
ValidArgs: enqallValidArgs,
|
ValidArgs: enqallValidArgs,
|
||||||
Args: cobra.ExactValidArgs(1),
|
Args: cobra.ExactValidArgs(1),
|
||||||
Run: enqall,
|
Run: enqall,
|
||||||
@@ -64,7 +64,7 @@ func enqall(cmd *cobra.Command, args []string) {
|
|||||||
case "dead":
|
case "dead":
|
||||||
n, err = r.EnqueueAllDeadTasks()
|
n, err = r.EnqueueAllDeadTasks()
|
||||||
default:
|
default:
|
||||||
fmt.Printf("error: `asynqmon enqall [state]` only accepts %v as the argument.\n", enqallValidArgs)
|
fmt.Printf("error: `asynq enqall [state]` only accepts %v as the argument.\n", enqallValidArgs)
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
if err != nil {
|
if err != nil {
|
@@ -22,12 +22,12 @@ var days int
|
|||||||
var historyCmd = &cobra.Command{
|
var historyCmd = &cobra.Command{
|
||||||
Use: "history",
|
Use: "history",
|
||||||
Short: "Shows historical aggregate data",
|
Short: "Shows historical aggregate data",
|
||||||
Long: `History (asynqmon history) will show the number of processed and failed tasks
|
Long: `History (asynq history) will show the number of processed and failed tasks
|
||||||
from the last x days.
|
from the last x days.
|
||||||
|
|
||||||
By default, it will show the data from the last 10 days.
|
By default, it will show the data from the last 10 days.
|
||||||
|
|
||||||
Example: asynqmon history -x=30 -> Shows stats from the last 30 days`,
|
Example: asynq history -x=30 -> Shows stats from the last 30 days`,
|
||||||
Args: cobra.NoArgs,
|
Args: cobra.NoArgs,
|
||||||
Run: history,
|
Run: history,
|
||||||
}
|
}
|
@@ -18,13 +18,13 @@ import (
|
|||||||
var killCmd = &cobra.Command{
|
var killCmd = &cobra.Command{
|
||||||
Use: "kill [task id]",
|
Use: "kill [task id]",
|
||||||
Short: "Kills a task given an identifier",
|
Short: "Kills a task given an identifier",
|
||||||
Long: `Kill (asynqmon kill) will put a task in dead state given an identifier.
|
Long: `Kill (asynq kill) will put a task in dead state given an identifier.
|
||||||
|
|
||||||
The command takes one argument which specifies the task to kill.
|
The command takes one argument which specifies the task to kill.
|
||||||
The task should be in either scheduled or retry state.
|
The task should be in either scheduled or retry state.
|
||||||
Identifier for a task should be obtained by running "asynqmon ls" command.
|
Identifier for a task should be obtained by running "asynq ls" command.
|
||||||
|
|
||||||
Example: asynqmon kill r:1575732274:bnogo8gt6toe23vhef0g`,
|
Example: asynq kill r:1575732274:bnogo8gt6toe23vhef0g`,
|
||||||
Args: cobra.ExactArgs(1),
|
Args: cobra.ExactArgs(1),
|
||||||
Run: kill,
|
Run: kill,
|
||||||
}
|
}
|
@@ -20,11 +20,11 @@ var killallValidArgs = []string{"scheduled", "retry"}
|
|||||||
var killallCmd = &cobra.Command{
|
var killallCmd = &cobra.Command{
|
||||||
Use: "killall [state]",
|
Use: "killall [state]",
|
||||||
Short: "Kills all tasks in the specified state",
|
Short: "Kills all tasks in the specified state",
|
||||||
Long: `Killall (asynqmon killall) will update all tasks from the specified state to dead state.
|
Long: `Killall (asynq killall) will update all tasks from the specified state to dead state.
|
||||||
|
|
||||||
The argument should be either "scheduled" or "retry".
|
The argument should be either "scheduled" or "retry".
|
||||||
|
|
||||||
Example: asynqmon killall retry -> Update all retry tasks to dead tasks`,
|
Example: asynq killall retry -> Update all retry tasks to dead tasks`,
|
||||||
ValidArgs: killallValidArgs,
|
ValidArgs: killallValidArgs,
|
||||||
Args: cobra.ExactValidArgs(1),
|
Args: cobra.ExactValidArgs(1),
|
||||||
Run: killall,
|
Run: killall,
|
||||||
@@ -59,7 +59,7 @@ func killall(cmd *cobra.Command, args []string) {
|
|||||||
case "retry":
|
case "retry":
|
||||||
n, err = r.KillAllRetryTasks()
|
n, err = r.KillAllRetryTasks()
|
||||||
default:
|
default:
|
||||||
fmt.Printf("error: `asynqmon killall [state]` only accepts %v as the argument.\n", killallValidArgs)
|
fmt.Printf("error: `asynq killall [state]` only accepts %v as the argument.\n", killallValidArgs)
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
if err != nil {
|
if err != nil {
|
@@ -25,19 +25,19 @@ var lsValidArgs = []string{"enqueued", "inprogress", "scheduled", "retry", "dead
|
|||||||
var lsCmd = &cobra.Command{
|
var lsCmd = &cobra.Command{
|
||||||
Use: "ls [state]",
|
Use: "ls [state]",
|
||||||
Short: "Lists tasks in the specified state",
|
Short: "Lists tasks in the specified state",
|
||||||
Long: `Ls (asynqmon ls) will list all tasks in the specified state in a table format.
|
Long: `Ls (asynq ls) will list all tasks in the specified state in a table format.
|
||||||
|
|
||||||
The command takes one argument which specifies the state of tasks.
|
The command takes one argument which specifies the state of tasks.
|
||||||
The argument value should be one of "enqueued", "inprogress", "scheduled",
|
The argument value should be one of "enqueued", "inprogress", "scheduled",
|
||||||
"retry", or "dead".
|
"retry", or "dead".
|
||||||
|
|
||||||
Example:
|
Example:
|
||||||
asynqmon ls dead -> Lists all tasks in dead state
|
asynq ls dead -> Lists all tasks in dead state
|
||||||
|
|
||||||
Enqueued tasks requires a queue name after ":"
|
Enqueued tasks requires a queue name after ":"
|
||||||
Example:
|
Example:
|
||||||
asynqmon ls enqueued:default -> List tasks from default queue
|
asynq ls enqueued:default -> List tasks from default queue
|
||||||
asynqmon ls enqueued:critical -> List tasks from critical queue
|
asynq ls enqueued:critical -> List tasks from critical queue
|
||||||
`,
|
`,
|
||||||
Args: cobra.ExactValidArgs(1),
|
Args: cobra.ExactValidArgs(1),
|
||||||
Run: ls,
|
Run: ls,
|
||||||
@@ -72,7 +72,7 @@ func ls(cmd *cobra.Command, args []string) {
|
|||||||
switch parts[0] {
|
switch parts[0] {
|
||||||
case "enqueued":
|
case "enqueued":
|
||||||
if len(parts) != 2 {
|
if len(parts) != 2 {
|
||||||
fmt.Printf("error: Missing queue name\n`asynqmon ls enqueued:[queue name]`\n")
|
fmt.Printf("error: Missing queue name\n`asynq ls enqueued:[queue name]`\n")
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
listEnqueued(r, parts[1])
|
listEnqueued(r, parts[1])
|
||||||
@@ -85,7 +85,7 @@ func ls(cmd *cobra.Command, args []string) {
|
|||||||
case "dead":
|
case "dead":
|
||||||
listDead(r)
|
listDead(r)
|
||||||
default:
|
default:
|
||||||
fmt.Printf("error: `asynqmon ls [state]`\nonly accepts %v as the argument.\n", lsValidArgs)
|
fmt.Printf("error: `asynq ls [state]`\nonly accepts %v as the argument.\n", lsValidArgs)
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
}
|
}
|
47
tools/asynq/cmd/pause.go
Normal file
@@ -0,0 +1,47 @@
|
|||||||
|
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
||||||
|
// Use of this source code is governed by a MIT license
|
||||||
|
// that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package cmd
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
|
||||||
|
"github.com/go-redis/redis/v7"
|
||||||
|
"github.com/hibiken/asynq/internal/rdb"
|
||||||
|
"github.com/spf13/cobra"
|
||||||
|
"github.com/spf13/viper"
|
||||||
|
)
|
||||||
|
|
||||||
|
// pauseCmd represents the pause command
|
||||||
|
var pauseCmd = &cobra.Command{
|
||||||
|
Use: "pause [queue name]",
|
||||||
|
Short: "Pauses the specified queue",
|
||||||
|
Long: `Pause (asynq pause) will pause the specified queue.
|
||||||
|
Asynq servers will not process tasks from paused queues.
|
||||||
|
Use the "unpause" command to resume a paused queue.
|
||||||
|
|
||||||
|
Example: asynq pause default -> Pause the "default" queue`,
|
||||||
|
Args: cobra.ExactValidArgs(1),
|
||||||
|
Run: pause,
|
||||||
|
}
|
||||||
|
|
||||||
|
func init() {
|
||||||
|
rootCmd.AddCommand(pauseCmd)
|
||||||
|
}
|
||||||
|
|
||||||
|
func pause(cmd *cobra.Command, args []string) {
|
||||||
|
c := redis.NewClient(&redis.Options{
|
||||||
|
Addr: viper.GetString("uri"),
|
||||||
|
DB: viper.GetInt("db"),
|
||||||
|
Password: viper.GetString("password"),
|
||||||
|
})
|
||||||
|
r := rdb.NewRDB(c)
|
||||||
|
err := r.Pause(args[0])
|
||||||
|
if err != nil {
|
||||||
|
fmt.Printf("error: %v\n", err)
|
||||||
|
os.Exit(1)
|
||||||
|
}
|
||||||
|
fmt.Printf("Successfully paused queue %q\n", args[0])
|
||||||
|
}
|
@@ -18,11 +18,11 @@ import (
|
|||||||
var rmqCmd = &cobra.Command{
|
var rmqCmd = &cobra.Command{
|
||||||
Use: "rmq [queue name]",
|
Use: "rmq [queue name]",
|
||||||
Short: "Removes the specified queue",
|
Short: "Removes the specified queue",
|
||||||
Long: `Rmq (asynqmon rmq) will remove the specified queue.
|
Long: `Rmq (asynq rmq) will remove the specified queue.
|
||||||
By default, it will remove the queue only if it's empty.
|
By default, it will remove the queue only if it's empty.
|
||||||
Use --force option to override this behavior.
|
Use --force option to override this behavior.
|
||||||
|
|
||||||
Example: asynqmon rmq low -> Removes "low" queue`,
|
Example: asynq rmq low -> Removes "low" queue`,
|
||||||
Args: cobra.ExactValidArgs(1),
|
Args: cobra.ExactValidArgs(1),
|
||||||
Run: rmq,
|
Run: rmq,
|
||||||
}
|
}
|
||||||
@@ -44,7 +44,7 @@ func rmq(cmd *cobra.Command, args []string) {
|
|||||||
err := r.RemoveQueue(args[0], rmqForce)
|
err := r.RemoveQueue(args[0], rmqForce)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
if _, ok := err.(*rdb.ErrQueueNotEmpty); ok {
|
if _, ok := err.(*rdb.ErrQueueNotEmpty); ok {
|
||||||
fmt.Printf("error: %v\nIf you are sure you want to delete it, run 'asynqmon rmq --force %s'\n", err, args[0])
|
fmt.Printf("error: %v\nIf you are sure you want to delete it, run 'asynq rmq --force %s'\n", err, args[0])
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
fmt.Printf("error: %v", err)
|
fmt.Printf("error: %v", err)
|
@@ -26,9 +26,9 @@ var password string
|
|||||||
|
|
||||||
// rootCmd represents the base command when called without any subcommands
|
// rootCmd represents the base command when called without any subcommands
|
||||||
var rootCmd = &cobra.Command{
|
var rootCmd = &cobra.Command{
|
||||||
Use: "asynqmon",
|
Use: "asynq",
|
||||||
Short: "A monitoring tool for asynq queues",
|
Short: "A monitoring tool for asynq queues",
|
||||||
Long: `Asynqmon is a montoring CLI to inspect tasks and queues managed by asynq.`,
|
Long: `Asynq is a montoring CLI to inspect tasks and queues managed by asynq.`,
|
||||||
}
|
}
|
||||||
|
|
||||||
// Execute adds all child commands to the root command and sets flags appropriately.
|
// Execute adds all child commands to the root command and sets flags appropriately.
|
||||||
@@ -43,7 +43,7 @@ func Execute() {
|
|||||||
func init() {
|
func init() {
|
||||||
cobra.OnInitialize(initConfig)
|
cobra.OnInitialize(initConfig)
|
||||||
|
|
||||||
rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file to set flag defaut values (default is $HOME/.asynqmon.yaml)")
|
rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file to set flag defaut values (default is $HOME/.asynq.yaml)")
|
||||||
rootCmd.PersistentFlags().StringVarP(&uri, "uri", "u", "127.0.0.1:6379", "redis server URI")
|
rootCmd.PersistentFlags().StringVarP(&uri, "uri", "u", "127.0.0.1:6379", "redis server URI")
|
||||||
rootCmd.PersistentFlags().IntVarP(&db, "db", "n", 0, "redis database number (default is 0)")
|
rootCmd.PersistentFlags().IntVarP(&db, "db", "n", 0, "redis database number (default is 0)")
|
||||||
rootCmd.PersistentFlags().StringVarP(&password, "password", "p", "", "password to use when connecting to redis server")
|
rootCmd.PersistentFlags().StringVarP(&password, "password", "p", "", "password to use when connecting to redis server")
|
||||||
@@ -65,9 +65,9 @@ func initConfig() {
|
|||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Search config in home directory with name ".asynqmon" (without extension).
|
// Search config in home directory with name ".asynq" (without extension).
|
||||||
viper.AddConfigPath(home)
|
viper.AddConfigPath(home)
|
||||||
viper.SetConfigName(".asynqmon")
|
viper.SetConfigName(".asynq")
|
||||||
}
|
}
|
||||||
|
|
||||||
viper.AutomaticEnv() // read in environment variables that match
|
viper.AutomaticEnv() // read in environment variables that match
|
@@ -18,64 +18,64 @@ import (
|
|||||||
"github.com/spf13/viper"
|
"github.com/spf13/viper"
|
||||||
)
|
)
|
||||||
|
|
||||||
// psCmd represents the ps command
|
// serversCmd represents the servers command
|
||||||
var psCmd = &cobra.Command{
|
var serversCmd = &cobra.Command{
|
||||||
Use: "ps",
|
Use: "servers",
|
||||||
Short: "Shows all background worker processes",
|
Short: "Shows all running worker servers",
|
||||||
Long: `Ps (asynqmon ps) will show all background worker processes
|
Long: `Servers (asynq servers) will show all running worker servers
|
||||||
backed by the specified redis instance.
|
pulling tasks from the specified redis instance.
|
||||||
|
|
||||||
The command shows the following for each process:
|
The command shows the following for each server:
|
||||||
* Host and PID of the process
|
* Host and PID of the process in which the server is running
|
||||||
* Number of active workers out of worker pool
|
* Number of active workers out of worker pool
|
||||||
* Queue configuration
|
* Queue configuration
|
||||||
* State of the worker process ("running" | "stopped")
|
* State of the worker server ("running" | "quiet")
|
||||||
* Time the process was started
|
* Time the server was started
|
||||||
|
|
||||||
A "running" process is processing tasks in queues.
|
A "running" server is pulling tasks from queues and processing them.
|
||||||
A "stopped" process is no longer processing new tasks.`,
|
A "quiet" server is no longer pulling new tasks from queues`,
|
||||||
Args: cobra.NoArgs,
|
Args: cobra.NoArgs,
|
||||||
Run: ps,
|
Run: servers,
|
||||||
}
|
}
|
||||||
|
|
||||||
func init() {
|
func init() {
|
||||||
rootCmd.AddCommand(psCmd)
|
rootCmd.AddCommand(serversCmd)
|
||||||
}
|
}
|
||||||
|
|
||||||
func ps(cmd *cobra.Command, args []string) {
|
func servers(cmd *cobra.Command, args []string) {
|
||||||
r := rdb.NewRDB(redis.NewClient(&redis.Options{
|
r := rdb.NewRDB(redis.NewClient(&redis.Options{
|
||||||
Addr: viper.GetString("uri"),
|
Addr: viper.GetString("uri"),
|
||||||
DB: viper.GetInt("db"),
|
DB: viper.GetInt("db"),
|
||||||
Password: viper.GetString("password"),
|
Password: viper.GetString("password"),
|
||||||
}))
|
}))
|
||||||
|
|
||||||
processes, err := r.ListProcesses()
|
servers, err := r.ListServers()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Println(err)
|
fmt.Println(err)
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
if len(processes) == 0 {
|
if len(servers) == 0 {
|
||||||
fmt.Println("No processes")
|
fmt.Println("No running servers")
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
// sort by hostname and pid
|
// sort by hostname and pid
|
||||||
sort.Slice(processes, func(i, j int) bool {
|
sort.Slice(servers, func(i, j int) bool {
|
||||||
x, y := processes[i], processes[j]
|
x, y := servers[i], servers[j]
|
||||||
if x.Host != y.Host {
|
if x.Host != y.Host {
|
||||||
return x.Host < y.Host
|
return x.Host < y.Host
|
||||||
}
|
}
|
||||||
return x.PID < y.PID
|
return x.PID < y.PID
|
||||||
})
|
})
|
||||||
|
|
||||||
// print processes
|
// print server info
|
||||||
cols := []string{"Host", "PID", "State", "Active Workers", "Queues", "Started"}
|
cols := []string{"Host", "PID", "State", "Active Workers", "Queues", "Started"}
|
||||||
printRows := func(w io.Writer, tmpl string) {
|
printRows := func(w io.Writer, tmpl string) {
|
||||||
for _, ps := range processes {
|
for _, info := range servers {
|
||||||
fmt.Fprintf(w, tmpl,
|
fmt.Fprintf(w, tmpl,
|
||||||
ps.Host, ps.PID, ps.Status,
|
info.Host, info.PID, info.Status,
|
||||||
fmt.Sprintf("%d/%d", ps.ActiveWorkerCount, ps.Concurrency),
|
fmt.Sprintf("%d/%d", info.ActiveWorkerCount, info.Concurrency),
|
||||||
formatQueues(ps.Queues), timeAgo(ps.Started))
|
formatQueues(info.Queues), timeAgo(info.Started))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
printTable(cols, printRows)
|
printTable(cols, printRows)
|
@@ -7,7 +7,6 @@ package cmd
|
|||||||
import (
|
import (
|
||||||
"fmt"
|
"fmt"
|
||||||
"os"
|
"os"
|
||||||
"sort"
|
|
||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
"text/tabwriter"
|
"text/tabwriter"
|
||||||
@@ -33,7 +32,7 @@ Specifically, the command shows the following:
|
|||||||
To monitor the tasks continuously, it's recommended that you run this
|
To monitor the tasks continuously, it's recommended that you run this
|
||||||
command in conjunction with the watch command.
|
command in conjunction with the watch command.
|
||||||
|
|
||||||
Example: watch -n 3 asynqmon stats -> Shows current state of tasks every three seconds`,
|
Example: watch -n 3 asynq stats -> Shows current state of tasks every three seconds`,
|
||||||
Args: cobra.NoArgs,
|
Args: cobra.NoArgs,
|
||||||
Run: stats,
|
Run: stats,
|
||||||
}
|
}
|
||||||
@@ -96,24 +95,31 @@ func printStates(s *rdb.Stats) {
|
|||||||
tw.Flush()
|
tw.Flush()
|
||||||
}
|
}
|
||||||
|
|
||||||
func printQueues(queues map[string]int) {
|
func printQueues(queues []*rdb.Queue) {
|
||||||
var qnames, seps, counts []string
|
var headers, seps, counts []string
|
||||||
for q := range queues {
|
for _, q := range queues {
|
||||||
qnames = append(qnames, strings.Title(q))
|
title := queueTitle(q)
|
||||||
|
headers = append(headers, title)
|
||||||
|
seps = append(seps, strings.Repeat("-", len(title)))
|
||||||
|
counts = append(counts, strconv.Itoa(q.Size))
|
||||||
}
|
}
|
||||||
sort.Strings(qnames) // sort for stable order
|
format := strings.Repeat("%v\t", len(headers)) + "\n"
|
||||||
for _, q := range qnames {
|
|
||||||
seps = append(seps, strings.Repeat("-", len(q)))
|
|
||||||
counts = append(counts, strconv.Itoa(queues[strings.ToLower(q)]))
|
|
||||||
}
|
|
||||||
format := strings.Repeat("%v\t", len(qnames)) + "\n"
|
|
||||||
tw := new(tabwriter.Writer).Init(os.Stdout, 0, 8, 2, ' ', 0)
|
tw := new(tabwriter.Writer).Init(os.Stdout, 0, 8, 2, ' ', 0)
|
||||||
fmt.Fprintf(tw, format, toInterfaceSlice(qnames)...)
|
fmt.Fprintf(tw, format, toInterfaceSlice(headers)...)
|
||||||
fmt.Fprintf(tw, format, toInterfaceSlice(seps)...)
|
fmt.Fprintf(tw, format, toInterfaceSlice(seps)...)
|
||||||
fmt.Fprintf(tw, format, toInterfaceSlice(counts)...)
|
fmt.Fprintf(tw, format, toInterfaceSlice(counts)...)
|
||||||
tw.Flush()
|
tw.Flush()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func queueTitle(q *rdb.Queue) string {
|
||||||
|
var b strings.Builder
|
||||||
|
b.WriteString(strings.Title(q.Name))
|
||||||
|
if q.Paused {
|
||||||
|
b.WriteString(" (Paused)")
|
||||||
|
}
|
||||||
|
return b.String()
|
||||||
|
}
|
||||||
|
|
||||||
func printStats(s *rdb.Stats) {
|
func printStats(s *rdb.Stats) {
|
||||||
format := strings.Repeat("%v\t", 3) + "\n"
|
format := strings.Repeat("%v\t", 3) + "\n"
|
||||||
tw := new(tabwriter.Writer).Init(os.Stdout, 0, 8, 2, ' ', 0)
|
tw := new(tabwriter.Writer).Init(os.Stdout, 0, 8, 2, ' ', 0)
|
46
tools/asynq/cmd/unpause.go
Normal file
@@ -0,0 +1,46 @@
|
|||||||
|
// Copyright 2020 Kentaro Hibino. All rights reserved.
|
||||||
|
// Use of this source code is governed by a MIT license
|
||||||
|
// that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package cmd
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
|
||||||
|
"github.com/go-redis/redis/v7"
|
||||||
|
"github.com/hibiken/asynq/internal/rdb"
|
||||||
|
"github.com/spf13/cobra"
|
||||||
|
"github.com/spf13/viper"
|
||||||
|
)
|
||||||
|
|
||||||
|
// unpauseCmd represents the unpause command
|
||||||
|
var unpauseCmd = &cobra.Command{
|
||||||
|
Use: "unpause [queue name]",
|
||||||
|
Short: "Unpauses the specified queue",
|
||||||
|
Long: `Unpause (asynq unpause) will unpause the specified queue.
|
||||||
|
Asynq servers will process tasks from unpaused/resumed queues.
|
||||||
|
|
||||||
|
Example: asynq unpause default -> Resume the "default" queue`,
|
||||||
|
Args: cobra.ExactValidArgs(1),
|
||||||
|
Run: unpause,
|
||||||
|
}
|
||||||
|
|
||||||
|
func init() {
|
||||||
|
rootCmd.AddCommand(unpauseCmd)
|
||||||
|
}
|
||||||
|
|
||||||
|
func unpause(cmd *cobra.Command, args []string) {
|
||||||
|
c := redis.NewClient(&redis.Options{
|
||||||
|
Addr: viper.GetString("uri"),
|
||||||
|
DB: viper.GetInt("db"),
|
||||||
|
Password: viper.GetString("password"),
|
||||||
|
})
|
||||||
|
r := rdb.NewRDB(c)
|
||||||
|
err := r.Unpause(args[0])
|
||||||
|
if err != nil {
|
||||||
|
fmt.Printf("error: %v\n", err)
|
||||||
|
os.Exit(1)
|
||||||
|
}
|
||||||
|
fmt.Printf("Successfully resumed queue %q\n", args[0])
|
||||||
|
}
|
@@ -20,7 +20,7 @@ import (
|
|||||||
var workersCmd = &cobra.Command{
|
var workersCmd = &cobra.Command{
|
||||||
Use: "workers",
|
Use: "workers",
|
||||||
Short: "Shows all running workers information",
|
Short: "Shows all running workers information",
|
||||||
Long: `Workers (asynqmon workers) will show all running workers information.
|
Long: `Workers (asynq workers) will show all running workers information.
|
||||||
|
|
||||||
The command shows the following for each worker:
|
The command shows the following for each worker:
|
||||||
* Process in which the worker is running
|
* Process in which the worker is running
|
||||||
@@ -61,7 +61,7 @@ func workers(cmd *cobra.Command, args []string) {
|
|||||||
if x.Started != y.Started {
|
if x.Started != y.Started {
|
||||||
return x.Started.Before(y.Started)
|
return x.Started.Before(y.Started)
|
||||||
}
|
}
|
||||||
return x.ID.String() < y.ID.String()
|
return x.ID < y.ID
|
||||||
})
|
})
|
||||||
|
|
||||||
cols := []string{"Process", "ID", "Type", "Payload", "Queue", "Started"}
|
cols := []string{"Process", "ID", "Type", "Payload", "Queue", "Started"}
|
@@ -4,7 +4,7 @@
|
|||||||
|
|
||||||
package main
|
package main
|
||||||
|
|
||||||
import "github.com/hibiken/asynq/tools/asynqmon/cmd"
|
import "github.com/hibiken/asynq/tools/asynq/cmd"
|
||||||
|
|
||||||
func main() {
|
func main() {
|
||||||
cmd.Execute()
|
cmd.Execute()
|